Feed Advanced Search

Dec 31 2021

paulm added a comment to T6859: Falkon - VDG feedback.

This was a proposal for a browser rebrand that I posted on the Mozilla Wiki about a decade ago but I don't think many people saw it and too many were emotionally attached to the fox. Just also posting it here in case you wanted to use it. I knocked it up in MS Paint in about 10 minutes, so it's just for the concept and obviously not a polished final design or anything. Could change the colours if orange was too Firefox-like.

Dec 31 2021, 4:26 PM · Falkon

Dec 14 2020

hmehta added a watcher for Falkon: hmehta.
Dec 14 2020, 8:09 PM

Nov 21 2020

maboleth added a comment to T13888: Falkon using large amount of RAM over time.
Nov 21 2020, 2:38 PM · Falkon
SGOrava added a comment to T13888: Falkon using large amount of RAM over time.

It was also reported on bagtracker:
https://bugs.kde.org/show_bug.cgi?id=402835
https://bugs.kde.org/show_bug.cgi?id=429433

Nov 21 2020, 1:26 PM · Falkon
maboleth updated the task description for T13888: Falkon using large amount of RAM over time.
Nov 21 2020, 1:00 PM · Falkon
maboleth triaged T13888: Falkon using large amount of RAM over time as High priority.
Nov 21 2020, 12:57 PM · Falkon

Nov 17 2020

maboleth added a watcher for Falkon: maboleth.
Nov 17 2020, 4:01 PM

Jun 3 2020

shubham abandoned D19008: Add context menu entry to copy link text.
Jun 3 2020, 8:28 AM · Falkon

May 25 2020

alva abandoned D29719: Fix white flashes in new tabs.

Will submit an improved version on GitLab instead.

May 25 2020, 8:01 PM · Falkon

May 16 2020

drosca added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 16 2020, 12:23 PM · Falkon

May 13 2020

alva requested review of D29719: Fix white flashes in new tabs.
May 13 2020, 3:58 PM · Falkon

May 5 2020

carewolf added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 5 2020, 11:28 AM · Falkon

Apr 29 2020

puneethchanda updated subscribers of D26869: Fix Crash when "remember password" is clicked..

@drosca can you check this once.

Apr 29 2020, 12:45 PM · Falkon

Apr 20 2020

drosca accepted D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:58 AM · Falkon
carewolf added a reviewer for D29007: Make wheel-event fixup version dependent: drosca.
Apr 20 2020, 9:58 AM · Falkon
carewolf requested review of D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:57 AM · Falkon

Apr 11 2020

puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

keyword gets updated in the bookmark widget and organize bookmarks.

Apr 11 2020, 9:26 PM · Falkon
dfaure added a comment to D28550: Optimize Firefox bookmark import query and fix to include folders.

No idea, I'm not a Falkon developer.

Apr 11 2020, 8:39 AM · Falkon

Apr 9 2020

puneethchanda added a comment to D28661: Enable user to add keywords when saving bookmarks.

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

Apr 9 2020, 5:45 PM · Falkon
puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

fix the size of bookmark widget.

Apr 9 2020, 5:44 PM · Falkon
SGOrava added a comment to D28661: Enable user to add keywords when saving bookmarks.

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

Apr 9 2020, 5:41 PM · Falkon
puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

Update Placeholder

Apr 9 2020, 5:16 PM · Falkon
abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Improve query filter

Apr 9 2020, 3:07 AM · Falkon

Apr 7 2020

abogical updated subscribers of D28550: Optimize Firefox bookmark import query and fix to include folders.

@drosca @dfaure @SGOrava
Do I need to add subscribers other than falkon? I have 3 other differentials that needs review but no response is made for some time, unless I mention by name.

Apr 7 2020, 9:50 PM · Falkon
SGOrava added inline comments to D28661: Enable user to add keywords when saving bookmarks.
Apr 7 2020, 6:25 PM · Falkon
puneethchanda requested review of D28661: Enable user to add keywords when saving bookmarks.
Apr 7 2020, 4:32 PM · Falkon
puneethchanda added a watcher for Falkon: puneethchanda.
Apr 7 2020, 10:35 AM

Apr 4 2020

abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Comment grammar correction

Apr 4 2020, 6:18 AM · Falkon
abogical updated the test plan for D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:16 AM · Falkon
abogical requested review of D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:15 AM · Falkon
abogical requested review of D28549: Describe error when querying Firefox places.sqlite for bookmarks.
Apr 4 2020, 3:07 AM · Falkon

Mar 30 2020

allknow updated the diff for D28240: special character shown in warning dialog.
  • I fixed "if"
Mar 30 2020, 11:22 PM · Falkon
jachin added inline comments to D28240: special character shown in warning dialog.
Mar 30 2020, 10:48 PM · Falkon
abogical added inline comments to D28240: special character shown in warning dialog.
Mar 30 2020, 7:46 PM · Falkon

Mar 28 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Done requested change

Mar 28 2020, 4:45 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 28 2020, 10:13 AM · Falkon

Mar 25 2020

abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 25 2020, 1:27 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Use qAsConst

Mar 25 2020, 1:23 PM · Falkon
allknow updated the diff for D28240: special character shown in warning dialog.

Okay I fixed. thank you

Mar 25 2020, 1:16 PM · Falkon
drosca requested changes to D27655: Open all URLs in command line arguments.
Mar 25 2020, 6:20 AM · Falkon
drosca requested changes to D28198: QFile is open but not closed.

QFile is closed in the destructor, this is not needed.

Mar 25 2020, 6:19 AM · Falkon
drosca requested changes to D28240: special character shown in warning dialog.

It should be <br/> instead.

Mar 25 2020, 6:18 AM · Falkon

Mar 24 2020

jachin accepted D28240: special character shown in warning dialog.

https://forum.qt.io/topic/66191/new-line-n-doesn-t-work
As like this article, maybe dialog.setText(tr("...")) messages are translated in C type character type.
'\r\n' also would be works.
And checked with build source.

Mar 24 2020, 10:19 PM · Falkon
allknow updated subscribers of D28240: special character shown in warning dialog.
Mar 24 2020, 10:08 PM · Falkon
allknow added a comment to D28240: special character shown in warning dialog.

Mar 24 2020, 2:25 PM · Falkon
allknow requested review of D28240: special character shown in warning dialog.
Mar 24 2020, 2:23 PM · Falkon

Mar 22 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Used range loop as requested.

Mar 22 2020, 9:40 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 7:51 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Using QString reference as requested.

Mar 22 2020, 6:33 PM · Falkon
abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 6:07 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 1:31 PM · Falkon
allknow added a comment to D28198: QFile is open but not closed.

Sorry ... It's my mistake .. I'll study hard more..

Mar 22 2020, 11:33 AM · Falkon
SGOrava added a comment to D28198: QFile is open but not closed.

According to documentation it should be closed by Qt.
https://doc.qt.io/qt-5/qfile.html#dtor.QFile

Mar 22 2020, 11:30 AM · Falkon
davidre added a comment to D28198: QFile is open but not closed.

The destructor of QFile will close it, doesn't it?

Mar 22 2020, 11:25 AM · Falkon
allknow updated the summary of D28198: QFile is open but not closed.
Mar 22 2020, 11:22 AM · Falkon
allknow requested review of D28198: QFile is open but not closed.
Mar 22 2020, 11:21 AM · Falkon

Mar 21 2020

malibushko updated the diff for D28153: BUG 414295.

I tested it a little bit, and found out that the problem was not caused by 'name' attribute, but by 'key' - it is empty if an appropriate attribute is not present.
Now to check enter to https://my.amfoss.in/login (enter somethink and click save) and see there is not input
Then you can check it at any site (I choosed phabricator) - it should be autocompleted automatically

Mar 21 2020, 5:17 PM · Falkon
allknow added a comment to D28153: BUG 414295.

I think this is more better!
Because That causes an error. If you do that, you will not be able to automatically log in with the toolbar.

Mar 21 2020, 5:28 AM · Falkon
allknow requested changes to D28153: BUG 414295.
Mar 21 2020, 1:19 AM · Falkon

Mar 20 2020

malibushko updated the summary of D27791: BUG: 408312.
Mar 20 2020, 11:23 AM · Falkon
ognarb added a comment to D27791: BUG: 408312.

In "edit revision" in the sidebar in the right.

Mar 20 2020, 10:23 AM · Falkon
malibushko requested review of D28153: BUG 414295.
Mar 20 2020, 12:28 AM · Falkon
malibushko added a comment to D27791: BUG: 408312.

To improve the qualitity of the git history, it is recommanded to have a title that explain that it does (for example Add filter to Preferences > Extensions) and add BUG: 408312 in the summary so that the bug report is automatically closed when this diff is merged.

Mar 20 2020, 12:08 AM · Falkon
malibushko updated the summary of D27791: BUG: 408312.
Mar 20 2020, 12:04 AM · Falkon

Mar 19 2020

ognarb added a comment to D27791: BUG: 408312.

To improve the qualitity of the git history, it is recommanded to have a title that explain that it does (for example Add filter to Preferences > Extensions) and add BUG: 408312 in the summary so that the bug report is automatically closed when this diff is merged.

Mar 19 2020, 10:32 PM · Falkon
malibushko updated the diff for D27791: BUG: 408312.

Fixed due to issues

Mar 19 2020, 10:06 PM · Falkon

Mar 18 2020

allknow added a watcher for Falkon: allknow.
Mar 18 2020, 5:59 AM

Mar 8 2020

puneethchanda added a comment to D27440: autofill input fields failing for some sites.

@SGOrava can you please review this.

Mar 8 2020, 4:17 PM · Falkon

Mar 6 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Stylistic fix

Mar 6 2020, 5:34 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Done requested changes.

Mar 6 2020, 5:31 PM · Falkon
drosca added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 5:19 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Popping from QUrl list instead of using an iterator, as requested.

Mar 6 2020, 1:02 PM · Falkon
abogical updated the diff for D27691: Be able to launch a new non-private window from a private window.

Requested changes done.

Mar 6 2020, 12:42 PM · Falkon
drosca added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 12:33 PM · Falkon
abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 10:56 AM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Requested changes done.

Mar 6 2020, 10:52 AM · Falkon
drosca requested changes to D27655: Open all URLs in command line arguments.
Mar 6 2020, 7:31 AM · Falkon
drosca requested changes to D27691: Be able to launch a new non-private window from a private window.
Mar 6 2020, 7:23 AM · Falkon

Mar 5 2020

abogical added a comment to D27691: Be able to launch a new non-private window from a private window.

bump? @drosca

Mar 5 2020, 10:13 PM · Falkon
abogical updated subscribers of D27655: Open all URLs in command line arguments.

bump? @drosca @SGOrava

Mar 5 2020, 10:13 PM · Falkon

Mar 3 2020

SGOrava requested changes to D27791: BUG: 408312.
Mar 3 2020, 5:43 PM · Falkon
SGOrava added a comment to D27791: BUG: 408312.

Thank you for your contribution.

Mar 3 2020, 4:52 PM · Falkon

Mar 2 2020

malibushko added a reviewer for D27791: BUG: 408312: SGOrava.
Mar 2 2020, 6:53 PM · Falkon
malibushko requested review of D27791: BUG: 408312.
Mar 2 2020, 6:51 PM · Falkon

Feb 27 2020

abogical updated the diff for D27691: Be able to launch a new non-private window from a private window.

It's not supposed to create a new process, as falkon is designed to be a single process application. Nevertheless, I added a condition to send a new window command if an instance is running. This avoids process creation overhead.

Feb 27 2020, 10:20 PM · Falkon
drosca requested changes to D27691: Be able to launch a new non-private window from a private window.

There shouldn't be more than one Falkon process sharing one profile. The only exception is the private process, that is using (should be) all profile data in read-only mode.

Feb 27 2020, 3:25 PM · Falkon
abogical requested review of D27691: Be able to launch a new non-private window from a private window.
Feb 27 2020, 2:08 AM · Falkon

Feb 25 2020

abogical updated the test plan for D27655: Open all URLs in command line arguments.
Feb 25 2020, 5:39 PM · Falkon
abogical added a comment to D27655: Open all URLs in command line arguments.

In case you're wondering, Yes, I'm interested in becoming a GSoC student. I've contributed to different KDE projects including this year's SoK. However, this is my first patch to Falkon. Once this is done, you can recommend another bug to fix if you prefer.

Feb 25 2020, 4:34 PM · Falkon
abogical updated subscribers of D27655: Open all URLs in command line arguments.
Feb 25 2020, 4:16 PM · Falkon
abogical requested review of D27655: Open all URLs in command line arguments.
Feb 25 2020, 4:13 PM · Falkon

Feb 22 2020

puneethchanda added a comment to D27440: autofill input fields failing for some sites.

@drosca sorry for the delay.

Feb 22 2020, 6:09 AM · Falkon
puneethchanda updated the diff for D27440: autofill input fields failing for some sites.

remove redundant code and add fill for email.

Feb 22 2020, 6:09 AM · Falkon

Feb 20 2020

puneethchanda added a comment to D27440: autofill input fields failing for some sites.

it looks if there is no name tag specified in the input tag, then we need to look for placeholder and I am filling the first part of the vector to username and the second to password.
anyways I will update the patch now.

Feb 20 2020, 11:11 AM · Falkon

Feb 19 2020

drosca requested changes to D27440: autofill input fields failing for some sites.

I don't really like, there is ton of duplicated code. Also coding style is wrong.

Feb 19 2020, 12:08 PM · Falkon

Feb 17 2020

puneethchanda added a comment to D27440: autofill input fields failing for some sites.

@SGOrava @drosca is this good.

Feb 17 2020, 3:11 PM · Falkon

Feb 16 2020

puneethchanda updated the summary of D27440: autofill input fields failing for some sites.
Feb 16 2020, 6:21 PM · Falkon
puneethchanda updated the diff for D27440: autofill input fields failing for some sites.
Feb 16 2020, 6:20 PM · Falkon
puneethchanda updated the summary of D27440: autofill input fields failing for some sites.
Feb 16 2020, 6:17 PM · Falkon
puneethchanda requested review of D27440: autofill input fields failing for some sites.
Feb 16 2020, 6:13 PM · Falkon