At least squares and diamonds are incorrect, too.

Ok, so at least we're consistent in doing wrong :) I'll fix it.

I think it should. But not in this patch.

In D20760#461314, @sander wrote:

At least squares and diamonds are incorrect, too.

At least squares and diamonds are incorrect, too.

In D20760#461261, @sander wrote:

Is this really how they are supposed to look? If not, is this a poppler bug, or is Okular missing some further line ending setup code?

I tried the circle line endings and they look a bit strange to me:

Looks great to me now!

Thanks! Will commit on tuesday, if nowbody objects.

Use QStringLiteral with Unicode code points for line ending symbols.

I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons.

Added documentation

remove unrelated code from patch

ping ? :)

needs autotest

How about the following approach (not tested)? This way, other parameters (like nameddest) wouldn’t break it and can be added later.

In D20760#456328, @davidhurka wrote:

Isn’t there a coding convention against non-ascii symbols in source code?

Fix comment gave by albert

Add tooltips to clarify the line ending style works only for PDF documents.

In D20760#455512, @knambiar wrote:

Indeed, I thought about PDF alone (that’s my most pressing use case). In that case, should this combobox mention something like “only for PDF documents”?

Isn’t there a coding convention against non-ascii symbols in source code?

Place the symbols to left of ending style description for better alignment.

In D20760#455351, @tobiasdeiminger wrote:

So your drop down selection will currently be ignored for EPUB, DjVu, ..., only PDF works. @ngraham: Do you think the patch could land as PDF-only, or do we need multi-format support from the beginning?

Nice! The symbol/icon should be to the left of the text. That way all the symbols and texts line up vertically in the combobox's pop-up.

In D20760#455307, @knambiar wrote:

In D20760#455290, @tobiasdeiminger wrote:

Would it be useful if I tried to provide an SVG as replacement for the unicode symbols in an upcoming version, to resemble the exact line end drawing instructions as we do them in poppler code?

Certainly. Meanwhile I read the documentation and see that QComboBox::setItemIcon can be used to set the icon for combo box text.

Merge the two commits (previous revision update had only the second change).

In D20760#455290, @tobiasdeiminger wrote:

Nice patch! Guess unicode symbols are good for a start.

In D20760#455266, @knambiar wrote:

Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.

Add Unicode symbols to the line ending style. Didn’t find suitable symbols for ‘Right Closed Arrow’ and ‘Slash’.

In D20760#455010, @ngraham wrote:

Hey, that's pretty cool! Any chance you could include a little icon/preview of the visual style for each item in the combobox?

Hey, that's pretty cool! Any chance you could include a little icon/preview of the visual style for each item in the combobox?

In D19717#454567, @joaonetto wrote:

In my honest opinion we shouldn't support for '\n' search, unless it's something like regex search, but I see you disagree.

Hmmmmm. I can think of checking if the '\n' is in the search bar.

In D19717#454320, @joaonetto wrote:

Made the necessary changes to work with any type of space.

It probably will work, I'll try it

In D19717#454323, @joaonetto wrote:

It should work now, can you test it?

In D19717#454164, @davidhurka wrote:

Made the necessary changes to work with any type of space.

In D19717#454160, @joaonetto wrote:

In D19717#454108, @davidhurka wrote:

In D19717#453821, @aacid wrote:

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

The use case to insert a newline could be:
Someone is testing a LaTeX document, and searches for a passage from the source code (maybe some verbatim code).
One would just copy the passage in Kate and paste it into the search box in Okular.

Hmmmmm, I can treat things differently if there's a new line in the search box.

Or maybe I should find a way to treat spaces the same as newline chars.

I'll have to take a look in the compare function to see how it would handle, maybe compare alphanumeric only?

If I can't do that, I'll have to treat them differently.

In D19717#454108, @davidhurka wrote:

In D19717#453821, @aacid wrote:

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

The use case to insert a newline could be:
Someone is testing a LaTeX document, and searches for a passage from the source code (maybe some verbatim code).
One would just copy the passage in Kate and paste it into the search box in Okular.

In D19717#453821, @aacid wrote:

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D

Opinions?

In my opinion is better to have it this way, I guess most users don't know about the newline.

There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.

This is bad.

Thanks :)

You've already got my approval. :)

@ngraham @aacid Ping?

In D18179#450252, @ngraham wrote:

OK, let's go for it!

@michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :)

OK, let's go for it!

i have not tested it, if you think it works, i guess it's ok from the pure code point of view.

Ping on this.

In D20437#448028, @kezik wrote:

It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name

@aacid if I put my relicensing preferences on the kde dev script repo, will you consider the patch?

In D20437#447843, @ngraham wrote:

In D20437#447774, @aacid wrote:

Still has a fake name attached to it?

If so i'll refrain from looking at the code and getting tainted by it.

Can you clarify how reviewing this patch would taint you?

In D20488#449028, @heikobecker wrote:

Thanks for landing.

Not sure how common that poppler version still is, but do you think it's worth a respin for 19.04?

Thanks for landing.

Awesome thanks.

Out of deference to @aacid, I'll wait to commit this until the mailing list thread has come to a conclusion we can all agree with, or at least graciously accept without complaining about it later. :)

In D20437#448397, @ngraham wrote:

1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?

1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?

Even more clear

In D16519#447765, @aacid wrote:

In D16519#447479, @ngraham wrote:

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

1. re-open the discussion on a mailing list or phab task

I don't know what makes you think *I* should be the one re-open the discussion on a mailing list or phab task, AFAIR *you* are the first person ever to commit hard to trace commits to Okular repo, so it's on *you* to show why we have to agree to such tainting.

Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).

Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant is a multiplicative factor, it really doesn't matter, it's only set to a nice value

As requested I explain what the "arbitrary constant" does