I think this is needed in 18.12 branch as well?

Related https://phabricator.kde.org/D16867

Thanks a lot guys!

Have you tested creating a new deployable Windows package?

Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)

Looks good to me!

ping

Cool thanks, I'll update this by 22nd July.

I was just wondering if there is a way to test these changes locally?

Looks good (should we switch to the new connect syntax?).

Sounds good. I'm not exactly familiar with this issue but it looks reasonable. Thanks a lot! :-)

Sorry, but I am currently not active in Marble, so have no clue about things & needs, have to pull out here.

I was just wondering if there is a way to test these changes locally?

Can I please have a review?

Good catch! Looks good to me. Could you commit?

Ping

Ping?

I intentionally left the old logic so it doesn't break your work-flow but it should allow to remove quite some code.

Any updates on this one? I was looking forward to completely finish this and have a complete QtWebEngine backend.

How are we doing here? Can we land this?

Just for info, I added a splash screen, as per https://phabricator.kde.org/D7805 . In case that is not how we intend the final splash screen to look like, we can brainstorm more and work on it, and then close this task when the screen looks done.

One more commit pushed to master: https://commits.kde.org/marble/575c6aa788192d58e71eea6ddd8db228ff854f2b.

I approve, FWIW.

Note: The changes showing in the latest diff here does not include the previous changes, but only show the changes that have been made on top of the already committed changes.

Should I push these changes to master in a different commit now?

Lovely, much better.

Did a clean build after removing the existing build and export folder and recreating them.

I had adjusted the values to 256 in that line previously as well, and it was showing the icon in that manner. However, I just did a clean build again from scratch, and the icon looks good now. Maybe earlier it was using cached image from before somehow.

@rahn please rememeber to close this when you commit things so they don't stay open forever.

To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.

The 256x256 version surely looks better than that:

I'm not sure if something.svg can be added to the splash.xml file as drawable/something, because I tried it, and the screen shows blank without any photo in the splash screen.

Pushed to master: https://commits.kde.org/marble/d60718c0864f7686701ba45585a52ac45b2f79c0

Does the SVG version look any better?

Added the 256x256 version of the png that was submitted to master a while back. Doesn't make a difference from earlier wrt the blur.

I'll update the diff in a few hours.

Please commit.

... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).

I've just submitted the 256x256 version of the png to master ...

@sanjibanb, can you update the new splash screen to use the SVG that Torsten is referring to?

Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!

Does this look good enough to be accepted?

Pushed to master: https://commits.kde.org/marble/6b463af73689b54af8f8573c7c3fa5d47f752727

Great!

Updating diff so that it shows 100x100 icon now, to get rid of the blur.

Splash screen of Google Maps looks something like this:

I rather prefer 100x100 since it looks nice and sharp, but would accept 150x150 if other folks think it's okay.

Looks to me too that the logo has been scaled up. However, the blur becomes quite negligible if I show just 150x150 imo.

That still looks blurry to me, though it's not your fault. The source 192x192 image itself looks blurry, as if it's been scaled up. Shame we don't have a better icon, or it's not an SVG. If you can change the size of the icon to the point where it doesn't look blurry, I'll approve it.

Looks like the highest resolution of the Marble logo that we have at the moment is 192 x 192: https://github.com/KDE/marble/blob/master/data/android/drawable-xxxhdpi/marblelogo.png . We can reduce the size to 192x192 to get rid of the blur, in which case it would look something like this.

The size is much better, but now it's rather blurry. Is there a high-res icon we can use instead?

Screenshot of the current splash screen

Increased the size of Marble logo in the splash screen to 256x256

Pushed to master: https://commits.kde.org/marble/418d9fc56a368de709868499624b67b0214bfadb

Looks fine to me, great to see it being improved!

In D7625#145828, @rahn wrote:

And backported to 17.08 branch. Does this patch require any more action?

Nothing but indentation (see 223-226 in patched source).
This wrong indentation is side effect for minimizing patch.

Cool, I think I can wait till the end of the day for Judit to verify this. If there are no concerns by then, I can push this commit tomorrow morning so that Judit can look into the changes after that.

And backported to 17.08 branch. Does this patch require any more action?

Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)

Looks fine to me. Maybe Judit can confirm this patch?

Looks nice indeed - but the logo should be bigger.

I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?

Submitted to master.

Not the best splash screen I'd say. I'm just showing a small marble logo on a white background. Feel free to recommend better designs, if possible?

Can you add a screenshot of what this looks like, maybe?