Feed Advanced Search

Fri, May 17

ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This is functionally much better! Now I can tell where the keyboard focus is. Visually I think it's a small improvement but we can do even better for the list and grid items and also be more consistent with how other apps generally handle this.

Fri, May 17, 10:00 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • use a rectangle around the current item with focus in view selector
  • use rectangle borders to show the active focus in most elements
Fri, May 17, 6:42 PM · Elisa

Mon, May 13

ngraham added a member for Elisa: ngraham.
Mon, May 13, 9:33 PM
ngraham removed a watcher for Elisa: ngraham.
Mon, May 13, 9:33 PM
mgallien closed D21039: avoid sending wrong or empty metadata to mpris2 interface.
Mon, May 13, 8:11 PM · Elisa
ngraham accepted D21039: avoid sending wrong or empty metadata to mpris2 interface.

Works for me, thanks.

Mon, May 13, 6:01 PM · Elisa

Sun, May 12

mgallien added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Ping.
I would like if possible to get this in before end of next week to have in the 0.4.0 release.

Sun, May 12, 8:07 PM · Elisa

Wed, May 8

ngraham added a comment to D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

Wed, May 8, 3:36 PM · Elisa
mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

I feel like a cleaner focus indication style for a modern app like Elisa is to highlight the particular control or list itemthat currently has focus, rather than drawing a colored frame around an entire view. For example in your screenshots, instead of drawing a blue frame to indicate that the view has focus, I would make the song highlight blue rather than gray. This actually communicates more information: not only does it tell you that the view has focus, but you also clearly see which exact element within the view has focus.

Wed, May 8, 2:41 PM · Elisa
mgallien closed D21080: fix some layouts to look correct when reversed (typical for RTL locale).
Wed, May 8, 2:33 PM · Elisa
ngraham accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

Wed, May 8, 2:17 PM · Elisa
safaalfulaij accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Can't test, but seems fine.
Thanks for informing! :)

Wed, May 8, 2:12 PM · Elisa
mgallien closed D21043: do not extend mouse areas in header bar longer than the text.
Wed, May 8, 2:12 PM · Elisa
ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

Wed, May 8, 2:11 PM · Elisa
ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This looks much better, thanks. It makes sense that font.pointSize should be rounded to an integer value.

Wed, May 8, 1:58 PM · Elisa
mgallien retitled D21081: fix focus rectangle not visible in single album view mode from GIT_SILENT made messages (after extraction) to fix focus rectangle not visible in single album view mode.
Wed, May 8, 1:29 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

try to include only the correct commit

Wed, May 8, 1:28 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

an extra commit from 0.4 is included

Wed, May 8, 1:27 PM · Elisa
mgallien added a project to D21081: fix focus rectangle not visible in single album view mode: Elisa.
Wed, May 8, 1:26 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

This now works!

However I'm left to wonder why all this rigamarole with TextMetrics is even necessary at all. I notice that if I remove all the TextMetrics components, and let the labels auto-size themselves by removing Layout.fillWidth and Layout.maximumWidth, everything works fine except for the artist label, which gets elided. But I notice that it only gets elided when the point size is set to elisaTheme.defaultFontPointSize * 1.5. If I change the multiplier to 1, 1.4 or 2, it works. However a multiplier of 1.5, 1.75, or any other odd value triggers the bug. This is reproducible for all fonts and sizes that I tried.

I don't understand this bug, but a less invasive workaround might be simply to change the multiplier a bit rather than do all this stuff with TextMetrics.

Wed, May 8, 12:47 PM · Elisa
mgallien added a project to D21080: fix some layouts to look correct when reversed (typical for RTL locale): Elisa.
Wed, May 8, 12:46 PM · Elisa
mgallien added reviewers for D21039: avoid sending wrong or empty metadata to mpris2 interface: astippich, ngraham.
Wed, May 8, 9:08 AM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use Math.round to avoid having a font.pointSize being decimal
Wed, May 8, 9:07 AM · Elisa

Tue, May 7

ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This now works!

Tue, May 7, 6:43 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • fix corner cases by adding an extra length
Tue, May 7, 5:58 PM · Elisa

Mon, May 6

ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

I'm afraid even with this latest update to the patch, I still see elided text. :(

Mon, May 6, 8:55 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

As you can see, it's even worse with default settings since the four-letter album name gets elided too.

Mon, May 6, 8:50 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use the correct way to get the width of the text
Mon, May 6, 8:49 PM · Elisa
ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

Mon, May 6, 8:41 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

For me this patch re-introduces the original bug (https://bugs.kde.org/show_bug.cgi?id=406483).

Mon, May 6, 7:53 PM · Elisa
James added a comment to T6356: Integrate visualization branch.

Would this be for music visualizations, by chance? As in spectrum analyzers, etc?

Mon, May 6, 5:45 PM · Elisa
ngraham requested changes to D21043: do not extend mouse areas in header bar longer than the text.

For me this patch re-introduces the original bug (https://bugs.kde.org/show_bug.cgi?id=406483).

Mon, May 6, 3:30 PM · Elisa
mgallien added a project to D21043: do not extend mouse areas in header bar longer than the text: Elisa.
Mon, May 6, 5:29 AM · Elisa
mgallien added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Does Plasma crash because of this or Elisa?

Mon, May 6, 5:10 AM · Elisa

Sun, May 5

broulik added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Does Plasma crash because of this or Elisa?

Sun, May 5, 9:29 PM · Elisa
mgallien added a project to D21039: avoid sending wrong or empty metadata to mpris2 interface: Elisa.
Sun, May 5, 8:58 PM · Elisa
trmdi added a comment to D21006: Add global menu by using qml native menu components.

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

Sun, May 5, 8:52 AM · Elisa

Sat, May 4

mgallien added a comment to D21006: Add global menu by using qml native menu components.

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Sat, May 4, 7:50 PM · Elisa
mgallien added a comment to D21006: Add global menu by using qml native menu components.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Sat, May 4, 7:49 PM · Elisa
trmdi added a comment to D21006: Add global menu by using qml native menu components.

Why is it like this:

Sat, May 4, 8:08 AM · Elisa
ngraham added a comment to D21006: Add global menu by using qml native menu components.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Sat, May 4, 3:27 AM · Elisa

Fri, May 3

mgallien added a project to D21006: Add global menu by using qml native menu components: Elisa.
Fri, May 3, 8:25 PM · Elisa
ngraham added a comment to D20879: do not forget the album cover when using embedded cover images.

So much better now!

Fri, May 3, 1:43 PM · Elisa
mgallien closed D20944: fix upgrades from 0.3 stable version.
Fri, May 3, 5:06 AM · Elisa
mgallien closed D20879: do not forget the album cover when using embedded cover images.
Fri, May 3, 5:06 AM · Elisa

Thu, May 2

ngraham accepted D20879: do not forget the album cover when using embedded cover images.
Thu, May 2, 9:56 PM · Elisa
ngraham accepted D20944: fix upgrades from 0.3 stable version.

Yep, a cleanup of my Baloo database fixed it, so that looks like a Baloo bug rather than an Elisa bug. Upgrade works now.

Thu, May 2, 9:56 PM · Elisa
mgallien added a comment to D20944: fix upgrades from 0.3 stable version.

I'm not sure whether it's related to this or not, but now I get stuck on a particular song again. I can paste the full log, but the last item seems revelant:

org.kde.elisa.baloo: LocalBalooFileListing::triggerRefreshOfContent "/home/nate/Music/Franz Ferdinand/Franz Ferdinand/10 Come On Home.mp3" file does not exists

Sure enough, I deleted that song a few days ago.

Thu, May 2, 8:35 PM · Elisa
ngraham added a comment to D20944: fix upgrades from 0.3 stable version.

I'm not sure whether it's related to this or not, but now I get stuck on a particular song again. I can paste the full log, but the last item seems revelant:

Thu, May 2, 7:00 PM · Elisa

Wed, May 1

mgallien added a project to D20944: fix upgrades from 0.3 stable version: Elisa.
Wed, May 1, 8:33 PM · Elisa
mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

Out of curiosity where on disk is the database located, and is it safe to blow away for testing purposes?

Wed, May 1, 2:27 PM · Elisa
mgallien closed D20929: fix compilation to not require filesystem stl c++ header.
Wed, May 1, 2:04 PM · Elisa
mgallien added a comment to D20929: fix compilation to not require filesystem stl c++ header.
In D20929#458998, @pino wrote:

Looks ok now, thanks for the changes.

Wed, May 1, 2:03 PM · Elisa
pino accepted D20929: fix compilation to not require filesystem stl c++ header.

Looks ok now, thanks for the changes.

Wed, May 1, 2:03 PM · Elisa
mgallien updated the diff for D20929: fix compilation to not require filesystem stl c++ header.
  • simplify the QDir::rename usage
Wed, May 1, 1:48 PM · Elisa
pino added inline comments to D20929: fix compilation to not require filesystem stl c++ header.
Wed, May 1, 12:45 PM · Elisa
mgallien updated the diff for D20929: fix compilation to not require filesystem stl c++ header.
  • remove the #if
Wed, May 1, 12:13 PM · Elisa
mgallien added a comment to D20929: fix compilation to not require filesystem stl c++ header.
In D20929#458881, @pino wrote:

Or, even better, just unconditionally use QDir::rename? This way there is no need to maintain two different code paths with a number of arbitrary #ifdef blocks.

Wed, May 1, 11:43 AM · Elisa
pino added a comment to D20929: fix compilation to not require filesystem stl c++ header.

Or, even better, just unconditionally use QDir::rename? This way there is no need to maintain two different code paths with a number of arbitrary #ifdef blocks.

Wed, May 1, 7:27 AM · Elisa
ngraham accepted D20929: fix compilation to not require filesystem stl c++ header.

Seems sensible.

Wed, May 1, 2:20 AM · Elisa
ngraham added a comment to D20879: do not forget the album cover when using embedded cover images.

Out of curiosity where on disk is the database located, and is it safe to blow away for testing purposes?

Wed, May 1, 2:19 AM · Elisa

Tue, Apr 30

mgallien added a project to D20929: fix compilation to not require filesystem stl c++ header: Elisa.
Tue, Apr 30, 10:04 PM · Elisa
mgallien added a comment to T7567: Add support for radio streams.

Hello,

Just to keep you updated about my progress, I could read a radio stream within Elisa. I also could get some information from the stream like the current played song and update the information in the interface (in the headerbar and the playlist).

Tue, Apr 30, 9:53 PM · Elisa
mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

It would be nice to fix it without re-importing, yes. If that's necessary, it should happen automatically. Does that already happen for people who upgrade from one stable release to another?

Tue, Apr 30, 9:50 PM · Elisa
jguidon added a comment to T7567: Add support for radio streams.

Just to keep you updated about my progress, I could read a radio stream within Elisa. I also could get some information from the stream like the current played song and update the information in the interface (in the headerbar and the playlist).

Tue, Apr 30, 6:45 PM · Elisa
mgallien closed D20880: Reduce the size of busy indicators.
Tue, Apr 30, 3:40 PM · Elisa
mgallien accepted D20880: Reduce the size of busy indicators.
Tue, Apr 30, 3:37 PM · Elisa
mgallien added a comment to D20880: Reduce the size of busy indicators.

Thanks for your work.
Please can you add the required version for Kirigami in the CMakeLists.txt file ?
Apart from that, this is fine for me

Gladly. That would just mean setting the required Kirigami version to 2.5.0 instead of using the required KF5 version, right?

In fact, kirigami2 has the same version than other KF5 frameworks. I will land your patch without the CMakeLists.txt change. Sorry for that.

Nice! Can you provide your full name and email address so we can land this with correct authorship information once @mgallien has accepted it?

@mgallien looks like we already have Kirigami listed in CMakeLists.txt, and I think Units has been around in it since forever-ish.

Sure, name is David Koermendi, email is nilsolm(at)vivaldi(dot)net.

Tue, Apr 30, 3:20 PM · Elisa
mgallien added a project to D20880: Reduce the size of busy indicators: Elisa.
Tue, Apr 30, 3:18 PM · Elisa
mgallien retitled D20879: do not forget the album cover when using embedded cover images from [WIP] do not forget the album cover when using embedded cover images to do not forget the album cover when using embedded cover images.
Tue, Apr 30, 3:17 PM · Elisa
mgallien updated the diff for D20879: do not forget the album cover when using embedded cover images.
  • allow proper load of embedded cover even when database has wrong data
Tue, Apr 30, 3:16 PM · Elisa

Mon, Apr 29

ngraham added a comment to D20879: do not forget the album cover when using embedded cover images.

It would be nice to fix it without re-importing, yes. If that's necessary, it should happen automatically. Does that already happen for people who upgrade from one stable release to another?

Mon, Apr 29, 4:33 PM · Elisa

Sun, Apr 28

mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Sun, Apr 28, 3:05 PM · Elisa
mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Sun, Apr 28, 3:04 PM · Elisa
ngraham accepted D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Sun, Apr 28, 3:01 PM · Elisa
mgallien added a project to D20879: do not forget the album cover when using embedded cover images: Elisa.
Sun, Apr 28, 2:55 PM · Elisa

Fri, Apr 26

astippich added a comment to T10847: Fix genre, composer and lyricist database insertion.

4fc83654f413

Fri, Apr 26, 5:34 AM · Elisa

Thu, Apr 25

mgallien moved T10847: Fix genre, composer and lyricist database insertion from Backlog to Next release on the Elisa board.
Thu, Apr 25, 9:42 AM · Elisa
mgallien moved T10848: Fix layouts in RTL mode (Right to left) from Backlog to Next release on the Elisa board.
Thu, Apr 25, 9:41 AM · Elisa
mgallien created T10848: Fix layouts in RTL mode (Right to left).
Thu, Apr 25, 9:40 AM · Elisa
mgallien created T10847: Fix genre, composer and lyricist database insertion.
Thu, Apr 25, 9:32 AM · Elisa

Wed, Apr 24

mgallien added a comment to T10835: Create CI Jobs for stable branch of Elisa.

@bcooksley thanks for your help

Wed, Apr 24, 8:52 AM · Elisa, build.kde.org
bcooksley added a comment to T10835: Create CI Jobs for stable branch of Elisa.

First jobs started - https://build.kde.org/job/Extragear/job/elisa/

Wed, Apr 24, 8:36 AM · Elisa, build.kde.org
mgallien added a comment to T10835: Create CI Jobs for stable branch of Elisa.

Thanks for the information.
I have added a stable branch.
Could you please run the DSL Job Seed job?

Wed, Apr 24, 8:28 AM · Elisa, build.kde.org
bcooksley closed T10835: Create CI Jobs for stable branch of Elisa as Resolved.

The lack of stable builds for Elisa is due to a lack of stable branch definitions in logical-module-structure in the kde-build-metadata repository.
(See the existing Elisa section)

Wed, Apr 24, 8:03 AM · Elisa, build.kde.org

Apr 23 2019

mgallien created T10835: Create CI Jobs for stable branch of Elisa.
Apr 23 2019, 10:05 PM · Elisa, build.kde.org

Apr 22 2019

James added a watcher for Elisa: James.
Apr 22 2019, 2:36 PM

Apr 18 2019

mgallien closed T5376: Allow to undo the clear actions on the playlist as Resolved.
Apr 18 2019, 3:28 PM · Elisa

Apr 17 2019

mgallien updated subscribers of T10800: Send CI build mails of Elisa to the Elisa mailing list.

Thanks @bcooksley for your help.

Apr 17 2019, 3:34 PM · Elisa, build.kde.org

Apr 16 2019

jguidon moved T5376: Allow to undo the clear actions on the playlist from In Progress to Done on the Elisa board.
Apr 16 2019, 3:22 PM · Elisa
bcooksley closed T10800: Send CI build mails of Elisa to the Elisa mailing list as Resolved by committing R857:0edf2168b41c: Enable CI notifications for Elisa..
Apr 16 2019, 10:14 AM · Elisa, build.kde.org
mgallien renamed T10800: Send CI build mails of Elisa to the Elisa mailing list from Send BI build mails of Elisa to the Elisa mailing list to Send CI build mails of Elisa to the Elisa mailing list.
Apr 16 2019, 8:20 AM · Elisa, build.kde.org

Apr 15 2019

mgallien created T10800: Send CI build mails of Elisa to the Elisa mailing list.
Apr 15 2019, 5:19 PM · Elisa, build.kde.org
mgallien closed T10330: Implement new context view from mockup as Resolved.
Apr 15 2019, 5:51 AM · Elisa
mgallien closed T10360: Implement Power Management Sleep Inhibition while Playing Music as Resolved.
Apr 15 2019, 5:51 AM · Elisa
mgallien moved T10360: Implement Power Management Sleep Inhibition while Playing Music from In Progress to Done on the Elisa board.
Apr 15 2019, 5:51 AM · Elisa
mgallien moved T10330: Implement new context view from mockup from In Progress to Done on the Elisa board.
Apr 15 2019, 5:51 AM · Elisa
mgallien closed D18351: Prevent the host computer to sleep while playing music.
Apr 15 2019, 5:46 AM · Elisa
mgallien updated the diff for D18351: Prevent the host computer to sleep while playing music.
  • implement more methods to inhibit sleep (support Gnome and Logind)
  • prevent sleep again on Plasma workspace
  • remove the calls to logind inhibit interface: does nothing right now
Apr 15 2019, 5:36 AM · Elisa

Apr 13 2019

mgallien added a comment to T7567: Add support for radio streams.

Hello,

Hi,

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

I am motivated to take a look.

Apr 13 2019, 8:12 PM · Elisa