• use clicked consistently
• fix click with audio files

Good idea.

Oops, my bad. Just one thing to change:

friendly ping

• fix tests

• rebase

In D22576#498503, @ngraham wrote:

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

We can go with this for now, but I'd prefer for InlineMessage to gain the ability to display a busy indicator natively, and then we can port it to use that directly. Let's add a TODO comment in the code that mentions this.

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

LGTM!

In D21911#495600, @ngraham wrote:

That's probably worth a Kirigami bug report.

• add actions

I believe we'll need @abetts .svg file- I can't seem to find it.

That's probably worth a Kirigami bug report.

• wrap main label in case no secondary text is displayed

sorry!

• completely remove signal

I tried to implement the actions for load and save playlist. However, InlineMessage seems only to be compatible with Kirigami Actions and not with the qqc2 ones, which is unfortunate

• fixup type

Yes, the Kirigami SearchField should be a drop-in replacement. I actually tried to do it as a part of my patch to redo the main view's toolbar but got conflicting shortcut errors and dropped it for the moment.

I haven't looked that much into leveraging Kirigami yet and did not know about the FormLayout, so thanks. When the consolidation of the existing qml code and the full port to qqc2 is done, I will have a look at it.
There is also the search bar etc. which could be replaced by Kirigami components, I think.
Btw, there still is D21911 :)

Makes sense. :) LGTM!

Definitely, but I wanted to get it fully working before I break it again :)

Sensible improvement. A nice next step would be to make the whole metadata view into a standalone Kirigami FormLayout instead of each user making its own ListView or ColumnLayout, and each item being a RowLayout full of custom sizing and alignment code.

Should use the same grid and list browser delegates used by the other views IMO.

• fixup

before

+1, this consolidation makes sense.

• actually add new file

• fix text and apply error type

Please see my comment and other comments

In D22310#493134, @ngraham wrote:

How about only setting the width and height explicitly for the back and sort buttons, and adding TODO or FIXME comments so that we know why it's set?

How about only setting the width and height explicitly for the back and sort buttons, and adding TODO or FIXME comments so that we know why it's set?

• more cleanup

• fix text elide after hovering items

Actually sorry, just found a UI regression.

Very nice.

Thanks, much better! Just one more little thing, then ship it.

In D22332#492786, @ngraham wrote:

+1, but I found two little issues:

• The MouseArea's height is quite short, so it's hard to get the cursor into the right place. I would recommend making it span the full height of the player bar rather than simply just filling the area of the slider.
• When scrolled, the handle's movement on the volume slider is instantaneous, but for the playback position slider it lags about half a second. This is not related to this patch here, but it making it scrollable makes this pre-existing issue more prominent.

• make MouseArea span the whole height

+1, but I found two little issues:

• The MouseArea's height is quite short, so it's hard to get the cursor into the right place. I would recommend making it span the full height of the player bar rather than simply just filling the area of the slider.
• When scrolled, the handle's movement on the volume slider is instantaneous, but for the playback position slider it lags about half a second. This is not related to this patch here, but it making it scrollable makes this pre-existing issue more prominent.

• update and rebase

I actually found a bug: when the icon height and width are not specified, actions using dynamic icons won't work (e.g. icon is dependent on some variable) . The icon will not be displayed. This should probably be investigated, but for now I would like to continue with the specified icon size

In D22310#491944, @ngraham wrote:

As before, I don't like how FlatButtonWithToolTip requires that every button manually specify its own size. I think the FlatButtonWithToolTip should have an adequate default size so that this boilerplate isn't necessary.

+1, this makes perfect sense IMO. Code looks good!

As before, I don't like how FlatButtonWithToolTip requires that every button manually specify its own size. I think the FlatButtonWithToolTip should have an adequate default size so that this boilerplate isn't necessary.

• always enable playlist toggle action

New look:

In D22204#491507, @mgallien wrote:

In D22204#491479, @astippich wrote:

I would very much prefer to merge the code as is and improve afterwards as it touches various place and would be a pain to rebase.

I cannot review it now but it can go if you follow on with any issues that would be found. Sorry for my lack of time.

No worries. Stay cool!

In D22204#491479, @astippich wrote:

I would very much prefer to merge the code as is and improve afterwards as it touches various place and would be a pain to rebase.

I would very much prefer to merge the code as is and improve afterwards as it touches various place and would be a pain to rebase.

+1 for merging them; I noticed the same thing. Maybe that should even be done first or in this patch.

+1, let's use the existing styling here for consistency.