Feed Advanced Search

Apr 30 2019

mgallien accepted D20880: Reduce the size of busy indicators.
Apr 30 2019, 3:37 PM · Elisa
mgallien added a comment to D20880: Reduce the size of busy indicators.

Thanks for your work.
Please can you add the required version for Kirigami in the CMakeLists.txt file ?
Apart from that, this is fine for me

Gladly. That would just mean setting the required Kirigami version to 2.5.0 instead of using the required KF5 version, right?

In fact, kirigami2 has the same version than other KF5 frameworks. I will land your patch without the CMakeLists.txt change. Sorry for that.

Nice! Can you provide your full name and email address so we can land this with correct authorship information once @mgallien has accepted it?

@mgallien looks like we already have Kirigami listed in CMakeLists.txt, and I think Units has been around in it since forever-ish.

Sure, name is David Koermendi, email is nilsolm(at)vivaldi(dot)net.

Apr 30 2019, 3:20 PM · Elisa
mgallien added a project to D20880: Reduce the size of busy indicators: Elisa.
Apr 30 2019, 3:18 PM · Elisa
mgallien retitled D20879: do not forget the album cover when using embedded cover images from [WIP] do not forget the album cover when using embedded cover images to do not forget the album cover when using embedded cover images.
Apr 30 2019, 3:17 PM · Elisa
mgallien updated the diff for D20879: do not forget the album cover when using embedded cover images.
  • allow proper load of embedded cover even when database has wrong data
Apr 30 2019, 3:16 PM · Elisa

Apr 29 2019

ngraham added a comment to D20879: do not forget the album cover when using embedded cover images.

It would be nice to fix it without re-importing, yes. If that's necessary, it should happen automatically. Does that already happen for people who upgrade from one stable release to another?

Apr 29 2019, 4:33 PM · Elisa

Apr 28 2019

mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Apr 28 2019, 3:05 PM · Elisa
mgallien added a comment to D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Apr 28 2019, 3:04 PM · Elisa
ngraham accepted D20879: do not forget the album cover when using embedded cover images.

Yep, confirmed that this fixes the issue for all of my albums that lacked art, after re-importing the library. Thanks!

Apr 28 2019, 3:01 PM · Elisa
mgallien added a project to D20879: do not forget the album cover when using embedded cover images: Elisa.
Apr 28 2019, 2:55 PM · Elisa

Apr 26 2019

astippich added a comment to T10847: Fix genre, composer and lyricist database insertion.

4fc83654f413

Apr 26 2019, 5:34 AM · Elisa

Apr 25 2019

mgallien moved T10847: Fix genre, composer and lyricist database insertion from Backlog to Next release on the Elisa board.
Apr 25 2019, 9:42 AM · Elisa
mgallien moved T10848: Fix layouts in RTL mode (Right to left) from Backlog to Next release on the Elisa board.
Apr 25 2019, 9:41 AM · Elisa
mgallien created T10848: Fix layouts in RTL mode (Right to left).
Apr 25 2019, 9:40 AM · Elisa
mgallien created T10847: Fix genre, composer and lyricist database insertion.
Apr 25 2019, 9:32 AM · Elisa

Apr 24 2019

mgallien added a comment to T10835: Create CI Jobs for stable branch of Elisa.

@bcooksley thanks for your help

Apr 24 2019, 8:52 AM · Elisa, build.kde.org
bcooksley added a comment to T10835: Create CI Jobs for stable branch of Elisa.

First jobs started - https://build.kde.org/job/Extragear/job/elisa/

Apr 24 2019, 8:36 AM · Elisa, build.kde.org
mgallien added a comment to T10835: Create CI Jobs for stable branch of Elisa.

Thanks for the information.
I have added a stable branch.
Could you please run the DSL Job Seed job?

Apr 24 2019, 8:28 AM · Elisa, build.kde.org
bcooksley closed T10835: Create CI Jobs for stable branch of Elisa as Resolved.

The lack of stable builds for Elisa is due to a lack of stable branch definitions in logical-module-structure in the kde-build-metadata repository.
(See the existing Elisa section)

Apr 24 2019, 8:03 AM · Elisa, build.kde.org

Apr 23 2019

mgallien created T10835: Create CI Jobs for stable branch of Elisa.
Apr 23 2019, 10:05 PM · Elisa, build.kde.org

Apr 22 2019

James added a watcher for Elisa: James.
Apr 22 2019, 2:36 PM

Apr 18 2019

mgallien closed T5376: Allow to undo the clear actions on the playlist as Resolved.
Apr 18 2019, 3:28 PM · Elisa

Apr 17 2019

mgallien updated subscribers of T10800: Send CI build mails of Elisa to the Elisa mailing list.

Thanks @bcooksley for your help.

Apr 17 2019, 3:34 PM · Elisa, build.kde.org

Apr 16 2019

jguidon moved T5376: Allow to undo the clear actions on the playlist from In Progress to Done on the Elisa board.
Apr 16 2019, 3:22 PM · Elisa
bcooksley closed T10800: Send CI build mails of Elisa to the Elisa mailing list as Resolved by committing R857:0edf2168b41c: Enable CI notifications for Elisa..
Apr 16 2019, 10:14 AM · Elisa, build.kde.org
mgallien renamed T10800: Send CI build mails of Elisa to the Elisa mailing list from Send BI build mails of Elisa to the Elisa mailing list to Send CI build mails of Elisa to the Elisa mailing list.
Apr 16 2019, 8:20 AM · Elisa, build.kde.org

Apr 15 2019

mgallien created T10800: Send CI build mails of Elisa to the Elisa mailing list.
Apr 15 2019, 5:19 PM · Elisa, build.kde.org
mgallien closed T10330: Implement new context view from mockup as Resolved.
Apr 15 2019, 5:51 AM · Elisa
mgallien closed T10360: Implement Power Management Sleep Inhibition while Playing Music as Resolved.
Apr 15 2019, 5:51 AM · Elisa
mgallien moved T10360: Implement Power Management Sleep Inhibition while Playing Music from In Progress to Done on the Elisa board.
Apr 15 2019, 5:51 AM · Elisa
mgallien moved T10330: Implement new context view from mockup from In Progress to Done on the Elisa board.
Apr 15 2019, 5:51 AM · Elisa
mgallien closed D18351: Prevent the host computer to sleep while playing music.
Apr 15 2019, 5:46 AM · Elisa
mgallien updated the diff for D18351: Prevent the host computer to sleep while playing music.
  • implement more methods to inhibit sleep (support Gnome and Logind)
  • prevent sleep again on Plasma workspace
  • remove the calls to logind inhibit interface: does nothing right now
Apr 15 2019, 5:36 AM · Elisa

Apr 13 2019

mgallien added a comment to T7567: Add support for radio streams.

Hello,

Hi,

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

I am motivated to take a look.

Apr 13 2019, 8:12 PM · Elisa

Apr 12 2019

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Hi,

I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.

Apr 12 2019, 9:09 PM · Elisa
mgallien closed D19610: Allow to undo the clear actions on the playlist.
Apr 12 2019, 9:03 PM · Elisa
jguidon added a comment to T7567: Add support for radio streams.

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

Apr 12 2019, 9:16 AM · Elisa
jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.

Apr 12 2019, 8:59 AM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.
  • Fixed some typo and removed empty lines
Apr 12 2019, 8:27 AM · Elisa
asn added a comment to T7567: Add support for radio streams.

With libvlc playing an audio stream should be fairly easy to achieve. The URL just needs to be passed in the right form. So all we need is a way to add a stream to the playlist.

Apr 12 2019, 7:09 AM · Elisa
mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

@jguidon I hope everything is fine for you. It would really great to have your contribution land in master branch. This is a really nice improvement.
It seems you are not yet a KDE contributor. I should land your branch but there is very small issues to fix. Do you want me to finish the work or are you able to do it ?

Apr 12 2019, 5:16 AM · Elisa

Apr 9 2019

mgallien added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin

Apr 9 2019, 8:20 AM · Elisa

Apr 7 2019

astippich added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin

Apr 7 2019, 4:16 PM · Elisa

Apr 4 2019

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Ping

Apr 4 2019, 8:02 PM · Elisa

Apr 3 2019

mgallien closed T9082: Add filtering by path in the Baloo support as Resolved.
Apr 3 2019, 8:24 PM · Elisa
mgallien moved T9082: Add filtering by path in the Baloo support from In Progress to Done on the Elisa board.
Apr 3 2019, 8:24 PM · Elisa

Mar 27 2019

mgallien accepted D19610: Allow to undo the clear actions on the playlist.

Thanks for your work.
Please fix the small issues.
Do you have a contributor account or do you need somebody to land your patch ?

Mar 27 2019, 6:31 AM · Elisa

Mar 26 2019

jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Thanks a lot for your feedback

Mar 26 2019, 11:18 AM · Elisa

Mar 25 2019

mgallien updated the diff for D18351: Prevent the host computer to sleep while playing music.
  • implement more methods to inhibit sleep (support Gnome and Logind)
Mar 25 2019, 9:14 PM · Elisa
mgallien closed D19650: Simplify and improve music indexers management.
Mar 25 2019, 8:50 PM · Elisa
mgallien added a comment to D14018: Make labels in header bar clickeable.

@mgallien Hey, sure! Thanks for finishing it

Mar 25 2019, 8:25 PM · Elisa
mgallien closed D14018: Make labels in header bar clickeable.
Mar 25 2019, 6:05 AM · Elisa

Mar 24 2019

januz added a comment to D14018: Make labels in header bar clickeable.

@mgallien Hey, sure! Thanks for finishing it

Mar 24 2019, 9:47 PM · Elisa
mgallien retitled D14018: Make labels in header bar clickeable from [WIP] Make labels in header bar clickeable to Make labels in header bar clickeable.
Mar 24 2019, 1:50 PM · Elisa
mgallien accepted D14018: Make labels in header bar clickeable.

@januz are you OK with me landing your patch ?

Mar 24 2019, 1:50 PM · Elisa
mgallien updated the diff for D14018: Make labels in header bar clickeable.
  • do not expand labels in header bar but let them grow with the text
Mar 24 2019, 1:49 PM · Elisa
mgallien updated the diff for D14018: Make labels in header bar clickeable.
  • use current API to switch views
Mar 24 2019, 1:41 PM · Elisa

Mar 22 2019

mgallien updated the diff for D19650: Simplify and improve music indexers management.
  • fix music import notification not showing up during initial indexing
  • use categorized logging in DatabaseInterface
  • store some metadata only if they are really defined
  • only really return data on tracks if they are not null in database
  • do not store invalid data from tracks into database
  • add categorized logging for vlc player code
  • scan newly discovered files from baloo only with audio mime type
  • add more logs in Baloo to understand what happens during indexing
  • only use categorized logging to indicate error cases
  • add bad performance detection for all Sql queries in debug builds
  • add some known index to Tracks table
  • really only fetch track ids and optimize modified albums handling
  • convert some remaining debug logs to categorized ones
  • revert modifications for modified tracks from modified albums
Mar 22 2019, 5:51 PM · Elisa

Mar 21 2019

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Nice work.

Mar 21 2019, 8:08 PM · Elisa

Mar 20 2019

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Thanks for your work. I will try to provide feedback as soon as I can. Sorry for the delay.

Mar 20 2019, 9:50 PM · Elisa
mgallien updated the diff for D19650: Simplify and improve music indexers management.
  • fix music import notification not showing up during initial indexing
  • fix compilation of some tests after rebase on master
Mar 20 2019, 6:33 AM · Elisa

Mar 18 2019

amang removed a watcher for Elisa: amang.
Mar 18 2019, 7:02 PM
amang added a watcher for Elisa: amang.
Mar 18 2019, 7:02 PM

Mar 14 2019

jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Fixed use of the closeButton of Kirigami.InlineMessage with Connections in qml. I asked to Marco Martin and I thank him for his help.

Mar 14 2019, 11:23 AM · Elisa

Mar 13 2019

ngraham added a comment to D19610: Allow to undo the clear actions on the playlist.

Thank you for your feedback !

Here is a new capture :

I used another action button because the integrated closeButton of the Inline Message had a strange behavior.

Mar 13 2019, 3:05 PM · Elisa

Mar 12 2019

carneirogustavo added a comment to T7674: Add previous and next track indicator in the top bar.

Hi, I would like to participate in this task, what is necessary? Could you give me an explanation?

Mar 12 2019, 11:00 PM · Elisa
jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Thank you for your feedback !

Mar 12 2019, 9:27 PM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.
  • For Inline Message, use of Kirigami.Action's button instead of InlineMessage closeButton
Mar 12 2019, 9:22 PM · Elisa
mgallien updated the diff for D19650: Simplify and improve music indexers management.
  • fix music import notification not showing up during initial indexing
Mar 12 2019, 4:32 PM · Elisa
carneirogustavo added a watcher for Elisa: carneirogustavo.
Mar 12 2019, 5:55 AM

Mar 10 2019

mgallien requested changes to D19610: Allow to undo the clear actions on the playlist.

Thanks for your work, I have been able to successfully test it.

Mar 10 2019, 8:56 PM · Elisa
mgallien updated the diff for D19650: Simplify and improve music indexers management.

rebase on top of master

Mar 10 2019, 10:06 AM · Elisa
mgallien updated the diff for D19650: Simplify and improve music indexers management.

rebase on top of master

Mar 10 2019, 9:50 AM · Elisa
mgallien added a project to D19650: Simplify and improve music indexers management: Elisa.
Mar 10 2019, 9:42 AM · Elisa

Mar 9 2019

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Here is one screenshot with the inline message :

Mar 9 2019, 6:08 PM · Elisa
ngraham added a comment to D19610: Allow to undo the clear actions on the playlist.

Thanks!

Mar 9 2019, 4:14 PM · Elisa
jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Here is one screenshot with the inline message :

Mar 9 2019, 10:39 AM · Elisa
jguidon updated the diff for D19610: Allow to undo the clear actions on the playlist.

Use Kirigami InlineMessage instead of the system notification

Mar 9 2019, 10:35 AM · Elisa

Mar 8 2019

jguidon added a comment to D19610: Allow to undo the clear actions on the playlist.

Thanks, I can take a look at the Kirigami InlineMessage.

Mar 8 2019, 5:32 PM · Elisa
ngraham added a comment to D19610: Allow to undo the clear actions on the playlist.

Instead of using a system notification, I would recommend showing a Kirigami InlineMessage at the bottom of the playlist pane with an Undo button in it.

Mar 8 2019, 5:08 PM · Elisa
mgallien added a project to D19610: Allow to undo the clear actions on the playlist: Elisa.
Mar 8 2019, 2:39 PM · Elisa
jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Thank you for your replies, I could push a diff: https://phabricator.kde.org/D19610 . I tried to follow the instructions as much as possible :)

Mar 8 2019, 2:22 PM · Elisa
jguidon added a revision to T5376: Allow to undo the clear actions on the playlist: D19610: Allow to undo the clear actions on the playlist.
Mar 8 2019, 2:09 PM · Elisa

Mar 1 2019

mgallien claimed T9082: Add filtering by path in the Baloo support.
Mar 1 2019, 6:50 PM · Elisa
astippich updated the task description for T8196: KFileMetadata: String lists. How do clients cope?.
Mar 1 2019, 11:40 AM · Dolphin, Elisa, Frameworks, Baloo

Feb 28 2019

mgallien added a comment to T5376: Allow to undo the clear actions on the playlist.

Sorry to have missed your first questions.

Feb 28 2019, 8:56 PM · Elisa
mgallien added a comment to T5376: Allow to undo the clear actions on the playlist.

Sorry, I had missed your questions,

Feb 28 2019, 8:52 PM · Elisa

Feb 27 2019

jguidon moved T5376: Allow to undo the clear actions on the playlist from Backlog to In Progress on the Elisa board.
Feb 27 2019, 3:39 PM · Elisa

Feb 26 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Finally, I could use KNotification to generate on the clear action a system notification with an undo choice (the file elisa.notifyrc may be particular for the packaging, KNotificationGlobalConfigFile).

Feb 26 2019, 7:00 PM · Elisa

Feb 22 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

Thank you, I have indeed a few questions after a first look at the code :

Feb 22 2019, 11:21 PM · Elisa

Feb 20 2019

jguidon claimed T5376: Allow to undo the clear actions on the playlist.
Feb 20 2019, 9:20 PM · Elisa
mgallien added a comment to T5376: Allow to undo the clear actions on the playlist.

Hi !

Feb 20 2019, 9:06 PM · Elisa

Feb 18 2019

jguidon added a comment to T5376: Allow to undo the clear actions on the playlist.

I am new here and I am very motivated to invest !

Feb 18 2019, 4:26 PM · Elisa

Feb 15 2019

jguidon added a watcher for Elisa: jguidon.
Feb 15 2019, 2:18 PM
jguidon removed a member for Elisa: jguidon.
Feb 15 2019, 2:18 PM
jguidon added a member for Elisa: jguidon.
Feb 15 2019, 2:18 PM

Feb 3 2019

mgallien added a revision to T10330: Implement new context view from mockup: D18679: Implement new context view with metadata.
Feb 3 2019, 5:08 PM · Elisa

Feb 2 2019

ctakano added a watcher for Elisa: ctakano.
Feb 2 2019, 6:14 AM

Jan 31 2019

Tizon added a watcher for Elisa: Tizon.
Jan 31 2019, 6:21 AM

Jan 21 2019

matheswaranshanmugam added a comment to T9069: Allow more flexibility in the application layout.

Thank you sir.
I will do it and i need some more information
and I'm new to this so it will be better if i get some guidance.

Jan 21 2019, 12:32 PM · Elisa