what do you think about using make -j$(nproc) instead of just make this way all the available cores are used for compiling.
This is just a little trick I sometimes forget to change when I follow build instructions.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Sounds good to me, no errors found

Note: There are related changes in https://phabricator.kde.org/D27446

Thanks, Yuri and Davide!

Closed by commit https://cgit.kde.org/krusader.git/commit/?id=419ac6ec839414bbae52849af536bc8ba1da83e4

Thanks, Yuri and Davide!

Thanks, Yuri, Antonio and Davide!

Compiled and tested on QT 5.14.1, QT 5.9.5 (Ubuntu 18.04) and QT 5.12.4 (Ubuntu 19.10); all fine

All good, thanks.

Fine

No objections if it works.

All tests fine.

Tested to work as expected.

Tested to work as expected.

In D26334#601440, @abika wrote:

Although the current fix works for me, i propose to change the added line into

panel->view->setNameToMakeCurrent(nameToMakeCurrent);

Thanks.

Closing it manually because it wasn't closed automatically when performing the commit.

This modification and the related one (https://phabricator.kde.org/D23309) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

This modification and the related one (https://phabricator.kde.org/D24480) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

The new version of the proposal keeps being acceptable, of course :-)

So we have to consider that CTRL+UP/DOWN cannot be used anymore as before and users may complain about it. However, this did
also not work for the embedded terminal (see bug report) and for the sidebar before this patch.

Previously, syncList->setFocus(); was utilized as it was used in three other places in the same file, although with btnCompareDirs->setFocus(); the intentions becomes clearer. Thanks, Alex! (and Yuri :-)

Good improvement in my opinion!
My test results:

• The CTRL+SHIFT+UP/DOWN shortcuts work perfectly. Only when unfocusing the navigation bar a second time, the edit mode stays on. It might be a widget problem, but i consider it minor and it happened also before this patch.
• Then i set CTRL+UP/DOWN as alternative shortcuts for the same actions to see if this can be used for backwards compatibility: This does not work when trying to unfocusing the navigation bar, the embedded terminal or the command line. All these widgets are capturing the key press and the shortcut action is not activated.

Thanks for the fix Davide! This was also annoying me a lot.

Thanks Toni. Works as expected.
But i still would recommend to either use btnCompareDirs->setFocus(); directly instead, or to add a short comment that syncList is focused to have the compare dirs button (which is set as default) being executed on pressing "Enter".
Otherwise it is a bit confusing why the empty tree widget is focused.

I removed the two added brackets again.

• fixup! Add Kompare as compare application with KIO support

[Got finally some time for Krusader again:)]

An address was changed, following what Yuri recently applied (e.g. it can be seen in "Fix links on docs.kde.org").

The changes suggested by Yuri Chornoivan were made, also the USB entity was defined.

This can be solved much more easily without breaking translations by adding entities into index.docbook header (~line 27):

Works as expected. Thanks.

Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!

The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+↑ and Ctrl+↓ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.

The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

That bug has been hindering Krusader users for too long, thanks Davide! :-)

Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3

have changed the comment

Changed comment

Updated docbook as stated by @yurchor.

It would be nice to move shortcuts in keyboard-commands.docbook (~line 947) from Ctrl to Ctrl-Shift section ( ~line 1218) or make those sections coherent with this patch.

This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!

Compiled and tested with no errors, thanks

Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).

In D24987#560752, @pino wrote:

I have no idea what "Boy Scout rule" is supposed to mean

Mostly OK from my POV, just please remove the unrelated changes to the patch (i.e. the brackets additions in two places).
I have no idea what "Boy Scout rule" is supposed to mean, however adding unrelated changes makes history reading harder, especially when wanting to check why certain changes were done. Again, material for a different patch than this.

• fixup! Add Kompare as compare application with KIO support

Tested to work as expected. Thanks for your work.

Hi Toni,

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);