Is the crashing AppImage available for download? I'd like to have a look at it.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jan 16 2019
Jan 1 2019
Dec 6 2018
Nov 30 2018
Closed manually after I landed the change manually as dffdf76750f74ad6e8741abe5ed4b7380f9b65e3
In case you don't have write access let me know.
Added your suggestions (and fixed the patch)
Nov 29 2018
Thanks for your suggestions! I hope, I included them correctly.
First time contributing to KDE after 21 years of using it ;-)
included Thomas' suggestions
In general a good idea and a cool addition to the application.
Nov 27 2018
Nov 25 2018
- use local path first in readme.cmake
- add note why not using ECM 5.38
Nov 24 2018
Nov 21 2018
Nov 16 2018
Just a hint: running kmymoney from build dir is useful inside an IDE like QtCreator
- fixed issues
- todo: creating symlink need to be checked on windows
Nov 15 2018
Nov 11 2018
In D14522#357923, @ostroffjh wrote:There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?
There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?
I rebased the patch to fit the latest master branch.
Please test and approve.
Oct 27 2018
Oct 26 2018
Oct 16 2018
Sep 22 2018
Sep 21 2018
Worked here on my openSUSE system.
Sep 19 2018
Sep 8 2018
Other than that it looks good to me.
Aug 26 2018
Looks good to me. We should give it a try and see how the nightly build performs.
Aug 19 2018
Changed source links to our own.
In D14926#311442, @tbaumgart wrote:Cool, I started out to read about appimage a few times myself but never got around to really work on it. I have not tried any of that yet, but it looks very promising. Can we have that for the upcoming 5.0.2 release?
Cool, I started out to read about appimage a few times myself but never got around to really work on it. I have not tried any of that yet, but it looks very promising. Can we have that for the upcoming 5.0.2 release?
Aug 13 2018
Incorporated changes according to the review.
In D14756#307613, @tbaumgart wrote:In general, the idea to change the storage of matching transactions is OK. It was more of a quick hack back then. But I think, we need to iron out a few things before we can add it to master. Maybe even postpone it after the next release, because it changes the file structure and is not backward compatible.
In general, the idea to change the storage of matching transactions is OK. It was more of a quick hack back then. But I think, we need to iron out a few things before we can add it to master. Maybe even postpone it after the next release, because it changes the file structure and is not backward compatible.
Aug 12 2018
Aug 5 2018
Looks OK to me. Could not really test it thouroughly, since I don't use the DB backend.
Aug 4 2018
Aug 3 2018
Works for me. Seems to be OK.
In D14522#302502, @tbaumgart wrote:In D14522#302220, @wojnilowicz wrote:In D14522#302070, @habacker wrote:Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.
Who's going to add new features?
That is Christian's point of view. I'm not going to sit and wait longer for a miracle to happen. Nobody develops alkimia and it's unhandy to fix compiler warnings with it being in a separate library.It is also my POV. Alkimia is stable and does its job. At this point, I don't care for compiler warnings. We certainly have more severe problems than compiler warnings which might have been introduced recently and exist more or less on Windows environments only. I don't want to jeopardize the current stability by changing one of the core elements of KMyMoney. That said, I am against this change to be applied to the current master or 5.0 branch at least until the next KMyMoney release.
Aug 2 2018
In D14522#302220, @wojnilowicz wrote:In D14522#302070, @habacker wrote:Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.
Who's going to add new features?
That is Christian's point of view. I'm not going to sit and wait longer for a miracle to happen. Nobody develops alkimia and it's unhandy to fix compiler warnings with it being in a separate library.
In D14522#302070, @habacker wrote:Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.
Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.
Aug 1 2018
I'm at least somewhat against this change. Maybe it's just wishful thinking, but if we improve Alkimia, maybe there will be other users. That becomes essentially impossible if the code is moved internal to KMM.
Jul 31 2018
Jul 30 2018
Jul 29 2018
Looks OK to me, though I cannot really test it other than looking at the written data.
Jul 28 2018
Jul 22 2018
Looks OK to me. I have checked that my datafile can be loaded and produced identical results as master after writing and reading back. This is the case and the tests work.
Jul 21 2018
Looks OK and if I apply the following patch it also compiles for me (the first hunk seems to be caused by trailing blanks) :
In D14257#295467, @tbaumgart wrote:Tested with my real file which contains 66 schedules. Produces the exact same output as master.
Tested with my real file which contains 66 schedules. Produces the exact same output as master.
In D14257#295447, @tbaumgart wrote:I am missing the removal of the old version in MyMoneySchedule::writeXML().
I am missing the removal of the old version in MyMoneySchedule::writeXML().
Jul 16 2018
Jul 15 2018
This package does not match my distro and I honestly don't want to install it. But since I can compile w/o this feature enabled, go ahead and add it.
Looks OK to me. Made some tests in comparing the output of the master version and this version which do not show differences.
I needed to apply the following patch to get correct results. Reason: you must not set the entry date of a scheduled transaction to a valid value, due to the fact that
I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.
Other than that it looks good to me.
Jul 14 2018
In D13817#291800, @tbaumgart wrote:Now it fails with
[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o /home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 'QtSql/private/qsqlcachedresult_p.h' file not found #include <QtSql/private/qsqlcachedresult_p.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).