Feed Advanced Search

Jan 16 2019

aacid closed D16433: Display name of equity with strikeout font if the equity account has been closed..
Jan 16 2019, 11:32 PM · KMyMoney

Jan 1 2019

habacker created T10244: Enable shortcuts for statement number assignments in scheduled transactions dialog.
Jan 1 2019, 11:17 AM · KMyMoney

Dec 6 2018

probono added a comment to D15343: Disable most features for AppImage.

Is the crashing AppImage available for download? I'd like to have a look at it.

Dec 6 2018, 7:03 PM · KMyMoney

Nov 30 2018

tbaumgart closed D17202: Kmymoney reporting graphs with expenses shown as negative.

Closed manually after I landed the change manually as dffdf76750f74ad6e8741abe5ed4b7380f9b65e3

Nov 30 2018, 9:52 PM · VDG, KMyMoney
tbaumgart reopened D17202: Kmymoney reporting graphs with expenses shown as negative.
Nov 30 2018, 9:05 PM · VDG, KMyMoney
michaelkiefer closed D17202: Kmymoney reporting graphs with expenses shown as negative.
Nov 30 2018, 8:10 PM · VDG, KMyMoney
tbaumgart accepted D17202: Kmymoney reporting graphs with expenses shown as negative.

In case you don't have write access let me know.

Nov 30 2018, 7:41 PM · VDG, KMyMoney
michaelkiefer updated the diff for D17202: Kmymoney reporting graphs with expenses shown as negative.

Added your suggestions (and fixed the patch)

Nov 30 2018, 7:26 PM · VDG, KMyMoney

Nov 29 2018

michaelkiefer added a comment to D17202: Kmymoney reporting graphs with expenses shown as negative.

Thanks for your suggestions! I hope, I included them correctly.
First time contributing to KDE after 21 years of using it ;-)

Nov 29 2018, 6:10 PM · VDG, KMyMoney
michaelkiefer updated the diff for D17202: Kmymoney reporting graphs with expenses shown as negative.

included Thomas' suggestions

Nov 29 2018, 6:06 PM · VDG, KMyMoney
tbaumgart added a comment to D17202: Kmymoney reporting graphs with expenses shown as negative.

In general a good idea and a cool addition to the application.

Nov 29 2018, 11:45 AM · VDG, KMyMoney

Nov 27 2018

michaelkiefer retitled D17202: Kmymoney reporting graphs with expenses shown as negative from Reporting graphs with expenses shown as negative to Kmymoney reporting graphs with expenses shown as negative.
Nov 27 2018, 10:40 PM · VDG, KMyMoney
michaelkiefer requested review of D17202: Kmymoney reporting graphs with expenses shown as negative.
Nov 27 2018, 10:38 PM · VDG, KMyMoney

Nov 25 2018

habacker updated the diff for D16764: Add support for running kmymoney from build dir.
  • use local path first in readme.cmake
  • add note why not using ECM 5.38
Nov 25 2018, 12:28 PM · KMyMoney

Nov 24 2018

tbaumgart added inline comments to D16764: Add support for running kmymoney from build dir.
Nov 24 2018, 9:38 AM · KMyMoney

Nov 21 2018

habacker added inline comments to D16764: Add support for running kmymoney from build dir.
Nov 21 2018, 4:43 PM · KMyMoney

Nov 16 2018

habacker added a comment to D16764: Add support for running kmymoney from build dir.

Just a hint: running kmymoney from build dir is useful inside an IDE like QtCreator

Nov 16 2018, 7:53 AM · KMyMoney
habacker updated the summary of D16764: Add support for running kmymoney from build dir.
Nov 16 2018, 7:47 AM · KMyMoney
habacker updated the diff for D16764: Add support for running kmymoney from build dir.
  • fixed issues
  • todo: creating symlink need to be checked on windows
Nov 16 2018, 7:28 AM · KMyMoney

Nov 15 2018

habacker added inline comments to D16764: Add support for running kmymoney from build dir.
Nov 15 2018, 10:19 PM · KMyMoney

Nov 11 2018

habacker added a reviewer for D14522: Integrate Alkimia: habacker.
Nov 11 2018, 7:43 PM · KMyMoney
wojnilowicz added a comment to D14522: Integrate Alkimia.

There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?

Nov 11 2018, 5:19 PM · KMyMoney
ostroffjh added a comment to D14522: Integrate Alkimia.

There are several people who are against this, and only one in favor. Would you please consider others' opinions, and defer this further, or put it in a separate branch?

Nov 11 2018, 5:17 PM · KMyMoney
wojnilowicz updated the diff for D14522: Integrate Alkimia.

I rebased the patch to fit the latest master branch.
Please test and approve.

Nov 11 2018, 9:49 AM · KMyMoney
wojnilowicz added inline comments to D16764: Add support for running kmymoney from build dir.
Nov 11 2018, 6:29 AM · KMyMoney
wojnilowicz added a project to D16764: Add support for running kmymoney from build dir: KMyMoney.
Nov 11 2018, 5:52 AM · KMyMoney

Oct 27 2018

tbaumgart accepted D16433: Display name of equity with strikeout font if the equity account has been closed..
Oct 27 2018, 8:30 AM · KMyMoney

Oct 26 2018

mhubner added a project to D16433: Display name of equity with strikeout font if the equity account has been closed.: KMyMoney.
Oct 26 2018, 2:12 AM · KMyMoney

Oct 16 2018

mhubner added a project to D16239: Allow for arbitrary documents to be stored with splits.: KMyMoney.
Oct 16 2018, 3:01 AM · KMyMoney

Sep 22 2018

wojnilowicz closed D15604: Adjust some standard paths for AppImage.
Sep 22 2018, 5:53 PM · KMyMoney

Sep 21 2018

tbaumgart accepted D15604: Adjust some standard paths for AppImage.

Worked here on my openSUSE system.

Sep 21 2018, 4:39 PM · KMyMoney

Sep 19 2018

wojnilowicz requested review of D15604: Adjust some standard paths for AppImage.
Sep 19 2018, 5:30 PM · KMyMoney

Sep 8 2018

wojnilowicz closed D15343: Disable most features for AppImage.
Sep 8 2018, 7:46 PM · KMyMoney
tbaumgart added a comment to D15343: Disable most features for AppImage.

Other than that it looks good to me.

Sep 8 2018, 9:41 AM · KMyMoney
wojnilowicz requested review of D15343: Disable most features for AppImage.
Sep 8 2018, 5:34 AM · KMyMoney

Aug 26 2018

wojnilowicz closed D15087: Don't hardcode custom icons location.
Aug 26 2018, 10:31 AM · KMyMoney
tbaumgart accepted D15087: Don't hardcode custom icons location.

Looks good to me. We should give it a try and see how the nightly build performs.

Aug 26 2018, 9:58 AM · KMyMoney
wojnilowicz requested review of D15087: Don't hardcode custom icons location.
Aug 26 2018, 7:54 AM · KMyMoney

Aug 19 2018

wojnilowicz closed D14926: Add AppImage build scripts.
Aug 19 2018, 1:37 PM · KMyMoney
wojnilowicz updated the diff for D14926: Add AppImage build scripts.

Changed source links to our own.

Aug 19 2018, 1:10 PM · KMyMoney
wojnilowicz added a comment to D14926: Add AppImage build scripts.

Cool, I started out to read about appimage a few times myself but never got around to really work on it. I have not tried any of that yet, but it looks very promising. Can we have that for the upcoming 5.0.2 release?

Aug 19 2018, 1:09 PM · KMyMoney
tbaumgart requested changes to D14926: Add AppImage build scripts.

Cool, I started out to read about appimage a few times myself but never got around to really work on it. I have not tried any of that yet, but it looks very promising. Can we have that for the upcoming 5.0.2 release?

Aug 19 2018, 1:00 PM · KMyMoney
wojnilowicz requested review of D14926: Add AppImage build scripts.
Aug 19 2018, 7:16 AM · KMyMoney

Aug 13 2018

wojnilowicz added inline comments to D14756: Match transactions differently.
Aug 13 2018, 4:41 PM · KMyMoney
wojnilowicz updated the diff for D14756: Match transactions differently.

Incorporated changes according to the review.

Aug 13 2018, 4:37 PM · KMyMoney
wojnilowicz added a comment to D14756: Match transactions differently.

In general, the idea to change the storage of matching transactions is OK. It was more of a quick hack back then. But I think, we need to iron out a few things before we can add it to master. Maybe even postpone it after the next release, because it changes the file structure and is not backward compatible.

Aug 13 2018, 2:57 PM · KMyMoney
tbaumgart requested changes to D14756: Match transactions differently.

In general, the idea to change the storage of matching transactions is OK. It was more of a quick hack back then. But I think, we need to iron out a few things before we can add it to master. Maybe even postpone it after the next release, because it changes the file structure and is not backward compatible.

Aug 13 2018, 10:42 AM · KMyMoney

Aug 12 2018

wojnilowicz requested review of D14756: Match transactions differently.
Aug 12 2018, 6:46 AM · KMyMoney

Aug 5 2018

wojnilowicz closed D14564: Depluginize SQL storage helpers.
Aug 5 2018, 7:07 PM · KMyMoney
tbaumgart accepted D14564: Depluginize SQL storage helpers.

Looks OK to me. Could not really test it thouroughly, since I don't use the DB backend.

Aug 5 2018, 8:06 AM · KMyMoney

Aug 4 2018

wojnilowicz updated the diff for D14564: Depluginize SQL storage helpers.
Aug 4 2018, 5:47 AM · KMyMoney
wojnilowicz closed D14540: Move payee identifier widgets to kmm_widgets.
Aug 4 2018, 5:14 AM · KMyMoney

Aug 3 2018

tbaumgart accepted D14540: Move payee identifier widgets to kmm_widgets.

Works for me. Seems to be OK.

Aug 3 2018, 7:35 PM · KMyMoney
wojnilowicz updated the diff for D14540: Move payee identifier widgets to kmm_widgets.
Aug 3 2018, 2:11 PM · KMyMoney
wojnilowicz added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Who's going to add new features?
That is Christian's point of view. I'm not going to sit and wait longer for a miracle to happen. Nobody develops alkimia and it's unhandy to fix compiler warnings with it being in a separate library.

It is also my POV. Alkimia is stable and does its job. At this point, I don't care for compiler warnings. We certainly have more severe problems than compiler warnings which might have been introduced recently and exist more or less on Windows environments only. I don't want to jeopardize the current stability by changing one of the core elements of KMyMoney. That said, I am against this change to be applied to the current master or 5.0 branch at least until the next KMyMoney release.

Aug 3 2018, 1:23 PM · KMyMoney

Aug 2 2018

tbaumgart added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Who's going to add new features?
That is Christian's point of view. I'm not going to sit and wait longer for a miracle to happen. Nobody develops alkimia and it's unhandy to fix compiler warnings with it being in a separate library.

Aug 2 2018, 7:34 PM · KMyMoney
wojnilowicz requested review of D14564: Depluginize SQL storage helpers.
Aug 2 2018, 5:27 PM · KMyMoney
wojnilowicz added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Aug 2 2018, 12:49 PM · KMyMoney
habacker added a comment to D14522: Integrate Alkimia.

Christian David mentioned at https://mail.kde.org/pipermail/kmymoney-devel/2018-May/020846.html to wait until 23rd of October 2018 before merging alkimia in case no feature has been added.

Aug 2 2018, 9:03 AM · KMyMoney

Aug 1 2018

wojnilowicz requested review of D14540: Move payee identifier widgets to kmm_widgets.
Aug 1 2018, 5:27 PM · KMyMoney
ostroffjh added a comment to D14522: Integrate Alkimia.

I'm at least somewhat against this change. Maybe it's just wishful thinking, but if we improve Alkimia, maybe there will be other users. That becomes essentially impossible if the code is moved internal to KMM.

Aug 1 2018, 4:30 PM · KMyMoney

Jul 31 2018

wojnilowicz requested review of D14522: Integrate Alkimia.
Jul 31 2018, 6:10 PM · KMyMoney

Jul 30 2018

wojnilowicz requested review of D14494: Move online task reading and writing to XML storage.
Jul 30 2018, 5:42 PM · KMyMoney

Jul 29 2018

wojnilowicz closed D14462: Move payee identifier reading and writing to XML storage.
Jul 29 2018, 5:14 PM · KMyMoney
tbaumgart accepted D14462: Move payee identifier reading and writing to XML storage.

Looks OK to me, though I cannot really test it other than looking at the written data.

Jul 29 2018, 4:34 PM · KMyMoney
wojnilowicz requested review of D14462: Move payee identifier reading and writing to XML storage.
Jul 29 2018, 3:42 PM · KMyMoney

Jul 28 2018

tbaumgart closed T9254: Cleanup usage of lastStatementDate in account KVP as Resolved by committing R261:5e7813dba660: Remove the usage of lastStatementDate in account KVP.
Jul 28 2018, 6:08 PM · KMyMoney
tbaumgart added a revision to T9254: Cleanup usage of lastStatementDate in account KVP: D14441: Remove the usage of lastStatementDate in account KVP.
Jul 28 2018, 2:52 PM · KMyMoney
tbaumgart claimed T9254: Cleanup usage of lastStatementDate in account KVP.
Jul 28 2018, 2:11 PM · KMyMoney
tbaumgart moved T9254: Cleanup usage of lastStatementDate in account KVP from Backlog to In progress on the KMyMoney board.
Jul 28 2018, 2:10 PM · KMyMoney

Jul 22 2018

tbaumgart triaged T9254: Cleanup usage of lastStatementDate in account KVP as Normal priority.
Jul 22 2018, 6:05 PM · KMyMoney
wojnilowicz closed D14271: Create XML storage helper.
Jul 22 2018, 4:05 PM · KMyMoney
tbaumgart accepted D14271: Create XML storage helper.

Looks OK to me. I have checked that my datafile can be loaded and produced identical results as master after writing and reading back. This is the case and the tests work.

Jul 22 2018, 3:02 PM · KMyMoney
wojnilowicz requested review of D14271: Create XML storage helper.
Jul 22 2018, 11:31 AM · KMyMoney

Jul 21 2018

joshuac added a member for KMyMoney: joshuac.
Jul 21 2018, 8:42 PM
wojnilowicz closed D14261: Move more writing mehods to XML storage.
Jul 21 2018, 7:01 PM · KMyMoney
tbaumgart requested changes to D14261: Move more writing mehods to XML storage.

Looks OK and if I apply the following patch it also compiles for me (the first hunk seems to be caused by trailing blanks) :

Jul 21 2018, 1:48 PM · KMyMoney
wojnilowicz added a comment to D14257: Move MyMoneySchedule writing to XML storage.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Jul 21 2018, 11:11 AM · KMyMoney
wojnilowicz requested review of D14261: Move more writing mehods to XML storage.
Jul 21 2018, 11:09 AM · KMyMoney
wojnilowicz closed D14257: Move MyMoneySchedule writing to XML storage.
Jul 21 2018, 9:31 AM · KMyMoney
tbaumgart accepted D14257: Move MyMoneySchedule writing to XML storage.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Jul 21 2018, 8:17 AM · KMyMoney
wojnilowicz added a comment to D14257: Move MyMoneySchedule writing to XML storage.

I am missing the removal of the old version in MyMoneySchedule::writeXML().

Jul 21 2018, 7:06 AM · KMyMoney
tbaumgart added a comment to D14257: Move MyMoneySchedule writing to XML storage.

I am missing the removal of the old version in MyMoneySchedule::writeXML().

Jul 21 2018, 6:04 AM · KMyMoney
wojnilowicz requested review of D14257: Move MyMoneySchedule writing to XML storage.
Jul 21 2018, 5:11 AM · KMyMoney

Jul 16 2018

wojnilowicz closed D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 16 2018, 4:33 PM · KMyMoney
wojnilowicz closed D13817: Allow storing SQLite through SQLCipher.
Jul 16 2018, 4:33 PM · KMyMoney

Jul 15 2018

tbaumgart accepted D13817: Allow storing SQLite through SQLCipher.

This package does not match my distro and I honestly don't want to install it. But since I can compile w/o this feature enabled, go ahead and add it.

Jul 15 2018, 5:00 PM · KMyMoney
tbaumgart accepted D14125: Move MyMoneySplit reading and writing to XML storage.

Looks OK to me. Made some tests in comparing the output of the master version and this version which do not show differences.

Jul 15 2018, 4:18 PM · KMyMoney
wojnilowicz requested review of D13817: Allow storing SQLite through SQLCipher.
Jul 15 2018, 2:33 PM · KMyMoney
wojnilowicz added inline comments to D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 2:31 PM · KMyMoney
wojnilowicz updated the diff for D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 2:30 PM · KMyMoney
tbaumgart requested changes to D14125: Move MyMoneySplit reading and writing to XML storage.

I needed to apply the following patch to get correct results. Reason: you must not set the entry date of a scheduled transaction to a valid value, due to the fact that

Jul 15 2018, 2:21 PM · KMyMoney
wojnilowicz added a comment to D14115: Add test utilities.

I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.

Jul 15 2018, 9:19 AM · KMyMoney
wojnilowicz closed D14115: Add test utilities.
Jul 15 2018, 9:19 AM · KMyMoney
wojnilowicz requested review of D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 9:10 AM · KMyMoney
tbaumgart requested changes to D14115: Add test utilities.

Other than that it looks good to me.

Jul 15 2018, 7:04 AM · KMyMoney

Jul 14 2018

wojnilowicz requested review of D14115: Add test utilities.
Jul 14 2018, 6:25 PM · KMyMoney
wojnilowicz closed D13465: Fix xml file saving on Windows.
Jul 14 2018, 12:01 PM · KMyMoney
wojnilowicz closed D13831: Move XML read methods to storage plugin.
Jul 14 2018, 12:00 PM · KMyMoney
wojnilowicz added a comment to D13817: Allow storing SQLite through SQLCipher.

Now it fails with

[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o
/home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 
      'QtSql/private/qsqlcachedresult_p.h' file not found
#include <QtSql/private/qsqlcachedresult_p.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).

Jul 14 2018, 10:17 AM · KMyMoney