Feed Advanced Search

Jul 21 2018

joshuac added a member for KMyMoney: joshuac.
Jul 21 2018, 8:42 PM
wojnilowicz closed D14261: Move more writing mehods to XML storage.
Jul 21 2018, 7:01 PM · KMyMoney
tbaumgart requested changes to D14261: Move more writing mehods to XML storage.

Looks OK and if I apply the following patch it also compiles for me (the first hunk seems to be caused by trailing blanks) :

Jul 21 2018, 1:48 PM · KMyMoney
wojnilowicz added a comment to D14257: Move MyMoneySchedule writing to XML storage.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Jul 21 2018, 11:11 AM · KMyMoney
wojnilowicz requested review of D14261: Move more writing mehods to XML storage.
Jul 21 2018, 11:09 AM · KMyMoney
wojnilowicz closed D14257: Move MyMoneySchedule writing to XML storage.
Jul 21 2018, 9:31 AM · KMyMoney
tbaumgart accepted D14257: Move MyMoneySchedule writing to XML storage.

Tested with my real file which contains 66 schedules. Produces the exact same output as master.

Jul 21 2018, 8:17 AM · KMyMoney
wojnilowicz added a comment to D14257: Move MyMoneySchedule writing to XML storage.

I am missing the removal of the old version in MyMoneySchedule::writeXML().

Jul 21 2018, 7:06 AM · KMyMoney
tbaumgart added a comment to D14257: Move MyMoneySchedule writing to XML storage.

I am missing the removal of the old version in MyMoneySchedule::writeXML().

Jul 21 2018, 6:04 AM · KMyMoney
wojnilowicz requested review of D14257: Move MyMoneySchedule writing to XML storage.
Jul 21 2018, 5:11 AM · KMyMoney

Jul 16 2018

wojnilowicz closed D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 16 2018, 4:33 PM · KMyMoney
wojnilowicz closed D13817: Allow storing SQLite through SQLCipher.
Jul 16 2018, 4:33 PM · KMyMoney

Jul 15 2018

tbaumgart accepted D13817: Allow storing SQLite through SQLCipher.

This package does not match my distro and I honestly don't want to install it. But since I can compile w/o this feature enabled, go ahead and add it.

Jul 15 2018, 5:00 PM · KMyMoney
tbaumgart accepted D14125: Move MyMoneySplit reading and writing to XML storage.

Looks OK to me. Made some tests in comparing the output of the master version and this version which do not show differences.

Jul 15 2018, 4:18 PM · KMyMoney
wojnilowicz requested review of D13817: Allow storing SQLite through SQLCipher.
Jul 15 2018, 2:33 PM · KMyMoney
wojnilowicz added inline comments to D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 2:31 PM · KMyMoney
wojnilowicz updated the diff for D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 2:30 PM · KMyMoney
tbaumgart requested changes to D14125: Move MyMoneySplit reading and writing to XML storage.

I needed to apply the following patch to get correct results. Reason: you must not set the entry date of a scheduled transaction to a valid value, due to the fact that

Jul 15 2018, 2:21 PM · KMyMoney
wojnilowicz added a comment to D14115: Add test utilities.

I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.

Jul 15 2018, 9:19 AM · KMyMoney
wojnilowicz closed D14115: Add test utilities.
Jul 15 2018, 9:19 AM · KMyMoney
wojnilowicz requested review of D14125: Move MyMoneySplit reading and writing to XML storage.
Jul 15 2018, 9:10 AM · KMyMoney
tbaumgart requested changes to D14115: Add test utilities.

Other than that it looks good to me.

Jul 15 2018, 7:04 AM · KMyMoney

Jul 14 2018

wojnilowicz requested review of D14115: Add test utilities.
Jul 14 2018, 6:25 PM · KMyMoney
wojnilowicz closed D13465: Fix xml file saving on Windows.
Jul 14 2018, 12:01 PM · KMyMoney
wojnilowicz closed D13831: Move XML read methods to storage plugin.
Jul 14 2018, 12:00 PM · KMyMoney
wojnilowicz added a comment to D13817: Allow storing SQLite through SQLCipher.

Now it fails with

[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o
/home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 
      'QtSql/private/qsqlcachedresult_p.h' file not found
#include <QtSql/private/qsqlcachedresult_p.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).

Jul 14 2018, 10:17 AM · KMyMoney
tbaumgart requested changes to D13817: Allow storing SQLite through SQLCipher.
Jul 14 2018, 10:01 AM · KMyMoney
tbaumgart added a comment to D13817: Allow storing SQLite through SQLCipher.

Now it fails with

[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o
/home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 
      'QtSql/private/qsqlcachedresult_p.h' file not found
#include <QtSql/private/qsqlcachedresult_p.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).

Jul 14 2018, 10:01 AM · KMyMoney
tbaumgart accepted D13831: Move XML read methods to storage plugin.

Yes it does.

Jul 14 2018, 7:29 AM · KMyMoney

Jul 13 2018

wojnilowicz updated the diff for D13831: Move XML read methods to storage plugin.

Does this make any difference?

Jul 13 2018, 4:46 PM · KMyMoney
wojnilowicz added a comment to D13817: Allow storing SQLite through SQLCipher.

On my system Qt5::SqlPrivate is defined in Qt5SqlConfig.cmake which is installed by qt5-qtbase-devel. If you won't manage to get Qt5::SqlPrivate on your system, then we'll use less elegant way.

Jul 13 2018, 4:44 PM · KMyMoney
wojnilowicz updated the diff for D13817: Allow storing SQLite through SQLCipher.

Tried to fix sqlcipher.json issue.

Jul 13 2018, 4:41 PM · KMyMoney

Jul 12 2018

tbaumgart requested changes to D13817: Allow storing SQLite through SQLCipher.

After installing the necessary sqlcipher packages, I get the option to be found and turned on, but cmake produces the following output

Jul 12 2018, 2:40 PM · KMyMoney
tbaumgart added a comment to D13831: Move XML read methods to storage plugin.

I used File/Dump memory with master and D13831 and here is the difference after loading the file


Since the provider is empty because it is missing in version D13831, the return value of MyMoneyAccount::hasOnlineMapping() in KMyMoneyApp::Private::canUpdateAllAccounts() returns false for all accounts, the return value of canUpdateAllAccounts() is also false.

Jul 12 2018, 2:24 PM · KMyMoney
wojnilowicz added a comment to D13817: Allow storing SQLite through SQLCipher.

The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?

Jul 12 2018, 1:47 PM · KMyMoney
wojnilowicz added a comment to D13831: Move XML read methods to storage plugin.

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.

Ah, that could well be, since it relies on the QMetaObject stuff.

In case I load a file with this patch, the Update all accounts button is grayed out. This works OK on master with the same file. Can you please check all actions once you have fixed this?

Jul 12 2018, 1:43 PM · KMyMoney

Jul 11 2018

tbaumgart added a comment to D13817: Allow storing SQLite through SQLCipher.

The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?

Jul 11 2018, 3:36 PM · KMyMoney
tbaumgart requested changes to D13831: Move XML read methods to storage plugin.

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.

Jul 11 2018, 3:29 PM · KMyMoney
wojnilowicz updated the diff for D13817: Allow storing SQLite through SQLCipher.
Jul 11 2018, 1:55 PM · KMyMoney
wojnilowicz added a comment to D13831: Move XML read methods to storage plugin.

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

Jul 11 2018, 1:55 PM · KMyMoney
wojnilowicz updated the diff for D13831: Move XML read methods to storage plugin.
Jul 11 2018, 1:54 PM · KMyMoney

Jul 10 2018

tbaumgart requested changes to D13817: Allow storing SQLite through SQLCipher.

Cannot build w/o sqlcipher being installed. Sqlcipher must be optional not mandatory.

Jul 10 2018, 6:25 PM · KMyMoney
tbaumgart requested changes to D13831: Move XML read methods to storage plugin.

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

Jul 10 2018, 6:18 PM · KMyMoney

Jul 9 2018

wojnilowicz closed D13687: Move reports drawing to reports view plugin.
Jul 9 2018, 2:33 PM · KMyMoney

Jul 8 2018

tbaumgart accepted D13687: Move reports drawing to reports view plugin.
Jul 8 2018, 8:25 PM · KMyMoney
wojnilowicz updated the diff for D13687: Move reports drawing to reports view plugin.
Jul 8 2018, 1:28 PM · KMyMoney
tbaumgart requested changes to D13687: Move reports drawing to reports view plugin.

It compiles but I spotted a problem in the graph of one of my accounts. I expect it not to be related to this patch which I verified.

Jul 8 2018, 8:12 AM · KMyMoney

Jul 7 2018

tbaumgart added a comment to D10614: Custom icons for accounts.

Can you check, if you can use Icons::loadIconFromApplicationCache() and Icons::storeIconInApplicationCache() for your storage?

Jul 7 2018, 7:33 AM · KMyMoney

Jul 5 2018

christiand removed a watcher for KMyMoney: christiand.
Jul 5 2018, 4:24 PM

Jul 1 2018

wojnilowicz requested review of D13831: Move XML read methods to storage plugin.
Jul 1 2018, 4:37 PM · KMyMoney
wojnilowicz added inline comments to D13817: Allow storing SQLite through SQLCipher.
Jul 1 2018, 8:41 AM · KMyMoney
wojnilowicz updated the diff for D13817: Allow storing SQLite through SQLCipher.
Jul 1 2018, 8:41 AM · KMyMoney
tbaumgart added inline comments to D13817: Allow storing SQLite through SQLCipher.
Jul 1 2018, 8:36 AM · KMyMoney

Jun 30 2018

wojnilowicz requested review of D13817: Allow storing SQLite through SQLCipher.
Jun 30 2018, 6:55 PM · KMyMoney
wojnilowicz updated the diff for D13687: Move reports drawing to reports view plugin.
Jun 30 2018, 6:53 PM · KMyMoney

Jun 26 2018

wojnilowicz abandoned D13413: Format widget headers according to the KDE guidelines.
Jun 26 2018, 3:39 PM · KMyMoney
wojnilowicz closed D13581: Prepare for XML storage separation.
Jun 26 2018, 3:38 PM · KMyMoney

Jun 25 2018

wojnilowicz closed D13615: Move encryption settings to XML storage plugin.
Jun 25 2018, 5:54 PM · KMyMoney
wojnilowicz closed D13414: Format reports headers according to the KDE guidelines.
Jun 25 2018, 5:54 PM · KMyMoney
tbaumgart accepted D13581: Prepare for XML storage separation.
Jun 25 2018, 6:17 AM · KMyMoney
wojnilowicz updated the diff for D13581: Prepare for XML storage separation.
Jun 25 2018, 4:42 AM · KMyMoney

Jun 24 2018

tbaumgart requested changes to D13581: Prepare for XML storage separation.
Jun 24 2018, 8:30 PM · KMyMoney
tbaumgart accepted D13615: Move encryption settings to XML storage plugin.

Looks OK to me so far. I have tested it in my environment and did not find and trouble.

Jun 24 2018, 6:56 PM · KMyMoney

Jun 23 2018

wojnilowicz updated the diff for D13615: Move encryption settings to XML storage plugin.
Jun 23 2018, 8:33 AM · KMyMoney
wojnilowicz requested review of D13687: Move reports drawing to reports view plugin.
Jun 23 2018, 6:14 AM · KMyMoney

Jun 19 2018

wojnilowicz requested review of D13615: Move encryption settings to XML storage plugin.
Jun 19 2018, 5:01 PM · KMyMoney

Jun 17 2018

wojnilowicz requested review of D13581: Prepare for XML storage separation.
Jun 17 2018, 1:12 PM · KMyMoney

Jun 12 2018

tbaumgart added a comment to D13465: Fix xml file saving on Windows.

@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?

Jun 12 2018, 7:47 AM · KMyMoney

Jun 11 2018

ostroffjh added a comment to D13465: Fix xml file saving on Windows.

Sorry - I see this is only supposed to affect Windows, so questions about Linux are unnecessary.

Jun 11 2018, 9:59 PM · KMyMoney
ostroffjh added a comment to D13465: Fix xml file saving on Windows.

Question regarding backporting: Is it correct that this does not affect 4.8 branch at all, or just not the Windows build? I don't know if any Linux distros will need another 4.8 release before being able to fully migrate to 5.x Also, does this need backporting to 5.0 branch or will next release be 5,1 and not 5.0.2?

Jun 11 2018, 9:57 PM · KMyMoney
habacker added a comment to D13465: Fix xml file saving on Windows.

(I also used kmm 4.8.0 (not the latest 4.8.2 though) on Windows—which seems to work fine.)

4.8.2 is also not affected, see D13465#276986

Jun 11 2018, 8:28 AM · KMyMoney
habacker added a comment to D13465: Fix xml file saving on Windows.

I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

4.8 branch is not affected - It uses KTemporaryFile for the temporary file and KIO to copy the file to the destination (see https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/kmymoneyview.cpp?h=4.8#n1275)

Jun 11 2018, 8:19 AM · KMyMoney

Jun 10 2018

wojnilowicz closed D13408: Refactor file menu.
Jun 10 2018, 3:24 PM · KMyMoney
wojnilowicz closed D13409: Remove redundant CMake statements.
Jun 10 2018, 3:24 PM · KMyMoney
wojnilowicz closed D13295: Enable foreign keys support in SQLite.
Jun 10 2018, 3:24 PM · KMyMoney
tbaumgart accepted D13408: Refactor file menu.

I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.

Jun 10 2018, 3:03 PM · KMyMoney
ocoole added a comment to D13465: Fix xml file saving on Windows.

Thanks Thomas! (I actually thought I should have discovered this earlier; apparently I didn't test it out very comprehensively back then.)

Jun 10 2018, 2:30 PM · KMyMoney
tbaumgart accepted D13465: Fix xml file saving on Windows.

Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

Jun 10 2018, 1:53 PM · KMyMoney
tbaumgart updated subscribers of D13465: Fix xml file saving on Windows.
Jun 10 2018, 1:37 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Jun 10 2018, 12:39 PM · KMyMoney
ocoole requested review of D13465: Fix xml file saving on Windows.
Jun 10 2018, 12:20 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:
...

I cannot reproduce this. ... Anyhow I changed xmlstorage.cpp:271 a little bit so you can observe backtrace and exception messages better.

Jun 10 2018, 11:08 AM · KMyMoney
christiand accepted D13295: Enable foreign keys support in SQLite.
Jun 10 2018, 10:24 AM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.
Jun 10 2018, 8:43 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Jun 10 2018, 5:20 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed issues with Select All Transactions and Update All Accounts.

Jun 10 2018, 5:16 AM · KMyMoney

Jun 9 2018

tbaumgart added a comment to D13408: Refactor file menu.

Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.

Jun 9 2018, 7:53 PM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Jun 9 2018, 3:46 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed icalendar crash.

Jun 9 2018, 3:45 PM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Jun 9 2018, 3:34 PM · KMyMoney
tbaumgart accepted D13409: Remove redundant CMake statements.

We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.

Jun 9 2018, 2:45 PM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started without options to open the last loaded storage
    • File/Close or Ctrl+W don't work anymore. They show an error (see also message on CLI)

I cannot reproduce this. If you open KMM without a file, then Ctrl+W shouldn't be available.

I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.

Jun 9 2018, 2:41 PM · KMyMoney
wojnilowicz updated subscribers of D13408: Refactor file menu.

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:

I opened an existing kmy/xml file, made some changes to it, and pressed Save.
It throws an error: "Unable to write changes to '[/path/to/file]' [...]\kmymoney\plugins\xml\xmlstorage.cpp:271"

(Interestingly when I hit Save a second time, the second time succeeds)

IMO this would really be a show stopper indeed coz file saving seems to be, in a sense, broken.

(Many thanks both of you for your efforts!) (I've nothing further to add regarding this patch)

Jun 9 2018, 1:13 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Jun 9 2018, 1:11 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

Dear Thomas / Łukasz:

Jun 9 2018, 12:21 PM · KMyMoney
ocoole added inline comments to D13408: Refactor file menu.
Jun 9 2018, 11:41 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Jun 9 2018, 9:12 AM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Jun 9 2018, 9:12 AM · KMyMoney
ocoole added inline comments to D13408: Refactor file menu.
Jun 9 2018, 9:06 AM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Jun 9 2018, 8:18 AM · KMyMoney