Looks OK and if I apply the following patch it also compiles for me (the first hunk seems to be caused by trailing blanks) :
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jul 21 2018
In D14257#295467, @tbaumgart wrote:Tested with my real file which contains 66 schedules. Produces the exact same output as master.
Tested with my real file which contains 66 schedules. Produces the exact same output as master.
In D14257#295447, @tbaumgart wrote:I am missing the removal of the old version in MyMoneySchedule::writeXML().
I am missing the removal of the old version in MyMoneySchedule::writeXML().
Jul 16 2018
Jul 15 2018
This package does not match my distro and I honestly don't want to install it. But since I can compile w/o this feature enabled, go ahead and add it.
Looks OK to me. Made some tests in comparing the output of the master version and this version which do not show differences.
I needed to apply the following patch to get correct results. Reason: you must not set the entry date of a scheduled transaction to a valid value, due to the fact that
I think it's not a good idea to improve code on such occasions. Code could be easily broken and it would be hard to find a cause.
Other than that it looks good to me.
Jul 14 2018
In D13817#291800, @tbaumgart wrote:Now it fails with
[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o /home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 'QtSql/private/qsqlcachedresult_p.h' file not found #include <QtSql/private/qsqlcachedresult_p.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).
Now it fails with
[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o /home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 'QtSql/private/qsqlcachedresult_p.h' file not found #include <QtSql/private/qsqlcachedresult_p.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).
Yes it does.
Jul 13 2018
Does this make any difference?
On my system Qt5::SqlPrivate is defined in Qt5SqlConfig.cmake which is installed by qt5-qtbase-devel. If you won't manage to get Qt5::SqlPrivate on your system, then we'll use less elegant way.
Tried to fix sqlcipher.json issue.
Jul 12 2018
After installing the necessary sqlcipher packages, I get the option to be found and turned on, but cmake produces the following output
I used File/Dump memory with master and D13831 and here is the difference after loading the file
Since the provider is empty because it is missing in version D13831, the return value of MyMoneyAccount::hasOnlineMapping() in KMyMoneyApp::Private::canUpdateAllAccounts() returns false for all accounts, the return value of canUpdateAllAccounts() is also false.
In D13817#290522, @tbaumgart wrote:The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?
In D13831#290516, @tbaumgart wrote:In D13831#290468, @wojnilowicz wrote:In D13831#290049, @tbaumgart wrote:Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.
I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.
Ah, that could well be, since it relies on the QMetaObject stuff.
In case I load a file with this patch, the Update all accounts button is grayed out. This works OK on master with the same file. Can you please check all actions once you have fixed this?
Jul 11 2018
The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?
In D13831#290468, @wojnilowicz wrote:In D13831#290049, @tbaumgart wrote:Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.
I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.
In D13831#290049, @tbaumgart wrote:Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.
Jul 10 2018
Cannot build w/o sqlcipher being installed. Sqlcipher must be optional not mandatory.
Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.
Jul 9 2018
Jul 8 2018
It compiles but I spotted a problem in the graph of one of my accounts. I expect it not to be related to this patch which I verified.
Jul 7 2018
Can you check, if you can use Icons::loadIconFromApplicationCache() and Icons::storeIconInApplicationCache() for your storage?
Jul 5 2018
Jul 1 2018
Jun 30 2018
Jun 26 2018
Jun 25 2018
Jun 24 2018
Looks OK to me so far. I have tested it in my environment and did not find and trouble.
Jun 23 2018
Jun 19 2018
Jun 17 2018
Jun 12 2018
@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?
Jun 11 2018
Sorry - I see this is only supposed to affect Windows, so questions about Linux are unnecessary.
Question regarding backporting: Is it correct that this does not affect 4.8 branch at all, or just not the Windows build? I don't know if any Linux distros will need another 4.8 release before being able to fully migrate to 5.x Also, does this need backporting to 5.0 branch or will next release be 5,1 and not 5.0.2?
In D13465#276678, @ocoole wrote:(I also used kmm 4.8.0 (not the latest 4.8.2 though) on Windows—which seems to work fine.)
4.8.2 is also not affected, see D13465#276986
In D13465#276662, @tbaumgart wrote:I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.
4.8 branch is not affected - It uses KTemporaryFile for the temporary file and KIO to copy the file to the destination (see https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/kmymoneyview.cpp?h=4.8#n1275)
Jun 10 2018
I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.
Thanks Thomas! (I actually thought I should have discovered this earlier; apparently I didn't test it out very comprehensively back then.)
Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.
In D13408#276248, @wojnilowicz wrote:In D13408#276223, @ocoole wrote:Dear Thomas / Łukasz:
Could you try and see if you could reproduce this:
...I cannot reproduce this. ... Anyhow I changed xmlstorage.cpp:271 a little bit so you can observe backtrace and exception messages better.
Fixed issues with Select All Transactions and Update All Accounts.
Jun 9 2018
Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.
In D13408#276278, @tbaumgart wrote:In D13408#276152, @wojnilowicz wrote:In D13408#276141, @tbaumgart wrote:
- Category/New Category is never enabled
I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.
Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.
Fixed icalendar crash.
In D13408#276152, @wojnilowicz wrote:In D13408#276141, @tbaumgart wrote:
- Category/New Category is never enabled
I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.
Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.
We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.
In D13408#276152, @wojnilowicz wrote:In D13408#276141, @tbaumgart wrote:
- When KMyMoney is started without options to open the last loaded storage
- File/Close or Ctrl+W don't work anymore. They show an error (see also message on CLI)
I cannot reproduce this. If you open KMM without a file, then Ctrl+W shouldn't be available.
I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.
In D13408#276223, @ocoole wrote:Dear Thomas / Łukasz:
Could you try and see if you could reproduce this:
I opened an existing kmy/xml file, made some changes to it, and pressed Save.
It throws an error: "Unable to write changes to '[/path/to/file]' [...]\kmymoney\plugins\xml\xmlstorage.cpp:271"(Interestingly when I hit Save a second time, the second time succeeds)
IMO this would really be a show stopper indeed coz file saving seems to be, in a sense, broken.
(Many thanks both of you for your efforts!) (I've nothing further to add regarding this patch)
Dear Thomas / Łukasz:
In D13408#276141, @tbaumgart wrote:
- When KMyMoney is started with the -n command line option
- File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
- When KMyMoney is started with the -n command line option
- File export/Schedules to iCalendar is still available (you need to have this plugin enabled)