Now it fails with

[ 98%] Building CXX object kmymoney/plugins/sqlcipher/CMakeFiles/qsqlcipher.dir/qsql_sqlite.cpp.o
/home/thb/devel/kmymoney/build/kmymoney/plugins/sqlcipher/qsql_sqlite.cpp:44:10: fatal error: 
      'QtSql/private/qsqlcachedresult_p.h' file not found
#include <QtSql/private/qsqlcachedresult_p.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am not sure if using any of these private headers is a good idea. Where does this file come from? I cannot find it for my distro anywhere (maybe, I have not looked everywhere yet).

Yes it does.

Does this make any difference?

On my system Qt5::SqlPrivate is defined in Qt5SqlConfig.cmake which is installed by qt5-qtbase-devel. If you won't manage to get Qt5::SqlPrivate on your system, then we'll use less elegant way.

Tried to fix sqlcipher.json issue.

After installing the necessary sqlcipher packages, I get the option to be found and turned on, but cmake produces the following output

I used File/Dump memory with master and D13831 and here is the difference after loading the file

In D13817#290522, @tbaumgart wrote:

The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?

In D13831#290516, @tbaumgart wrote:

In D13831#290468, @wojnilowicz wrote:

In D13831#290049, @tbaumgart wrote:

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.

Ah, that could well be, since it relies on the QMetaObject stuff.

In case I load a file with this patch, the Update all accounts button is grayed out. This works OK on master with the same file. Can you please check all actions once you have fixed this?

The patch compiles now, but the option is disabled here. I don't have all the necessary packages and don't use SQL backends. Can you find someone else who can verify that this change works as expected and does not break anything?

In D13831#290468, @wojnilowicz wrote:

In D13831#290049, @tbaumgart wrote:

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

I believe it needs a class with Q_OBJECT and probably would require some more includes in headers, so I don't want to switch to it now.

In D13831#290049, @tbaumgart wrote:

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

Cannot build w/o sqlcipher being installed. Sqlcipher must be optional not mandatory.

Did you ever thought about using Q_ENUM? See https://woboq.com/blog/q_enum.html for some details. It looks cleaner if it can be used.

It compiles but I spotted a problem in the graph of one of my accounts. I expect it not to be related to this patch which I verified.

Can you check, if you can use Icons::loadIconFromApplicationCache() and Icons::storeIconInApplicationCache() for your storage?

Looks OK to me so far. I have tested it in my environment and did not find and trouble.

@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?

Sorry - I see this is only supposed to affect Windows, so questions about Linux are unnecessary.

Question regarding backporting: Is it correct that this does not affect 4.8 branch at all, or just not the Windows build? I don't know if any Linux distros will need another 4.8 release before being able to fully migrate to 5.x Also, does this need backporting to 5.0 branch or will next release be 5,1 and not 5.0.2?

In D13465#276678, @ocoole wrote:

(I also used kmm 4.8.0 (not the latest 4.8.2 though) on Windows—which seems to work fine.)

4.8.2 is also not affected, see D13465#276986

In D13465#276662, @tbaumgart wrote:

I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

4.8 branch is not affected - It uses KTemporaryFile for the temporary file and KIO to copy the file to the destination (see https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/kmymoneyview.cpp?h=4.8#n1275)

I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.

Thanks Thomas! (I actually thought I should have discovered this earlier; apparently I didn't test it out very comprehensively back then.)

Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

In D13408#276248, @wojnilowicz wrote:

In D13408#276223, @ocoole wrote:

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:
...

I cannot reproduce this. ... Anyhow I changed xmlstorage.cpp:271 a little bit so you can observe backtrace and exception messages better.

Fixed issues with Select All Transactions and Update All Accounts.

Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.

In D13408#276278, @tbaumgart wrote:

In D13408#276152, @wojnilowicz wrote:

In D13408#276141, @tbaumgart wrote:

• Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Fixed icalendar crash.

In D13408#276152, @wojnilowicz wrote:

In D13408#276141, @tbaumgart wrote:

• Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.

In D13408#276152, @wojnilowicz wrote:

In D13408#276141, @tbaumgart wrote:

• When KMyMoney is started without options to open the last loaded storage
  • File/Close or Ctrl+W don't work anymore. They show an error (see also message on CLI)

I cannot reproduce this. If you open KMM without a file, then Ctrl+W shouldn't be available.

I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.

In D13408#276223, @ocoole wrote:

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:

I opened an existing kmy/xml file, made some changes to it, and pressed Save.
It throws an error: "Unable to write changes to '[/path/to/file]' [...]\kmymoney\plugins\xml\xmlstorage.cpp:271"

(Interestingly when I hit Save a second time, the second time succeeds)

IMO this would really be a show stopper indeed coz file saving seems to be, in a sense, broken.

(Many thanks both of you for your efforts!) (I've nothing further to add regarding this patch)

Dear Thomas / Łukasz:

In D13408#276141, @tbaumgart wrote:

• When KMyMoney is started with the -n command line option
  • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)

• When KMyMoney is started with the -n command line option
  • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)

Fixed all reported deficiencies.

In D13408#275883, @tbaumgart wrote:

Here are my findings:

• • I needed to apply the following patch to compile it:
    
    ` diff --git a/kmymoney/kmymoney.cpp b/kmymoney/kmymoney.cpp index a334f7df..c48b4157 100644
  • a/kmymoney/kmymoney.cpp +++ b/kmymoney/kmymoney.cpp @@ -1990,7 +1990,7 @@ void KMyMoneyApp::slotShowAllAccounts() #ifdef KMM_DEBUG void KMyMoneyApp::slotFileFileInfo() {
• if (!d->m_fileOpen) { + if (!d->m_fileInfo.isOpened) { KMessageBox::information(this, i18n("No KMyMoneyFile open")); return; } `
  • When the backend is closed via File/Close or Ctrl+W:
    • the File/Import and File/Export menus and their entries are not disabled. Selecting them crashes the application.
    • the New credit transfer button is not disabled. Pressing it crashes the application
    • the Update all accounts button is not disabled. Pressing it crashes the application
    • the Tools/Performance test option is not disabled. Selecting it crashes the application
  • Having one XML file (GZIP) open and using File/Open recent to select another XML (GPG encrypted) shows the message Cannot open file as requested. Error was: No storage object attached to MyMoneyFile /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:214 This maybe just a special case, see next entry.
  • Opening GPG encrypted files does not work at all. I started from the CLI with a filename provided. It always shows the message mentioned in the previous line. This is a show stopper!!
  • Open an XML file. Make changes. Don't save. Open another file and press Cancel on the Save changes dialog. This will result in the message Cannot open file as requested. Error was: Storage already attached /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:335 It should just stop the action without message.

Apologies that I'll add one more finding (in addition to Thomas's observations):

+ one nitpick from me (in terms of user experience): is there a way to 'default' (if present) to kmy/xml files in the open file dialog filter list?
(Maybe I'm on Windows) but right now when I click File, Open, it defaults to "GnuCash files" since it's top in the filter list.
Is there a way to push "KMyMoney files" to top of the list (when available)?

Here are my findings:

In D13409#275810, @tbaumgart wrote:

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

Looks OK to me.

In D13279#273007, @ocoole wrote:

1. Open kmm (xml) file
2. Disable xml storage plugin and close kmm
3. Start kmm again [kmm tries to load last used (xml) file (and xml storage plugin disabled)]
4. "Couldn't find suitable plugin to read your storage." Press "OK"
5. Crash

1. Open kmm (xml) file
2. Disable xml storage plugin and close kmm
3. Start kmm again

[kmm tries to load last used (xml) file (and xml storage plugin disabled)]

4. "Couldn't find suitable plugin to read your storage." Press "OK"
5. Crash

I misused multi-arg overload but fixed it right now.