sorry for delay, you can use this one: strufkin@gmail.com

@truf Can you please give us your email address so we can merge this with the correct authorship information?

Oh, I'm sorry I missed this somehow.
Of course land this if it works. 👍 Seems correct to me.

Ping, this is causing noticeable delays on Plasma startup after updating ktp to 20.04, see https://bugs.kde.org/show_bug.cgi?id=420549

In D24065#627077, @heikobecker wrote:

In D24065#594725, @wbauer wrote:

Maybe it would be good to make a new release as well, now that Python2 is EOL...

I prepared one, if you want to test before it goes public:
https://dev.exherbo.org/~heirecka/telepathy-logger-qt-17.09.0.tar.xz
https://dev.exherbo.org/~heirecka/telepathy-logger-qt-17.09.0.tar.xz.sig

In D24065#594725, @wbauer wrote:

Maybe it would be good to make a new release as well, now that Python2 is EOL...

Everyone, thanks for the comments!
Keep in mind that TelepathyQt-0.9.8 is the first version that uses Python 3 instead of Python 2.

Fine with me.
If https://repology.org/project/telepathy-qt/versions is correct Fedora and OpenSUSE still don't have 0.9.8 though.

Looks good to me. FreeBSD CI already has telepathy-qt5-0.9.8 installed.

Works for me. You should probably ping the CI people about the dependency change before committing.

Re-added an accidentally removed comment.

Maybe it would be good to make a new release as well, now that Python2 is EOL...

xincludator.py: Change output format to UTF-8 (fix LANG=C)

I don't think so and Frameworks also need 3.5 since quite some time.

Do we have any reason to stick to 2.8.12?
Is there any single user or developer who need a new TelepathyQtLogger but can't update CMake at least to 3.5?
CMake 3.5 is available since Ubuntu 16.04. I think it is old enough to be required.

Better yet, I forgot REQUIRED option. Probably I was in a rush to address your comment before going to work.
@heikobecker, thank you twice :).

Simplify FindPythonInterp invocation.

Use FindPythonInterp on CMake < 3.12

Ouch! Thanks, @heikobecker! I think that we can use FindPythonInterp for now.

I don't know much about python, but it works fine with python3 where it previously didn't. +1

+1 lgtm

go for it

Thanks, David, you're so incredibly fast!
I forgot to say that I want (going to) to land this to 18.12. I think it OK.

A small step toward

Pavel Akopov

No problem. Can I have your full name for the log?

no commit access....

Thanks

ship it!

Split commits, adjusted commit message accordingly and removed
accidentally included part.

Thanks for looking into this

LGTM, though I would like to have the two commits separately.

Works for me.