Nice, this looks great and works great. Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.

• Rebase
• Add test case for tags

In D25260#569081, @iasensio wrote:

@elvisangelaccio, @bruns, if there is no strong objections, I would like to push this fix to release/19.12 today, before the RC tagging

@elvisangelaccio, @bruns, if there is no strong objections, I would like to push this fix to release/19.12 today, before the RC tagging

go for it

I'm going to push this tomorrow unless there are strong objections.

Hey @ngraham,
I'm terribly sorry, I've been busy with other things. I'll definitely come
back to this is a month or two, after things get a little freed up on my
end. Sorry for making you wait this long, I just saw your message

In D25510#567096, @anthonyfieroni wrote:

It looks like a hack knowing Qt algorithm, can we append the pid in the name? It looks like same, but if we have more than one instances?

• Use if TARGET

This patch is changing the logic. I'd recommend changing the commit message to reflect it.

We could just not introspect at all.
We know the interface we'll be using in advanced.

It looks like a hack knowing Qt algorithm, can we append the pid in the name? It looks like same, but if we have more than one instances?

Fix coding style

@bruns Ping.
We have until November 28 to get this in.

Respect quotes when splitting terms

I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:

Ah, perfect.

In D25435#565600, @ngraham wrote:

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

Hmm, somehow this does not work for me. The "Network" place in the places panel still shows "." as the text.

In D25435#565544, @broulik wrote:

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

Clean

fix

Add translation and Messages.sh to network:/

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

ping @ngraham anything to add ?

Formatting

LGTM.

Any more thoughts on this? I wouldn't like to miss this fix for release/19.12 😃

LGTM. @elvisangelaccio?

Looks like those fixes are already in master

Is there a reason why this was pushed only to master ?

@elvisangelaccio, all good now?

Okay, that makes sense.

Also I am wondering about surfacing to users that the dir size computation is non complete.

I have an idea to perhaps replace the recursiveDirectorySizeLimit : using a timeout
That is, for instance, give 10ms per subdirectory 100 ms for the whole directory, to retrieve the directory size, if timeout is reached return the not-complete results : it will adapt to the IO system load and to drive speed.
This timeout might be configurable.

Was introduced in https://phabricator.kde.org/D19926 but the feature changed quite a lot in the meantime.

In D25335#563263, @ngraham wrote:

This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!

In terms of the UI, this shouldn't only be for Details view; it's possible to view sizes in icon view too, by adding the size metadata item below the filename.

Ping. :)

This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!

Split out filename/content stuff

In D24422#561805, @iasensio wrote:

Abandon in favor of D25255

In D25323#562989, @meven wrote:

In D25323#562908, @kossebau wrote:

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.

I don't think it implies this, and I don't see the point here, textCreator makes thumbnails for text files only anyway.
The change is just so that the background follows the user theme and avoids an hardcoded value that is not good practice.

In D25323#562908, @kossebau wrote:

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.

Also am I wonfering how this relates to the bug report you referred to? Can you tell what effect your code change has on the symptoms reported in https://bugs.kde.org/show_bug.cgi?id=409380#c0 ?

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.
Is this change for background needed to make that rehighlight approach working?

I have opened https://phabricator.kde.org/D25323 to fix the missing highlighting in kio-extras.