I believe the issue currently is that for text files or files without associated definition we end up with an invalid definition that prevents SyntaxHighlighter::setDefinition to call rehighlight().
QTextDocument uses then whatever it get from the theme I guess.
Kate has an explicit special case in KateHighlighting::KateHighlighting to insert a default Format.

Don't think it's highprofile, just a bit annoying that an obvious one liner bugfix wasn't pushed to stable

There's no other 19.08 release planned, but you can request an exception from the release team if this fixes a high profile issue.

In D25255#562221, @elvisangelaccio wrote:

Sure ;)

Sure ;)

Please wait for @bruns approval too.

Instructions for how to do this can be found here: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Should I push this also to release/19.12?

Address comments

In D25257#562157, @elvisangelaccio wrote:

Please push to the release/19.12 branch. Thanks!

In D11382#560853, @ngraham wrote:

19.12 has branched so we can target 20.04 for this and have time for lots and lots of testing. Can I request a review, @elvisangelaccio?

Please push to the release/19.12 branch. Thanks!

• Fix extra space

Seems sane to me and nice since it removes some code.

Rebase

Without D25255, the type will not be reset to "Any", just as before.

After this has landed, the unit tests should go in, then D25255 (amended by the unit test change, XFAIL--).

• Do not trim search terms

In D25257#561786, @iasensio wrote:

In D25257#561782, @bruns wrote:

Please remove the Depends D25255 from the summary, this one is independent.

I'm afraid it won't work well without that, because it handles the empty case for type().
For the sake of simplicity, I could also abandon D25255 and keep the change here.

• Fix comment in CMakeLists.txt

• Fix comment in CMakeLists

• Proper arc diff

• Move to a different test unit
• Address comments

Will have to be rebased after D25260

Abandon in favor of D25255

Superseded by D25258

Proper diff from D25255

• Rename also in dox comment

In D25257#561782, @bruns wrote:

Please remove the Depends D25255 from the summary, this one is independent.

Otherwise, LGTM now.

Please remove the Depends D25255 from the summary, this one is independent.

• Update method signatures

• Clarification for text() method

I changed the filenames to address a change in the class name, and it seems that phab didn't preserve the inline comments, sorry.
I've tried to address the majority of them, now with better understanding of @bruns intentions about the refactor itself.
Thanks for the insightful reviews.

Address inline comments

Wanna do the honors, @meven? :)

would you be okay with someone else taking over the patch and finishing it off?

@msciubidlo if you don't have the time anymore, would you be okay with someone else taking over the patch and finishing it off?

Apologies, I've been stretched way too thin since about the time this diff was accepted, I don't think I even noticed the fact.

This is a nice patch with just a few rough edges to polish.
I encourage @msciubidlo to have a look again.

ping @rjvbb
Do you want someone else to commit this patch or do you want to do it yourself https://community.kde.org/Infrastructure/Phabricator ?

ping @broulik

Please move everything added to a new file, this is independent from the searchbox itself.

Rebase

• API style and simplification

Shipit!

Bump KF5_MIN_VERSION to 5.64

Rebase patch

Please add a comment to the summary that the parser logic is exactly kept as is.

This definitely goes in the right direction, thanks!