Yep, looks fixed now!

Woohoooooooo!

Hi, great effort, thank you.

In D7446#542055, @ngraham wrote:

I think you can go for it. :) Tagging is tomorrow, so please do!

I think you can go for it. :) Tagging is tomorrow, so please do!

Any new feedback ?

Nice, +1

In D24353#541721, @elvisangelaccio wrote:

This is what I get in the shortcuts dialog:

Possibly related to this warning:

KLocalizedStringPrivate::substituteSimple(): "0 instead of 1 arguments to message {Activate Tab %1} supplied before conversion

• Fix bad argument substitution in a i18nc() call

This is what I get in the shortcuts dialog:

@elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.

In D19989#540686, @meven wrote:

We can now restart this work leveraging KCoreAddon KListOpenFilesJo D21760 .

I don't foresee ever adding shortcuts for more than 10 tabs. Even web browsers--which not infrequently host dozens of tabs--do that.

Better variable naming

Make bookmarkForUrl const, add context to translate Recent

In D19989#540686, @meven wrote:

We can now restart this work leveraging KCoreAddon KListOpenFilesJo D21760 .

I've found a bug I introduced within this patch. The fix is in D24376.
I'm really sorry for not having tested it more thoroughly.

GIT_SILENT Make numberForShortcut const

• Add default shortcuts for the first 10 tabs

I'll push to 19.08, thanks for the patch!

• Improve coding style

LGTM

In D24353#541073, @elvisangelaccio wrote:

Why not assign a default shortcut? Alt + i seems to be the standard pattern for this (tried with Firefox and Chrome).

Why not assign a default shortcut? Alt + i seems to be the standard pattern for this (tried with Firefox and Chrome).

LGTM. @elvisangelaccio?

Code is ready for review, tests pass @elvisangelaccio @dfaure
Following https://phabricator.kde.org/D7446#528536 recentlyused:/ bookmarks are only added when KDE_FULL_SESSION is set.

Fix test following latest changes in D7446

Shipit!

Small changes

@meven do you think you could address the final comments and land this?

We can now restart this work leveraging KCoreAddon KListOpenFilesJo D21760 .

ping @elvisangelaccio

I suggest do look at kio_file (kio/src/ioslaves/file), the above code was inspired by kio_file, and then ported differently to Windows.

Thanks

For me it seems logical +1. Perhaps you need to add dolphin dev for be sure.

we need this because the symbols being currently used are Unix-only. Porting to Qt supplied ones allows this plugin to work on other OSes (my concern: Windows) as well. 😁

I'm not sure what the QFileDevice enum gives us compared to the octal permissions as int? Is this just because it looks nicer, to save a conversion, or because you actually need the differenciation between ReadUser and ReadOwner, on Windows?

The /folders path is /locations in fact

Correct ?type use with /files : ?type overrules /files, since they are aggregated with ORs

In D22727#513842, @dfaure wrote:

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

In D19311#539582, @elvisangelaccio wrote:

@hallas I noticed the following warning on dolphin start:

KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action  "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

Could you have a look? Maybe it's because we call actionCollection()->setDefaultShortcuts(m_backAction, backShortcuts); and we don't do the same for m_forwardAction ?

In D20532#539550, @elvisangelaccio wrote:

Sorry for the long delay. I don't think we should add an option to let the user choose what to do on double
But I could accept a patch that triggers the "Go up" action because:

• we have a feature request for that with a bunch of votes (#307505)
• in the past we had already 2 different patches trying to implement this feature: 1, 2

@hallas I noticed the following warning on dolphin start:

More const

Sorry for the long delay. I don't think we should add an option to let the user choose what to do on double clicks.

Oh, and there is a missing BUG: 371837 in the commit message ;)

While the Confirmation tab is not perfect, I don't think that moving this setting to the Behavior or Navigation tabs would be much better.

LGTM now, let's ship it so that we can move forward with the arrows patches.

Review comments

Sure, sounds doable.

It's great to know it!

Yes, KFileMetaData also has extractor plugin for AppImage files, added by R286:1aa7f9168d51e0fc88b42f71fcdb90b0542d0d6f

Didn't Dolphin's information panel get metadata awareness too? Or did that not land yet? Given the Goal: All About the Apps goal, I wonder if we should renew our efforts on this.

As far as I know, only the thumbnails feature is part of the official kde
repo. The rest of the features can be found on the
plasma-appimage-integration extensions set (
https://www.opencode.net/azubieta/plasma-appimage-integration). I guess
that it will worth the effort to explore whether it should be upstreamed or
not and how.

What's left here?