Feed Advanced Search

May 31 2021

vmarinescu removed a watcher for Yakuake: vmarinescu.
May 31 2021, 7:49 PM

Jul 8 2020

rscholar added a watcher for Yakuake: rscholar.
Jul 8 2020, 6:10 PM

May 29 2020

ngraham added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

Thanks! You can close this now.

May 29 2020, 4:31 PM · Yakuake

May 27 2020

printesoi added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

@ngraham Done, thank you!

May 27 2020, 8:00 AM · Yakuake

May 26 2020

ngraham added a comment to D29669: Fix computing screen geometry on multiple HiDPI monitors.

Thanks! This might get a bit more attention if you re-submit it as a merge request at https://invent.kde.org/utilities/yakuake/-/merge_requests, now that KDE has moved patch review to GitLab. Here's some documentation if you're unfamiliar with the workflow: https://community.kde.org/Infrastructure/GitLab

May 26 2020, 10:37 PM · Yakuake

May 14 2020

printesoi updated the diff for D29669: Fix computing screen geometry on multiple HiDPI monitors.

Fix crash when unplugging monitor on which Yakuake is set to open

May 14 2020, 3:34 PM · Yakuake

May 13 2020

ngraham added a reviewer for D29669: Fix computing screen geometry on multiple HiDPI monitors: KDE Applications.
May 13 2020, 7:08 PM · Yakuake

May 12 2020

printesoi updated the diff for D29669: Fix computing screen geometry on multiple HiDPI monitors.

Fixed a problem in MainWindow::getScreen() due to the fact the list of screens is 0 based while Yakuake stores the screen number starting from 1.

May 12 2020, 11:15 AM · Yakuake

May 11 2020

andrewfhou resigned from D29669: Fix computing screen geometry on multiple HiDPI monitors.

Afraid I don't have HiDPI displays to test with. Glad the issue is finally seeing work though!

May 11 2020, 10:00 PM · Yakuake
printesoi added reviewers for D29669: Fix computing screen geometry on multiple HiDPI monitors: hein, ngraham, andrewfhou.
May 11 2020, 9:45 PM · Yakuake
printesoi requested review of D29669: Fix computing screen geometry on multiple HiDPI monitors.
May 11 2020, 9:44 PM · Yakuake

Apr 10 2020

jdb314 added a watcher for Yakuake: jdb314.
Apr 10 2020, 10:25 AM

Mar 10 2020

muesli added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 5:46 PM · Yakuake
muesli added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 5:44 PM · Yakuake
ngraham closed D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 4:08 PM · Yakuake
ngraham updated the summary of D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 4:08 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed copyright statements.

Mar 10 2020, 2:48 AM · Yakuake
ngraham added inline comments to D22227: Add support for resizing by dragging the title bar.
Mar 10 2020, 2:04 AM · Yakuake
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

On a related note, I uploaded another patch that reformats the rest of Yakuake's if statements to match the ones here.

Mar 10 2020, 1:33 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Added copyright statement

Mar 10 2020, 1:30 AM · Yakuake

Mar 8 2020

ngraham added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie can you provide an email address so we can land this patch with correct attribution? Thanks again for the lovely contribution!

Mar 8 2020, 4:22 PM · Yakuake
andrewfhou accepted D22227: Add support for resizing by dragging the title bar.

Awesome!

Mar 8 2020, 4:10 PM · Yakuake
ngraham accepted D22227: Add support for resizing by dragging the title bar.

LGTM. @mweepigeon? Since you requested changed, you'll nedd to re-review and change your status to Accepted if you're happy with it now.

Mar 8 2020, 4:07 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed formatting and added comments

Mar 8 2020, 2:59 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • * Now conforms to KDE style guidelines
  • * C++ dynamic cast instead of C cast
  • * renamed parent to window in TitleBar::mouseMoveEvent()
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • TitleBar now uses the vertical-resize cursor
  • Fixed titlebar buttons using vertical-size cursor
Mar 8 2020, 2:46 AM · Yakuake
andrewfhou added a comment to D22227: Add support for resizing by dragging the title bar.

Dragging and icon seem to be working for me! I think it should be good once you take care of the style change requests

Mar 8 2020, 1:47 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed menu buttons using vertical-size cursor.

Mar 8 2020, 1:37 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

The Title Bar now indicates it is resizeable with a vertical size cursor.

Mar 8 2020, 1:03 AM · Yakuake
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Mar 8 2020, 12:22 AM · Yakuake

Mar 1 2020

ngraham added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Mar 1 2020, 2:41 AM · Yakuake

Feb 29 2020

andrewfhou requested changes to D22227: Add support for resizing by dragging the title bar.

Resizing the window works great, and the 'flickering' effect is relatively minor. However, the cursor should change when it is over the titlebar to indicate to the user that they are able to drag to resize it - ideally the vertical double arrow cursor icon

Feb 29 2020, 5:58 PM · Yakuake
andrewfhou added a watcher for Yakuake: andrewfhou.
Feb 29 2020, 4:10 PM
ngraham closed D25123: New yakuake logo/icon.
Feb 29 2020, 3:30 PM · Yakuake, Frameworks
ngraham added a task to D25123: New yakuake logo/icon: T10243: Some KDE applications could use better icons.
Feb 29 2020, 3:28 PM · Yakuake, Frameworks
ngraham updated the summary of D25123: New yakuake logo/icon.
Feb 29 2020, 3:27 PM · Yakuake, Frameworks
andrewfhou accepted D25123: New yakuake logo/icon.

Looks great to me!

Feb 29 2020, 3:24 PM · Yakuake, Frameworks
ngraham added a comment to D25123: New yakuake logo/icon.

@mglb ping

Feb 29 2020, 3:02 PM · Yakuake, Frameworks

Feb 11 2020

ngraham added a comment to D25123: New yakuake logo/icon.

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Feb 11 2020, 2:56 PM · Yakuake, Frameworks
ndavis accepted D25123: New yakuake logo/icon.
Feb 11 2020, 11:53 AM · Yakuake, Frameworks

Feb 7 2020

davidre added a comment to D25123: New yakuake logo/icon.

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Feb 7 2020, 7:55 AM · Yakuake, Frameworks
mglb retitled D25123: New yakuake logo/icon from [WIP] New yakuake logo/icon to New yakuake logo/icon.
Feb 7 2020, 12:34 AM · Yakuake, Frameworks
mglb updated the diff for D25123: New yakuake logo/icon.

Huh, I was waiting for @hein :) oh well, here it is - C icon with cleaned up source

Feb 7 2020, 12:34 AM · Yakuake, Frameworks

Feb 4 2020

ngraham added a comment to D25123: New yakuake logo/icon.

@mglb ping! I feel like we're really close for this.

Feb 4 2020, 12:12 AM · Yakuake, Frameworks

Dec 5 2019

numerodix added a watcher for Yakuake: numerodix.
Dec 5 2019, 6:53 AM

Nov 10 2019

ngraham added a comment to D25123: New yakuake logo/icon.

Agreed, C for me too.

Nov 10 2019, 5:36 AM · Yakuake, Frameworks

Nov 9 2019

GB_2 added a comment to D25123: New yakuake logo/icon.

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

Nov 9 2019, 9:01 PM · Yakuake, Frameworks
ndavis added a comment to D25123: New yakuake logo/icon.

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

Nov 9 2019, 9:00 PM · Yakuake, Frameworks
mglb updated the diff for D25123: New yakuake logo/icon.

switching to that system means we would need to change many icons.

Nov 9 2019, 8:00 PM · Yakuake, Frameworks

Nov 4 2019

ndavis added a comment to D25123: New yakuake logo/icon.
In D25123#558353, @mglb wrote:

Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice though.

Nov 4 2019, 4:01 AM · Yakuake, Frameworks
mglb added a comment to D25123: New yakuake logo/icon.

I tried seeing how it would look extended down to the bottom margin:

Nov 4 2019, 3:18 AM · Yakuake, Frameworks

Nov 3 2019

ngraham added a comment to D25123: New yakuake logo/icon.

VDG, Should we allow some types of icons to be vertically off center? If not that, should we allow some icons to not reach all the way to the top and bottom margins? There are already some icons like that, but that doesn't necessarily mean we should want that.

Nov 3 2019, 7:44 PM · Yakuake, Frameworks
ndavis added a comment to D25123: New yakuake logo/icon.

A or C for me.

Nov 3 2019, 6:55 PM · Yakuake, Frameworks
ghost34 added a comment to D25123: New yakuake logo/icon.

I like A.

Nov 3 2019, 3:33 PM · Yakuake, Frameworks
ognarb added a reviewer for D25123: New yakuake logo/icon: hein.
Nov 3 2019, 3:08 PM · Yakuake, Frameworks
ngraham updated subscribers of D25123: New yakuake logo/icon.

My vote is for A. I love it. It looks like a pull-down terminal just like the parent icon, re-uses the >_ iconography common to our terminal icons, but adds a flair that makes the > look like a Y, conjuring up the app's name. I think this is fantastic.

Nov 3 2019, 2:50 PM · Yakuake, Frameworks
mglb requested review of D25123: New yakuake logo/icon.
Nov 3 2019, 1:30 AM · Yakuake, Frameworks

Nov 2 2019

madcatx requested review of D25118: Hide window under Wayland when it loses focus.
Nov 2 2019, 1:20 PM · Plasma on Wayland, Yakuake

Oct 17 2019

niteria added a comment to D24661: Shortcut to move yakuake to a next screen.

That makes sense, but it's slightly out of scope of what I wanted to implement. I will revisit once maintaining a local patch proves too much of a hassle.

Oct 17 2019, 2:28 PM · Yakuake

Oct 15 2019

mschiller added a comment to D24661: Shortcut to move yakuake to a next screen.

Had the first scenario in mind. I would use that to move yakuake around when I want it temporarily on a different screen , but when I reopen yakuake it should just honor the original setting value (Should note here that I use yakuake with the "Keep open when losing focus" option). So if Screen 1 is set open on Screen 1 again and if At Mouse Location is set open at mouse location again.

Oct 15 2019, 7:13 PM · Yakuake
niteria added a comment to D24661: Shortcut to move yakuake to a next screen.

Interesting point, but could you elaborate on what should happen when the option to change the setting is disabled?

Oct 15 2019, 6:58 PM · Yakuake
mschiller added a comment to D24661: Shortcut to move yakuake to a next screen.

Having a shortcut to move yakuake around seems quite useful, but I'm not a fan that this overwrites the "Open on screen" setting.
Maybe making this behavior optional?

Oct 15 2019, 4:47 PM · Yakuake
niteria added a reviewer for D24661: Shortcut to move yakuake to a next screen: Yakuake.
Oct 15 2019, 11:57 AM · Yakuake
niteria added a reviewer for D24661: Shortcut to move yakuake to a next screen: hein.
Oct 15 2019, 11:57 AM · Yakuake
niteria requested review of D24661: Shortcut to move yakuake to a next screen.
Oct 15 2019, 11:56 AM · Yakuake

Aug 14 2019

ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.
In D22227#495177, @hein wrote:

The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.

Aug 14 2019, 10:24 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Switched from C style cast to dynamic cast.

Aug 14 2019, 10:21 PM · Yakuake

Jul 14 2019

hein added a comment to D22227: Add support for resizing by dragging the title bar.

The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.

Jul 14 2019, 8:21 AM · Yakuake

Jul 9 2019

ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks Owen, very nice first patch! May it be just the first of many. :)

Jul 9 2019, 7:08 PM · Yakuake
ngraham closed D21867: [Yakuake] add blur effect support.
Jul 9 2019, 7:00 PM · Yakuake

Jul 8 2019

owenchia added a comment to D21867: [Yakuake] add blur effect support.

@owenchia, can you provide your email address so we can land this patch with correct authorship information? Thanks!

Jul 8 2019, 4:47 PM · Yakuake

Jul 7 2019

ryanmccoskrie added inline comments to D22227: Add support for resizing by dragging the title bar.
Jul 7 2019, 3:55 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Adjusted formatting to fit KDE style guidelines.

Jul 7 2019, 3:51 AM · Yakuake

Jul 5 2019

ngraham added inline comments to D22227: Add support for resizing by dragging the title bar.
Jul 5 2019, 12:52 PM · Yakuake
ngraham added a reviewer for D22227: Add support for resizing by dragging the title bar: hein.
Jul 5 2019, 12:36 PM · Yakuake
ngraham updated the summary of D22227: Add support for resizing by dragging the title bar.
Jul 5 2019, 12:35 PM · Yakuake

Jul 4 2019

ngraham added a comment to D21867: [Yakuake] add blur effect support.

@owenchia, can you provide your email address so we can land this patch with correct authorship information? Thanks!

Jul 4 2019, 6:19 PM · Yakuake

Jul 3 2019

ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Got the whole change into request, not just a one-line touch up.

Jul 3 2019, 2:58 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
Jul 3 2019, 2:55 AM · Yakuake

Jul 2 2019

hein accepted D21867: [Yakuake] add blur effect support.

I've resisted patches like this for years now hoping someone would implement this properly in the Konsole KPart as part of the profile system where translucency is regulated, but no one did, so let's go with this.

Jul 2 2019, 1:45 AM · Yakuake

Jul 1 2019

GB_2 added a comment to D21867: [Yakuake] add blur effect support.

Ping

Jul 1 2019, 2:03 PM · Yakuake

Jun 30 2019

vmarinescu added a watcher for Yakuake: vmarinescu.
Jun 30 2019, 5:58 PM

Jun 25 2019

ryanmccoskrie added a member for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM
ryanmccoskrie added a watcher for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM

Jun 17 2019

owenchia added a comment to D21867: [Yakuake] add blur effect support.

Maybe, but that's a design change, not just the addition of a new feature, so now the title/commit message is not accurate; you're not just adding support for blur, you're turning it on by default.

You need to either change the commit message to reflect the actual changes, or (preferably) only add support in this patch, and turn it on by default in another patch.

Jun 17 2019, 2:14 PM · Yakuake
owenchia updated the diff for D21867: [Yakuake] add blur effect support.

change Blur option's default value to false.

Jun 17 2019, 1:59 PM · Yakuake
ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Is having this on the best default? This is not actually a sarcastic rhetorical question; I'm genuinely asking since I don't actually use Yakuake.

I'm not a expert, but i think it's the best to having this blur effect on default.

Jun 17 2019, 1:43 PM · Yakuake
owenchia added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Is having this on the best default? This is not actually a sarcastic rhetorical question; I'm genuinely asking since I don't actually use Yakuake.

Jun 17 2019, 6:38 AM · Yakuake
ngraham added a reviewer for D21867: [Yakuake] add blur effect support: hein.
Jun 17 2019, 4:52 AM · Yakuake
ngraham added a comment to D21867: [Yakuake] add blur effect support.

Thanks very much for the patch!

Jun 17 2019, 4:52 AM · Yakuake
owenchia updated the summary of D21867: [Yakuake] add blur effect support.
Jun 17 2019, 2:01 AM · Yakuake
owenchia requested review of D21867: [Yakuake] add blur effect support.
Jun 17 2019, 2:00 AM · Yakuake

May 23 2019

hein added a comment to D21358: Prevent the Yakuake Task from Showing up in the Task Bar.

It's not that easy I'm afraid.

May 23 2019, 6:12 AM · Yakuake
ngraham added a reviewer for D21358: Prevent the Yakuake Task from Showing up in the Task Bar: hein.
May 23 2019, 4:47 AM · Yakuake
fstpierre requested review of D21358: Prevent the Yakuake Task from Showing up in the Task Bar.
May 23 2019, 3:53 AM · Yakuake

Mar 24 2019

ngraham closed D19835: [Yakuake] Improve customization.
Mar 24 2019, 6:18 PM · Yakuake

Mar 22 2019

chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 11:35 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:59 PM · Yakuake
chauvin added a comment to D19835: [Yakuake] Improve customization.

ok I make some cleanup

Mar 22 2019, 10:51 PM · Yakuake
hein accepted D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:29 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:18 PM · Yakuake