This is actually just an invalid From: header.

https://dmorgan.info/posts/encoded-word-syntax/

In D13902#289950, @rnicole wrote:

I'd say so too! But I'm still not sure why the disk statistics are so underwhelming :-/

I'd say so too! But I'm still not sure why the disk statistics are so underwhelming :-/

The benchmark matches the expectations I'd say

Results of the Dummy resource write benchmark:

Some disk statistics:

Increment database version

Looks good to me.

• Use QUuid constructor instead of fromString
• Remove useless comments

In D13735#283748, @rnicole wrote:

• Fix pipeline test
• Fix some issues with changereplay
  
  Unfortunately I haven't found why a whole key is passed as argument to the readLatest function, so I added a comment saying how to reproduce it

• Fix pipeline test
• Fix some issues with changereplay

In D13735#283172, @rnicole wrote:

Here are the result of a quick run of benchmarks (mailquerytest and pipelinetest) but I fear that there might not be enough samples for these to be statistically sound

bench5 KBDownload

Here are the result of a quick run of benchmarks (mailquerytest and pipelinetest) but I fear that there might not be enough samples for these to be statistically sound

What are the benchmark results?

In D13735#283114, @rnicole wrote:

I will probably move the Key / Identifier / Revision classes into entitystore since these are entity keys, etc.

I will probably move the Key / Identifier / Revision classes into entitystore since these are entity keys, etc.

• Test live queries
• Remove dates from the index (worst general case, but we're generally not the general case)

Wait before merging it, storing the dates alongside the reference in the index is a "bad optimization" (changed my mind over the WE):

Looks overall good to me. I'll apply the patch locally, and will merge it if not problems surface.

Some general notes first; Good job, I like the approach =) Using the buckets makes the whole index smaller, which is great. The tradeoff is probably the added complexity of storing start and end date directly in the value and filtering accordingly.
The alternative would have been to just store the samples as key, and then relying on a post filtering step that reads the relevant dates from the entities directly. I don't know what would perform better either (depends on the dataset I suppose), so I'm fine with this approach as well (If you did make any estimations I'd be interested).

Nitpicks

Remove the ahead-of-time finding of the closest key to the upper bound

The tests crash:

Rebase and remove useless testSyncCal

In D12755#262060, @rnicole wrote:

The testSyncCal's original purpose was:

1. Check that synchronization is working
2. Check that the implementation of skipping event synchronization when the CTag hasn't changed, which to my knowledge is not testable right now

The testSyncCal's original purpose was:

testSyncCal is not yet testing anything, should it perhaps check that the personal calendar is available?

Thanks for the patch!

http://dogmamix.com/MimeHeadersDecoder/

Document test requirements

Oh right, I still haven't figured out how to configure Cyrus for CalDAV or how to add test data. My solution was to install a Radicale server, and add a MyCalendar with one event in it. I should have documented this in the test file, but I forgot. I'll fix that

Here's an example error:

9: Log:     {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.synchronizer : Synchronizing:  Query ["event"] << Id: ""
9:   Filter: QHash()
9:   Ids: ()
9:   Sorting: ""
9:
9: Warning: {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.default      : "Error  QNetworkReply::NetworkError(ContentNotFoundError) \"Error transferring http://localhost/dav/calendars/users/doe - server replied: Not Found\""
9: Warning: {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.default      : "Error  QNetworkReply::NetworkError(ContentNotFoundError) \"Error transferring http://localhost/dav/calendars/users/doe - server replied: Not Found\""
9: Warning: {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.webdav       : Job failed:  "There was a problem with the request.\nHTTP error (203)." KDAV2::DavCollectionsFetchJob 300
9: Warning: {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.synchronizer : Synchronization failed:  Error:  1 Msg:  "There was a problem with the request.\nHTTP error (203)."
9: Warning: {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.synchronizer : Error during sync:  Error:  1 Msg:  "There was a problem with the request.\nHTTP error (203)."
9: Log:     {deb601d2-a55b-4615-b5d5-9be1baaedbfc}.synchronizer : All requests processed.
9: FAIL!  : CalDavTest::testSyncCalEmpty() Compared values are not the same
9:    Actual   (events.size()): 0
9:    Expected (1)            : 1
9:    Loc: [/src/sink/examples/caldavresource/tests/caldavtest.cpp(83)]
9: FAIL!  : CalDavTest::testSyncCalEmpty() Compared values are not the same
9:    Actual   (calendars.size()): 0
9:    Expected (1)               : 1
9:    Loc: [/src/sink/examples/caldavresource/tests/caldavtest.cpp(88)]

I can't run any of the tests. Are the supposed to be working in the docker container?

• Remove useless comment
• Return empty ID on event removal

Looks great =)

Separate value extraction and processing