Don't use QDBusConnection::ExportAllContents
No need to make connect and receivedPackage public slots (they're are the
parent's already)
Fixes T4975
albertvaka |
KDE Connect |
Don't use QDBusConnection::ExportAllContents
No need to make connect and receivedPackage public slots (they're are the
parent's already)
Fixes T4975
Rough manual test
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
plugins/lockdevice/lockdeviceplugin.cpp | ||
---|---|---|
93–94 | Why Properties instead of ExportScriptableInvokables? ring() should be able callable through dbus. | |
plugins/remotecommands/remotecommandsplugin.cpp | ||
61–62 | What do you think about exposing always both things (properties and scriptableinvokables), even on plugins where there are no properties or no dbus slots? This way if we add any it will already work. Also, this is a line I tend to copy-paste when writing a new plugin, so it's better if it "just works" wherever I copy it from. |
Generalize dbus registration
Instead of explicitly registering every plugin, register all plugins
with a dbusPath method.