Reimplement support for property groups, add API to show/hide groups
ClosedPublic

Authored by staniek on Jan 4 2017, 2:21 PM.

Details

Summary

Reimplement support for property groups, add API to show/hide groups

+ update the example app
+ fix doxygen tags
+ API: change some setters to slots
+ API: Rename "auto sync" to "value sync enabled" and "value sync policy"
+ Add: childPropertyItemsExpanded and groupItemsExpanded flags to KPropertyEditorView

KReport port for this API at D4047, Kexi port at D4049

Test Plan

Run the kpropertyexample, play with the 'Show groups' check box, try the --flat option, use the editors, study the new API

Diff Detail

Repository
R13 KProperty
Branch
groups-staniek
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek updated this revision to Diff 9706.Jan 4 2017, 2:21 PM
staniek retitled this revision from to Reimplement support for property groups, add API to show/hide groups.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added a reviewer: piggz.
staniek added a subscriber: Kexi-Devel-list.
Restricted Application added a project: KProperty. · View Herald TranscriptJan 4 2017, 2:21 PM
staniek updated this object.Jan 4 2017, 2:28 PM
staniek updated this revision to Diff 9707.Jan 4 2017, 2:34 PM
  • GIT_SILENT Vertically center the group text
staniek updated this object.Jan 9 2017, 3:46 PM
piggz added inline comments.Jan 11 2017, 7:47 PM
src/KPropertyEditorDataModel.cpp
213–214

to be left?

399

Full reset needed?

src/KPropertySet.h
235

Add inline?

staniek updated this revision to Diff 10231.Jan 16 2017, 12:54 PM
staniek marked an inline comment as done.
  • GIT_SILENT debug comments--
  • Make KPropertySet::changePropertyIfExists non-inline

@piggz It would be good to have this BIC change on Monday.

src/KPropertyEditorDataModel.cpp
399

I think so, the model radically changes: d->indicesForNames is refreshed.

What we can add here *later* is selecting again the same row and ensuring it's visible. This needs a bit larger testing.

src/KPropertySet.h
235

Changed to non-inline

piggz accepted this revision.Jan 16 2017, 4:30 PM
piggz edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2017, 4:30 PM
This revision was automatically updated to reflect the committed changes.