Moved KReportDpi.h to KEReportDpi_p.h and associated changes
Details
Details
- Reviewers
staniek - Maniphest Tasks
- T4491: Move KReportDpi.h to KReportDpi_p.h
- Commits
- R14:362b144caf8f: Address T4491 making KReportDpi a private non-exported class
Ran autotests and kreportexample
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Branch
- t4491-kreportdpi
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/wrtembed/KReportDpi_p.h | ||
---|---|---|
35 | Is it used? If so it is somewhere else, we have no KoApplication. |
src/wrtembed/KReportDpi_p.h | ||
---|---|---|
35 | No, it is not used |
Comment Actions
Hm hm hmm. After the removal I am thinking about this simplification:
Move the remains to KReportUtils_p.h (to KReportPrivate::dpi*()) and remove the KReportDpi*.* entirely.
Comment Actions
Good job, one note
src/common/KReportUtils_p.h | ||
---|---|---|
23 ↗ | (On Diff #9351) | This include is needed in KReportUtils_p.cpp not here? |
src/common/KReportUtils_p.cpp | ||
---|---|---|
2 ↗ | (On Diff #9386) | undo:
|