Move all inline functions to .cpp
Add operator= due to const member d
Add factor() to obtain the pixelConversion value
Details
Details
- Reviewers
staniek - Commits
- R14:fbac3ff79a8c: Add dtpr to KReportUnit
checked unit conversions in property editor for 3 different items in kreportexample
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Branch
- dptr-unit
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/common/KReportUnit.cpp | ||
---|---|---|
439 | Here and in many other places: { -> \n{ | |
468 | Can we have the ctor and dtor on the top at line 50 or so? | |
src/common/KReportUnit.h | ||
101 | unit -> type? | |
105 | Needs docs like this: Assigns specified type and factor 1.0 to the object | |
105 | unit -> type? | |
107 | If we have operator= then also the copy ctor needs to be implemented explicitely. | |
123 | While we can't keep the code that uses d-pointer inline I propose to keep all these short static methods inline. And even prepend inline keyword to them. | |
218 | If it's inline let's keep the code in the header. |
src/common/KReportUnit.h | ||
---|---|---|
123 | Remove all }; from the header |