Add dptr to KReportScriptHandler
ClosedPublic
Actions

Authored by piggz on Dec 19 2016, 6:42 PM.

Details

Reviewers

staniek

Commits

R14:3ae612d44e0a: Add dptr to KReportScriptHandler

Test Plan

Ran kreportexample and Kexi with a report containing scripts

Repository

R14 KReport

Branch

dptr-scripthandler

Lint

No Linters Available

Unit

No Unit Test Coverage

piggz retitled this revision from to Add dptr to KReportScriptHandler.

piggz updated this object.

piggz edited the test plan for this revision. (Show Details)

piggz added a reviewer: staniek.

src/renderer/scripting/KReportScriptHandler.cpp
63	How about putting all these 4 variables on stack in Private to simplify the code? Now they're leaked BTW.
src/renderer/scripting/KReportScriptHandler.h
68	+Q_DISABLE_COPY

staniek requested changes to this revision.Dec 19 2016, 7:17 PM

staniek edited edge metadata.

This revision now requires changes to proceed.Dec 19 2016, 7:17 PM

Implement comments. Note, only engine is added to heap becuase it deletes registered objects.

piggz marked 2 inline comments as done.Dec 19 2016, 8:16 PM

1 fix left, please land without further review, thanks.

src/renderer/scripting/KReportScriptHandler.cpp
77	Sorry, this note is not needed, I meant only the one from line 62. Thanks.

This revision is now accepted and ready to land.Dec 19 2016, 8:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/renderer/scripting/KReportScriptHandler.h (28 lines)
M			src/renderer/scripting/KReportScriptHandler.cpp (133 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9177	d3dbe75		Dec 19 2016, 6:42 PM	★	★
Diff 2	9183	d3dbe75	- Implement comments. Note, only engine is added to heap becuase it deletes registered objects.	Dec 19 2016, 8:16 PM	★	★
Diff 3	9186	d3dbe75	R14:3ae612d44e0a0ecebb1dba8f68b8c1b2bf0c3577	Dec 19 2016, 8:41 PM	★	★