Differential D3700

Add "Documentation" settings category
ClosedPublic
Actions

Authored by antonanikin on Dec 16 2016, 9:36 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:7fef687ed4ac: Add "Documentation" settings category
R33:7fef687ed4ac: Add "Documentation" settings category
Summary

This patch adds "Documentation" settings category for more consistent user interface.

Test Plan

Tested on master branch

Diff Detail

Repository
R33 KDevPlatform
Branch
docs_settings_group
Lint
No Linters Available
Unit
No Unit Test Coverage
antonanikin updated this revision to Diff 9063.Dec 16 2016, 9:36 AM
antonanikin retitled this revision from to Add "Documentation" settings category.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.
antonanikin updated this object.Dec 16 2016, 9:37 AM
kfunk requested changes to this revision.Dec 16 2016, 10:11 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Rest LGTM, thanks!

shell/settings/documentationpreferences.h
22

Please use good old include guards (#ifndef)

This revision now requires changes to proceed.Dec 16 2016, 10:11 AM
kfunk added a comment.Dec 16 2016, 10:12 AM

Side note: Looking at the screenshot: "Python Style Checker" should probably make it to the analyzer category.

kfunk accepted this revision.Dec 16 2016, 10:12 AM
kfunk edited edge metadata.

Whoops, wanted to mark this Diff as accepted...

This revision is now accepted and ready to land.Dec 16 2016, 10:12 AM
antonanikin marked an inline comment as done.Dec 16 2016, 10:21 AM
antonanikin updated this revision to Diff 9065.Dec 16 2016, 10:23 AM
antonanikin edited edge metadata.

use good old include guards (#ifndef)

Closed by commit R33:7fef687ed4ac: Add "Documentation" settings category (authored by antonanikin). · Explain WhyDec 16 2016, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9065

View Options

interfaces/configpage.h

Loading...
View Options

shell/CMakeLists.txt

Loading...
View Options

shell/settings/documentationpreferences.h

Loading...
View Options

shell/settings/documentationpreferences.cpp

Loading...
View Options

shell/uicontroller.cpp

Loading...