The warnings can be found at
https://share.kde.org/index.php/s/YqpXnnjvEafO8ei
Related Google Code-In 2016 task:
https://codein.withgoogle.com/dashboard/task-instances/6201455297953792/
The warnings can be found at
https://share.kde.org/index.php/s/YqpXnnjvEafO8ei
Related Google Code-In 2016 task:
https://codein.withgoogle.com/dashboard/task-instances/6201455297953792/
All the tests were passed
No Linters Available |
No Unit Test Coverage |
shell/mainwindow_p.cpp | ||
---|---|---|
323 |
But maybe it's better to keep it as it is since it doesn't hurt and do not create not very needed change in history. @kfunk? | |
util/tests/test_path.cpp | ||
373 | Probably, this warning was false-positive warning since this one tests if equality overload is really working at all | |
vcs/vcspluginhelper.cpp | ||
427 | Not really necessary probably. @kfunk, same question? |
Rest LGTM
language/codecompletion/codecompletionitemgrouper.cpp | ||
---|---|---|
28–38 | Style: While at it: Let's do one enum value per line? | |
shell/mainwindow_p.cpp | ||
323 | Please a) don't move the line, b) just omit action =. That's fine. | |
util/tests/test_path.cpp | ||
373 | +1, don't remove these lines @ematirov Is there a way to instruct PVS to ignore certain lines? | |
vcs/vcspluginhelper.cpp | ||
427 | Change looks good to me. I'd keep it. |