Details
- Reviewers
nienhueser rahn - Group Reviewers
Marble
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Nice, still some minor nitpicks.
src/lib/marble/StyleBuilder.cpp | ||
---|---|---|
154 | This value marks the minimum zoom level where the street appears. Zoomlevels are exactly organized like in OpenStreetMap: level 0 is the lowest one which contains the whole earth in a single picture. Level 19 the highest one where you can see all details of a small street. | |
732 | Should we really not display any outline? |
You are probably right.
src/lib/marble/StyleBuilder.cpp | ||
---|---|---|
154 | I had trouble with displaying it on the higher zoom levels, but I suspect it was because of the way my example (https://www.openstreetmap.org/way/27852990) was rendered in particular. i have checked on OSM and the lowest zoom level I can see the raceway is 12. | |
732 | We probably should, my bad. |
Sorry, still a nitpick: during compilation I get this:
/home/tackat/marble/sources/src/lib/marble/geodata/data/GeoDataPlacemark.cpp: In member function ‘QString Marble::GeoDataPlacemark::categoryName() const’:
/home/tackat/marble/sources/src/lib/marble/geodata/data/GeoDataPlacemark.cpp:362:12: warning: enumeration value ‘HighwayRaceway’ not handled in switch [-Wswitch]
switch (d->m_visualCategory) {
I've tested you patch and the only thing left to complete this task seems to be the compilation warning above. Apart from that it looks great.