Custom copy of upcoming ECMAddQCH.cmake, see https://phabricator.kde.org/D2854
for existing issues and open questions.
Details
- Reviewers
staniek piggz - Group Reviewers
KDb - Commits
- R15:0f477121d325: New: KDbAddQCH.cmake for creating an API dox QCH file during the build
KDb.qch generated by this: https://share.kde.org/index.php/s/wpRRWfYeZKaccjN
Diff Detail
- Repository
- R15 KDb
- Branch
- addQCH
- Lint
No Linters Available - Unit
No Unit Test Coverage
workaround cmake_parse_arguments not defining variables for empty multi-var arguments
cmake/modules/KDbAddQCH.cmake | ||
---|---|---|
502 | Curent message may be not informative enough so I propose: Unable to find the doxygen utility -> Unable to find the doxygen utility version ${DOXYGEN_MIN_VERSION) (and for the other repos) I just realized I have Doxygen 1.8.12, which is the last released. What's special in 1.8.13? |
cmake/modules/KDbAddQCH.cmake | ||
---|---|---|
502 | Alternative proposal (as implemented in updated patch):
It will have (once released) the mentioned patch for doxygen which fixes the hardcoded JS files not being added to the QCH file. |
cmake/modules/KDbAddQCH.cmake | ||
---|---|---|
277 | please tell me if the files are co-installable, i.e. paths use ${KDB_BASE_NAME} or so |
cmake/modules/KDbAddQCH.cmake | ||
---|---|---|
277 | Is was following the uppercase HTML which KDEInstallDirs is using for the DOCBUNDLEDIR vars. But would agree that lowercase feels more natural on *nixoid systems, will change. | |
277 | Co-installability in the same directory completely depends on what is used with the OUTPUT_BASENAME argument in the kdb_add_qch(...) call. Currently it is just KDb, so will not work. Changing now to ${KDB_BASE_NAME} |
Thanks for the review! Will apply later tonight and then also transfer the changes developed here to KProperty and KReport, without review, okay?