[KDevelop/PHP] Implement Grouped namespaces
Needs ReviewPublic

Authored by hmitonneau on May 5 2020, 10:20 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T6804: PHP 7.2 features
T6809: PHP 7.0 features
Summary

This is a first step to implement Grouped namespaces.

The syntax has been updated to parse Grouped namespaces without generating errors, but declarations into grouped namespaces are not processed.

"Normal" use statements are still processed.

Diff Detail

Repository
R52 KDevelop: PHP Support
Lint
Lint Skipped
Unit
Unit Tests Skipped
hmitonneau created this revision.May 5 2020, 10:20 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptMay 5 2020, 10:20 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
hmitonneau requested review of this revision.May 5 2020, 10:20 AM

Are the trailing commas from T6804 supported?

Are the trailing commas from T6804 supported?

Yes, trailing commas are supported

hmitonneau updated this revision to Diff 83332.Jul 23 2020, 5:03 PM

What is missing:

  • Declaration with alias into grouped namespace are not processed: use Foo\ { const C as FooC };
  • There is no test
  • The mix between UseImportType, ParserUseImportType, DeclarationType is not clean