the user can provide a maximum temperature delta in the Limit
settings section. Between each exposure, if the difference between the
last focus temperature and the current temperature exceeds the defined
delta, then autofocus is triggered.
Details
- Reviewers
mutlaqja - Commits
- R321:63c220e37070: Add autofocus on temperature change
- connect a focuser with a temperature probe
- check the temperature delta checkbox
- perform autofocus
- create and start a sequence of several captures
- put your fingers on the probe for a few seconds
- double check that autofocus is triggered on next exposure
Diff Detail
- Repository
- R321 KStars
- Branch
- focus-on-temperature-change (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27048 Build 27066: arc lint + arc unit
Hello,
I am not sure what should be done for the translation / automatic testing area.
Here is a screenshot of the new interface, with the temperature delta setting.
Cheers,
Florian
Excellent, thanks for this proposal! I have nothing but minor points, looks good to me.
kstars/ekos/capture/capture.cpp | ||
---|---|---|
1948 | Good spot, wouldn't __LINE__ solve this problem? :) | |
1956 | Yes, there was an else after a if-then-return, but with big blocks of code like this, it is probably better to consider the if addresses isRefocus, isInSequenceFocus and inSequenceFocusCounter as a set of three related flags, instead of the things that happen in those blocks. So please keep the else for clarity, so that others understand? (minor) | |
kstars/ekos/focus/focus.cpp | ||
584 | You could use numeric precision here for your log. |
Excellent, thank you! Please submit this to KStars's Gitlab here: https://invent.kde.org/education/kstars
Please tell me how to do that.
Thanks!
Found out myself, here is the merge request:
https://invent.kde.org/education/kstars/-/merge_requests/4