Differential D3405

Use KWindowSystem::isPlatformX11
ClosedPublic
Actions

Authored by graesslin on Nov 17 2016, 3:43 PM.

Details

Reviewers
bgupta
Commits
R166:f9df0dcc92b6: Use KWindowSystem::isPlatformX11
Summary

This saves one string comparison as it's only checked once per
application life cycle.

Diff Detail

Repository
R166 Spectacle
Branch
kwindowystem-isplatformx11
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 8280.Nov 17 2016, 3:43 PM
graesslin retitled this revision from to Use KWindowSystem::isPlatformX11.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: bgupta.
bgupta accepted this revision.Nov 19 2016, 9:52 PM
bgupta edited edge metadata.

Sorry, didn't notice this earlier. Good to go.

This revision is now accepted and ready to land.Nov 19 2016, 9:52 PM
Closed by commit R166:f9df0dcc92b6: Use KWindowSystem::isPlatformX11 (authored by graesslin). · Explain WhyNov 22 2016, 7:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/Gui/KSMainWindow.cpp (3 lines)
Msrc/SpectacleCore.cpp (2 lines)

Diff 8280

View Options

CMakeLists.txt

Loading...
View Options

src/Gui/KSMainWindow.cpp

Loading...
View Options

src/SpectacleCore.cpp

Loading...