Differential D29633

[Battery Monitor] Fix toolTipMainText when plugged in
ClosedPublic
Actions

Authored by broulik on May 11 2020, 1:38 PM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
Commits
R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in
Summary

It only had a return value for "NoCharge" since the else case was only for not plugged in, resulting in it effectively returning undefined, throwing during assignment "cannot assign [undefined] to string" and leaving whatever text happened to be shown last.

BUG: 420920

Test Plan

Literally none

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 11 2020, 1:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 1:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 11 2020, 1:38 PM
mart accepted this revision.May 11 2020, 3:46 PM
This revision is now accepted and ready to land.May 11 2020, 3:46 PM
ngraham accepted this revision.May 11 2020, 5:25 PM
ngraham edited the summary of this revision. (Show Details)
Closed by commit R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in (authored by broulik). · Explain WhyMay 12 2020, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82658

View Options

applets/batterymonitor/package/contents/ui/batterymonitor.qml

Loading...