[kcmkwin/kwinoptions] Use text to describe maximize button actions
ClosedPublic

Authored by zzag on May 12 2020, 7:12 AM.

Details

Summary

Currently, we use icons to display possible maximize button actions. The
problem with those icons is that they are confusing even for me, a person
who knows kwin in and out. The size_all icon implies that if you click the
maximize button, you'll be able to move the window around. Same goes with
the size_ver and size_hor icons, they indicate that user will start
resizing the window in the vertical and horizontal direction, respectively.

Test Plan

Before

After

Diff Detail

Repository
R108 KWin
Branch
kcmkwin-options-text-maximize-button-actions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26764
Build 26782: arc lint + arc unit
zzag created this revision.May 12 2020, 7:12 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 12 2020, 7:12 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 12 2020, 7:12 AM
zzag edited the test plan for this revision. (Show Details)May 12 2020, 7:14 AM
zzag updated this revision to Diff 82633.May 12 2020, 7:21 AM

Delete unused includes.

zzag updated this revision to Diff 82634.May 12 2020, 7:46 AM

Delete more unused includes.

broulik added inline comments.
kcmkwin/kwinoptions/kwinoptions_settings.kcfg
95

This seems unrelated. If any, this is a defaults change that should be done separately.

zzag updated this revision to Diff 82638.May 12 2020, 8:32 AM

Undo change that fixes the default for MaximizeButtonRightClickCommand.

zzag updated this revision to Diff 82640.May 12 2020, 8:33 AM

Rebase.

ndavis accepted this revision.May 12 2020, 4:43 PM
ndavis added a subscriber: ndavis.

+1, much clearer

This revision is now accepted and ready to land.May 12 2020, 4:43 PM

+1 for sure. Might recommend slightly different strings though.

kcmkwin/kwinoptions/mouse.ui
620

I might prefer "Vertically maximize"

625

...Similarly, "Horizontally maximize"

zzag added inline comments.May 12 2020, 4:56 PM
kcmkwin/kwinoptions/mouse.ui
620

Yes, it sounds much better but we already use "Maximize (vertical only)" and "Maximize (horizontal only)" in a lot of places.

This revision was automatically updated to reflect the committed changes.
ngraham added inline comments.May 13 2020, 6:14 PM
kcmkwin/kwinoptions/mouse.ui
620

Okay, see D29729