New qml component: ClientModelByScreenAndActivity
ClosedPublic

Authored by tcorreabr on Apr 29 2020, 5:34 PM.

Details

Summary

Provide for KWin scripts the possibility to work with a activities aware ClientModel. In the same way that the ClientModelByScreenAndDesktop works with virtual desktops.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
tcorreabr created this revision.Apr 29 2020, 5:34 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptApr 29 2020, 5:34 PM
tcorreabr requested review of this revision.Apr 29 2020, 5:34 PM
zzag accepted this revision.Apr 30 2020, 5:34 AM
zzag added a subscriber: zzag.

The new model is fine but we have to think about making restrictions more flexible and deprecating ClientModelBy*.

This revision is now accepted and ready to land.Apr 30 2020, 5:34 AM
zzag added inline comments.Apr 30 2020, 5:35 AM
scripting/scripting.cpp
712

2.1?

Indeed. The ideal solution would be to work with a generic ClientModel and be able to set the restrictions on the qml side, avoiding the declaration of a model for each situation.

tcorreabr added inline comments.Apr 30 2020, 3:59 PM
scripting/scripting.cpp
712

I don't see any problem. Would a possible implementation of the amendment regarding the restrictions lead to version 2.2?

zzag added inline comments.May 6 2020, 7:22 AM
scripting/scripting.cpp
712

If it's implemented after 5.19 is released, I think so.

zzag added a comment.EditedMay 6 2020, 7:24 AM

Could you please bump the minor version and provide me with your name and email for commit authorship information(in case you don't have commit access)?

tcorreabr added a comment.EditedMay 6 2020, 4:24 PM

Sorry for the silly question, but should I update the version of all components or just the ClientModelByScreenAndActivity one?

Name: Tiago Corrêa
Email: tcorreabr@gmail.com

zzag added a comment.May 7 2020, 5:24 AM

Sorry for the silly question, but should I update the version of all components or just the ClientModelByScreenAndActivity one?

No, only ClientModelByScreenAndActivity.

Name: Tiago Corrêa
Email: tcorreabr@gmail.com

tcorreabr updated this revision to Diff 82306.May 8 2020, 7:16 PM

Component version bumped.

This revision was automatically updated to reflect the committed changes.