Differential D29098

Removed kde logo from sd and memory stick (/devices/64)
Needs ReviewPublic
Actions

Authored by saligari on Apr 22 2020, 2:53 PM.

Details

Reviewers
None
Group Reviewers
VDG
Summary

I think it is not needed, especially since these icons are usually rather small

Test Plan

Before:

and after:

I actually kind of like the logo :/

Diff Detail

Repository
R266 Breeze Icons
Branch
remove-kde-logo (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25698
Build 25716: arc lint + arc unit
saligari created this revision.Apr 22 2020, 2:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 22 2020, 2:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
saligari requested review of this revision.Apr 22 2020, 2:53 PM
saligari updated this revision to Diff 80898.Apr 22 2020, 2:57 PM

cleaned them and svgcleaned them

saligari edited the test plan for this revision. (Show Details)Apr 22 2020, 2:59 PM
saligari edited the test plan for this revision. (Show Details)
ngraham added a subscriber: ngraham.Apr 22 2020, 3:04 PM

Hmm, now there's a huge empty area on those icons. I think the Plasma logo was visually balancing out the composition a bit. Maybe the Plasma logo itself wasn't appropriate, but it looks like maybe *something* needs to live there in its place, or we need to re-arrange things a bit.

ndavis added a subscriber: ndavis.Apr 22 2020, 5:24 PM

yes, I agree with @ngraham

Revision Contents
Changeset List

Diff 80898

View Options

icons-dark/devices/64/media-flash-memory-stick.svg

Loading...
View Options

icons-dark/devices/64/media-flash-sd-mmc.svg

Loading...
View Options

icons/devices/64/media-flash-memory-stick.svg

Loading...
View Options

icons/devices/64/media-flash-sd-mmc.svg

Loading...