Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename Breeze to Breeze Light). Maybe Breeze Classic too if people want the old Breeze colorscheme, but that could be on store.kde.org instead. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be used to refer to the complete theme or a color scheme compatible version of Breeze (i.e., Breeze plasma theme).
But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd to still have a Breeze Plasma theme.
Also maybe we should discuss that after this patch, or separately?
But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd to still have a Breeze Plasma theme.
Also maybe we should discuss that after this patch, or separately?
I don't think eliminating one of the light color schemes needs to be done separately. Discussions about what to do about plasma themes and icon themes are outside the scope of this patch, but I just wanted you to see where I was going with that suggestion.
Remove Breeze Light color scheme, per @ndavis's suggestion (I came to agree that it doesn't make sense to keep it around here; we can put it on GHNS along with "Breeze Classic"
I think we may need a kconf update script to migrate people to the new colors, since the colors in the current color scheme get cached in their config files.
How are you guys feeling about the colors here? The Tools Area color currently used in this patch and the mockups demos well, but I'm starting to wonder if we're regressing usability in the process. I'm starting to think that the color isn't dark enough to adequately signal that a window is active or inactive. Current Breeze is very obvious about this, but the new color is quite subtle, especially for windows with only a titlebar. It's more obvious in windows with a large Tools Area like Okular or Gwenview since there's a large area of color change and all the text and icons lighten too, but I feel like for windows with less stuff in the Tools Area (e.g. dialogs and 3rd-party apps) it takes me longer to figure out at a glance which window is active than it did before. Do other folks find the same thing? I wonder if we might want to experiment with making the Titlebar/Tools Area gray color a touch darker. Thoughts?
It's the change to kstyle/breezetoolsareamanager.cpp that causes this patch to fail to apply. That file doesn't exist anywhere. It's not even in the tools area patch.
Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see what would happen, I made my arcpatch-D27669 branch the upstream of arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you sure you've rebased against the tools area patch correctly?
The event filter in breezetoolsareamanager.cpp already exists in the tools area patch and the other changes are incompatible with the current version of the tools area patch.
Not bad! I like that the buttons are lighter colored. In fact I feel like they could be a bit lighter still and look even better. But I feel like the Tools Area background isn't sufficiently darker than the normal window background--especially for windows where the Tools Area is just a titlebar. IMO the former needs to be darkened or the latter lightened. Also using the normal text color for selected items kind of feels like it needs the default selection color to be lighter or else readability is impaired a bit.
Also using the normal text color for selected items kind of feels like it needs the default selection color to be lighter or else readability is impaired a bit.
Oops, that's a leftover bit from when I was testing my changes to the Breeze QStyle. This color scheme is something I've been slowly working on for a while.
New version with fixed selection color and darker titlebar:
Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename Breeze to Breeze Light). Maybe Breeze Classic too if people want the old Breeze colorscheme, but that could be on store.kde.org instead. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be used to refer to the complete theme or a color scheme compatible version of Breeze (i.e., Breeze plasma theme).
Back to this: Now that Breeze Light is gone, what if we rename Breeze to Breeze Light? How will that affect people upgrading from the old version of Breeze or Breeze Light?
Also, since I'm working on the color schemes, do you think it would make more sense for the color scheme to be a separate patch from the titlebar button changes?
Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename Breeze to Breeze Light). Maybe Breeze Classic too if people want the old Breeze colorscheme, but that could be on store.kde.org instead. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be used to refer to the complete theme or a color scheme compatible version of Breeze (i.e., Breeze plasma theme).
Back to this: Now that Breeze Light is gone, what if we rename Breeze to Breeze Light? How will that affect people upgrading from the old version of Breeze or Breeze Light?
Also, since I'm working on the color schemes, do you think it would make more sense for the color scheme to be a separate patch from the titlebar button changes?
Yeah, and it might make sense to roll the titlebar close button and defaults changes into the parent patch (@cblack, feel free to do that) and then I'll abandon this patch and you can do the color scheme patch.
Changing the name makes sense I think, Then we'll just have "Breeze Light" and "Breeze Dark". If we do this, we should put the current Breeze on store.kde.org via GHNS for sure.