Add KSysGuard::Sensors library
ClosedPublic

Authored by ahiemstra on Mar 19 2020, 3:23 PM.

Diff Detail

Repository
R111 KSysguard Library
Branch
sensors_lib
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25595
Build 25613: arc lint + arc unit
ahiemstra created this revision.Mar 19 2020, 3:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2020, 3:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Mar 19 2020, 3:23 PM
ahiemstra updated this revision to Diff 78020.Mar 19 2020, 3:48 PM
  • Add some documentation to classes
ahiemstra updated this revision to Diff 78080.Mar 20 2020, 10:15 AM
  • Properly install the export header
ahiemstra updated this revision to Diff 78275.Mar 23 2020, 10:47 AM
  • Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
zzag added a subscriber: zzag.Mar 23 2020, 11:49 AM
zzag added inline comments.
sensors/Sensor.h
3

Could you please update my last name?

git grep -l 'Vlad Zagorodniy' | xargs sed -i 's/Vlad Zagorodniy/Vlad Zahorodnii/g'
ahiemstra updated this revision to Diff 78372.Mar 24 2020, 4:04 PM
  • Add some documentation to classes
  • Properly install the export header
  • Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
  • Rebase, update SensorInfo and Daemon XML to new versions
ahiemstra updated this revision to Diff 78985.Mar 31 2020, 1:09 PM
  • Update zzag's last name
mart added a subscriber: mart.Apr 1 2020, 3:46 PM

while porting the systemmonitor plasmoids to upstream, i found a couple of problems:

  • gcc didn't like inserting using a const iterator
  • qmldir outdated with the old plugin name

diff on top of this phab: https://phabricator.kde.org/P567

ahiemstra updated this revision to Diff 79072.Apr 1 2020, 5:40 PM
  • Fix qmldir file
mart added inline comments.Apr 21 2020, 10:24 AM
sensors/Sensor.cpp
208

if (

sensors/SensorDaemonInterface.cpp
88

also here, [this] instead of [=]

sensors/declarative/SensorsPlugin.cpp
2

also here

sensors/declarative/SensorsPlugin.h
2

shouldn't remove existing copyrights?

ahiemstra added inline comments.Apr 21 2020, 10:58 AM
sensors/declarative/SensorsPlugin.cpp
2

Same issue as above.

sensors/declarative/SensorsPlugin.h
2

It's a new file, but for some reason Phab thinks it's copied from formatter.h (which it has nothing to do with).

ahiemstra updated this revision to Diff 80758.Apr 21 2020, 12:29 PM
  • clang-format sensors lib
  • Capture this rather than =
ahiemstra marked 7 inline comments as done.Apr 21 2020, 12:31 PM
ahiemstra updated this revision to Diff 81576.Apr 30 2020, 11:33 AM
  • Don't expose private SensorInfo in public interface of SensorQuery
ahiemstra updated this revision to Diff 81577.Apr 30 2020, 11:36 AM

Don't eat the lib Arc

ngraham added a subscriber: ngraham.May 4 2020, 3:07 PM

+1, excellent work.

sensors/Sensor.cpp
3

Update name

220

if (

sensors/SensorInfo_p.h
37

Is it? :)

ahiemstra updated this revision to Diff 82080.May 6 2020, 11:52 AM
  • Correct Vlad's name in a few more places
  • Make comments in SensorInfo_p.h a bit more useful
ahiemstra updated this revision to Diff 82082.May 6 2020, 12:02 PM

Maybe right now?

ahiemstra marked 3 inline comments as done.May 6 2020, 12:03 PM
davidedmundson accepted this revision.May 7 2020, 9:11 AM
This revision is now accepted and ready to land.May 7 2020, 9:11 AM
This revision was automatically updated to reflect the committed changes.