Differential D28662

KCM LookAndFeel check widgetStyle availability before applying it
ClosedPublic
Actions

Authored by crossi on Apr 7 2020, 4:37 PM.

Details

Reviewers
ervin
bport
meven
ngraham
Group Reviewers
Plasma
Commits
R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it
Summary

BUG: 419552

  • Some Global Theme may refer to breeze widget style with a lower case b, apply the proper name Breeze

BUG: 418698

  • Some Global Theme use widget style that may not be installed, then don't apply it.
Test Plan
  • Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply it. Open Application Style KCM, if kvantum is not installed, Breeze is highlighted.
  • Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. Open Application Style KCM, Breeze is highlighted.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 25190
Build 25208: arc lint + arc unit
crossi created this revision.Apr 7 2020, 4:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2020, 4:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Apr 7 2020, 4:37 PM
ngraham accepted this revision.Apr 7 2020, 7:11 PM
ngraham added a subscriber: ngraham.

LGTM modulo some trivial code comment changes

Probably a candidate for the stable branch.

kcms/lookandfeel/kcm.cpp
268

s/theme/themes/

s/lower case/lowercase/

419

s/if can apply style/if style can be installed/

This revision is now accepted and ready to land.Apr 7 2020, 7:11 PM
ervin accepted this revision.Apr 8 2020, 3:41 PM
crossi edited the test plan for this revision. (Show Details)Apr 8 2020, 3:46 PM
crossi updated this revision to Diff 80067.Apr 14 2020, 8:46 AM

Fix comments

crossi marked 2 inline comments as done.Apr 14 2020, 8:47 AM
ervin accepted this revision.Apr 21 2020, 6:31 PM
Closed by commit R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it (authored by crossi). · Explain WhyApr 22 2020, 2:44 PM
This revision was automatically updated to reflect the committed changes.
heikobecker added a subscriber: heikobecker.May 5 2020, 7:46 PM

This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.:

14:11:19  FAIL!  : KcmTest::testKCMSave() Compared values are not the same
14:11:19     Actual   (cg.readEntry("widgetStyle", QString())): ""
14:11:19     Expected (QString("testValue"))                  : "testValue"
14:11:19     Loc: [/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]

https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console

crossi added a comment.May 11 2020, 11:59 AM
In D28662#664211, @heikobecker wrote:

This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.:

14:11:19  FAIL!  : KcmTest::testKCMSave() Compared values are not the same
14:11:19     Actual   (cg.readEntry("widgetStyle", QString())): ""
14:11:19     Expected (QString("testValue"))                  : "testValue"
14:11:19     Loc: [/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]

https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console

I will have a look at this test case. Thanks for reporting this.

Revision Contents
Changeset List

PathPackages
Mkcms/lookandfeel/kcm.cpp (22 lines)

Diff 80067

View Options

kcms/lookandfeel/kcm.cpp

Loading...