A 2gu margin is added if the sheet's content height is less than 3/4 of the screen
BUG: 419804
FIXED-IN: 5.70
Kirigami |
A 2gu margin is added if the sheet's content height is less than 3/4 of the screen
BUG: 419804
FIXED-IN: 5.70
No Linters Available |
No Unit Test Coverage |
Buildable 25086 | |
Build 25104: arc lint + arc unit |
Thanks for the patch, but why would you need the bottom margin to be customizable? Shouldn't the default be to simply center the sheet vertically when it's not as tall as the window, as (IIRC) it was before?
src/controls/templates/OverlaySheet.qml | ||
---|---|---|
108 | missing whitespace around the times sign | |
284 | missing whitespace around the plus sign | |
304 | ditto |
it was around the lower third.. now is attached to the bottom edge of the screen, which some user feedback seems to prefer it.
maaaybe, what's actually needed is a verticalAlign property?
I think having the overlaysheet glued to the bottom is fine for a very tall sheet that's scrollable or almost scrollable. But when it's not very tall, having it vertically centered makes more sense IMO. A short sheet glued to the bottom looks very weird to me. Rather than exposing yet another setting here, I think automatically choosing an alignment based on height would make more sense.
I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be improved:
Don't you think that might look better vertically centered?
Well, one of the ideas of Kirigami is to not spawn new windows when not needed. Maybe the basic QQC2 popup (which does open centered) needs to gain the same visual style as an OverlaySheet. Or maybe OverlaySheet should be able to be used as a centered pop-up thingy.
@mart, your thoughts?
The Dialog in QQC2 (not to be confused with the dialog from QtQuick Dialogs) isn't a separate window. It's a modal overlay on top of the current window, like any of the other Popup family members.
Okay. But then the difference between a sheet and a dialog is inherently nebulous: a short sheet is like a dialog; a tall dialog is like a sheet. In my mind it makes sense to use one thing for both and tweak the presentation accordingly. Clearly lots of people are using OverlaySheet as a dialog.