Remove Icons from system tray item tooltips
ClosedPublic

Authored by ngraham on Apr 6 2020, 5:30 PM.

Details

Summary

It was decided in T12778 to remove icons from tooltips for panel widgets and system tray
items. This patch implements that for system tray items, and removes the supporting code
from the backend.

Test Plan

Apply patch
Hover the cursor over system tray items, either in the compat applet or the expanded
representation
No more redundant or inconsistent icons visible

Diff Detail

Repository
R120 Plasma Workspace
Branch
remove-systemtray-tooltip-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24862
Build 24880: arc lint + arc unit
ngraham created this revision.Apr 6 2020, 5:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2020, 5:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 6 2020, 5:30 PM
davidre added inline comments.
dataengines/statusnotifieritem/statusnotifieritemsource.cpp
342 ↗(On Diff #79510)

we consider the data engine public api, so we would have to keep this for now.
also the tooltipicon is part of the spec so maybe we should expose it in the engine regardless if someone else (not the systray apple) wants to do something with statusnotifieritems

ngraham updated this revision to Diff 79511.Apr 6 2020, 5:45 PM
ngraham marked an inline comment as done.

Revert change to remove code from the Data Engine

For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification after all. From the other side it will be inconsistent...

For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification after all. From the other side it will be inconsistent...

I would argue that the implementation is free to ignore it
Data structure that describes extra information associated to this item, that can be visualized for instance by a tooltip (or by any other mean the visualization consider appropriate.
The appropriate one being not at all in this case ;)

kmaterka requested changes to this revision.Apr 6 2020, 9:18 PM

I would argue that the implementation is free to ignore it
Data structure that describes extra information associated to this item, that can be visualized for instance by a tooltip (or by any other mean the visualization consider appropriate.
The appropriate one being not at all in this case ;)

OK, makes sense.

@ngraham Only one little detail: please remove icon from comment /* subclasses need to assign to this tooltip properties in AbstractItem.qml

This revision now requires changes to proceed.Apr 6 2020, 9:18 PM
ngraham updated this revision to Diff 79545.Apr 7 2020, 12:08 AM

Remove no-longer-relevant reference to icon in AbstractItem.qml

kmaterka accepted this revision.Apr 7 2020, 8:41 AM

Remove no-longer-relevant reference to icon in AbstractItem.qml

Thanks, accepted.

This revision is now accepted and ready to land.Apr 7 2020, 8:41 AM
This revision was automatically updated to reflect the committed changes.