Converted to page and added Heading
ClosedPublic

Authored by niccolove on Apr 4 2020, 8:43 PM.

Details

Summary

As per D28575, converted the FullRepr to be a Page and added a PlasmoidHeading

Result:

Depends on D28575

Test Plan

Test with D28575

Diff Detail

Repository
R120 Plasma Workspace
Branch
notification_page_heading (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24765
Build 24783: arc lint + arc unit
niccolove created this revision.Apr 4 2020, 8:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 4 2020, 8:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Apr 4 2020, 8:43 PM
niccolove planned changes to this revision.Apr 4 2020, 8:43 PM
niccolove edited the summary of this revision. (Show Details)
niccolove updated this revision to Diff 79347.Apr 4 2020, 8:52 PM

Fixed context menu

mart accepted this revision.Apr 6 2020, 9:13 AM
This revision is now accepted and ready to land.Apr 6 2020, 9:13 AM
mart added a comment.Apr 6 2020, 9:15 AM

is the no notification message now uncentered related to this commit?

Yes, also the notifications don't fill width, just noticed, I'm investigating

niccolove updated this revision to Diff 79484.Apr 6 2020, 2:05 PM

Fixed layouts

Ok, should be fine now

Needs a rebase, but LGTM!

This revision was automatically updated to reflect the committed changes.