Currently this dbus interface allows the notification server to pass the
notifications, which then are forwarded to greeter theme by calling the
Notify method on the root object.
This is alternative to D28428
Currently this dbus interface allows the notification server to pass the
notifications, which then are forwarded to greeter theme by calling the
Notify method on the root object.
This is alternative to D28428
tested using mobile greeter
No Linters Available |
No Unit Test Coverage |
Buildable 24550 | |
Build 24568: arc lint + arc unit |
I'd say we go for the simplest solution +++
Given we have MPRIS on here, if we were to do any DBus lockdowns we would almost certainly want to use xdg-dbus-proxy, at which point this would continue to work.
greeter/greeterapp.cpp | ||
---|---|---|
141 | Register objects before registering a service. DBus receiving is in another thread so you could hypothetically get a message between the two events. Doesn't really matter if we lose a notification in this case, but it's a good practice | |
500 | This pattern of fetching and poking the root object of a scene isn't one I like, it's better to expose an object to the view that then has normal signals and slots - but this does follow the convention already here, so I can't really object. | |
greeter/greeterapp.h | ||
52 | You don't need this if you're using an adaptor |
greeter/greeterapp.cpp | ||
---|---|---|
500 | Let's add a todo for future? Once this is done, I do have plan to change the OSD bit to also use greeter directly, instead of wayland protocol bit. That time I can update that. |