Differential D28340

Figure out nested wayland dismantle
ClosedPublic
Actions

Authored by apol on Mar 27 2020, 1:19 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:7db91295217d: Figure out nested wayland dismantle
Summary

Fixes a crash we would get, we're changing 2 main things:

  • release the event queue first, otherwise we'd serve events to

disappearing objects.

  • destroy the connection thread object after the thread has quit.
Test Plan

KWin doesn't explode when closing.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24455
Build 24473: arc lint + arc unit
apol created this revision.Mar 27 2020, 1:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 27 2020, 1:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Mar 27 2020, 1:19 PM
davidedmundson added a subscriber: davidedmundson.Mar 27 2020, 1:21 PM
davidedmundson added inline comments.
plugins/platforms/wayland/wayland_backend.cpp
480

Does that work?

The thread the threadObject is in isn't running anymore.

apol added inline comments.Mar 27 2020, 1:27 PM
plugins/platforms/wayland/wayland_backend.cpp
480

The destructor gets called.

davidedmundson accepted this revision.Mar 27 2020, 1:33 PM
This revision is now accepted and ready to land.Mar 27 2020, 1:33 PM
apol updated this revision to Diff 78874.Mar 30 2020, 11:40 AM

No need to position a plasma surface to a position that wasn't requested

apol updated this revision to Diff 78875.Mar 30 2020, 11:41 AM

this was meant for another patch

Closed by commit R108:7db91295217d: Figure out nested wayland dismantle (authored by apol). · Explain WhyMar 30 2020, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78874

View Options

plugins/platforms/wayland/wayland_backend.cpp

Loading...
View Options

xdgshellclient.cpp

Loading...