Add unittest
ClosedPublic

Authored by shubham on Jan 17 2020, 3:11 PM.

Details

Test Plan

ctest passes!

Diff Detail

Repository
R352 Filelight
Branch
unittests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24384
Build 24402: arc lint + arc unit
shubham created this revision.Jan 17 2020, 3:11 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 17 2020, 3:11 PM
shubham requested review of this revision.Jan 17 2020, 3:11 PM
shubham updated this revision to Diff 73773.Jan 17 2020, 3:11 PM

Correct diff

@sandsmark I am getting linker error any help?

undefined reference to `File::displayName() const'
CMakeFiles/testFileTree.dir/testFileTree.cpp.o: In function `TestFileTree::testFilePath()':

missing export symbol ?
Missing linking against lib ?

This revision is now accepted and ready to land.Jan 19 2020, 1:22 PM

lgtm

Does this works for you?
I get linker error here.

mlaurent added inline comments.Feb 24 2020, 12:55 PM
autotests/core/testFileTree.cpp
26

Are you sure that it will work when we build in separate directory ?

@mlaurent I did not get what you meant? Please clarify

In shadow build
mkdir build && cd build && cmake ../ && make test
is it work ?

shubham updated this revision to Diff 78748.EditedMar 28 2020, 7:00 PM

Rebase
I have linked the libs, but still linker error. Any help?

shubham updated this revision to Diff 78749.Mar 28 2020, 7:13 PM

Fix linker error

shubham updated this revision to Diff 78751.Mar 28 2020, 7:14 PM

Fix linker error

shubham retitled this revision from Add unittests to Add unittest.Mar 28 2020, 7:18 PM
shubham edited the test plan for this revision. (Show Details)
shubham marked an inline comment as done.

Can I go ahead pushing this? @mlaurent @sandsmark

autotests/core/testFileTree.cpp
26

Yup, this works.

mlaurent accepted this revision.Mar 31 2020, 6:11 AM

yep. Thanks

This revision was automatically updated to reflect the committed changes.
shubham marked an inline comment as done.