Differential D28282

KCM/GlobalShortut: convert FOREACH and old signal syntax
ClosedPublic
Actions

Authored by meven on Mar 25 2020, 2:50 PM.

Details

Reviewers
ervin
bport
crossi
hchain
Group Reviewers
Plasma
Commits
R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old signal syntax
Test Plan

Builds, changed a shortcut and back again

Diff Detail

Repository
R119 Plasma Desktop
Branch
shortcuts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24251
Build 24269: arc lint + arc unit
meven created this revision.Mar 25 2020, 2:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 25 2020, 2:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Mar 25 2020, 2:50 PM
davidedmundson added a subscriber: davidedmundson.Mar 25 2020, 10:06 PM
davidedmundson added inline comments.
kcms/keys/globalshortcuts.cpp
42

Use markAsChanged then you don't need to overload.

kcms/keys/kglobalshortcutseditor.h
84

why not const QStringList &

ahmadsamir added a subscriber: ahmadsamir.Mar 26 2020, 7:56 AM
ahmadsamir added inline comments.
kcms/keys/export_scheme_dialog.cpp
46

const QString &

74

const QAbstractButton *button

kcms/keys/kglobalshortcutseditor.cpp
708

I would make the ComponentData::editor() method const, then 'const ComponentData *cd'.

meven updated this revision to Diff 78522.Mar 26 2020, 8:38 AM
meven marked 4 inline comments as done.

Review comments, code formating more const

meven marked an inline comment as done.Mar 27 2020, 1:18 PM
bport added a comment.Mar 30 2020, 11:25 AM

Some coding style nitpicking

kcms/keys/export_scheme_dialog.cpp
46

{ on same line

74

{ on same line

kcms/keys/kglobalshortcutseditor.cpp
168

you have an unneeded space after (

543

{ on same line

832

{ same line

meven updated this revision to Diff 78913.Mar 30 2020, 4:00 PM
meven marked 5 inline comments as done.

Adress review (formatting) and fix a couple of indentation issues

ervin accepted this revision.Apr 7 2020, 4:13 PM
This revision is now accepted and ready to land.Apr 7 2020, 4:13 PM
meven updated this revision to Diff 80614.Apr 20 2020, 7:59 AM

Rebasing

meven updated this revision to Diff 80616.Apr 20 2020, 8:09 AM

Fix for loop

ervin accepted this revision.Apr 21 2020, 6:19 PM
Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old signal syntax (authored by meven). · Explain WhyApr 22 2020, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78522

View Options

kcms/keys/export_scheme_dialog.cpp

Loading...
View Options

kcms/keys/globalshortcuts.cpp

Loading...
View Options

kcms/keys/kglobalshortcutseditor.h

Loading...
View Options

kcms/keys/kglobalshortcutseditor.cpp

Loading...
View Options

kcms/keys/select_scheme_dialog.cpp

Loading...