It's invoked from QML.
Nested event loops invoked directly from QML is asking for crashes.
BUG: 419118
Details
Details
- Reviewers
apol - Group Reviewers
KWin - Commits
- R108:bee3afdd5194: [kcmkwin] Make dialog non blocking
R108:0a65681596c3: [kcmkwin] Make dialog non blocking
Opened KCM
Opened dialog for some settings
Window was still modal as before
Settings were saved
(though they didn't seem to be applied..maybe another bug?)
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24241 Build 24259: arc lint + arc unit
Comment Actions
Heh, it appears like both Eike and I used code from the old effects kcm without thinking if it's actually okay. Thank you for fixing this issue.
(though they didn't seem to be applied..maybe another bug?)
No, they're applied. What effects did you try to configure?
| kcmkwin/common/effectsmodel.cpp | ||
|---|---|---|
| 669–671 | The lambda is redundant. I think you could just connect KCModule::save() directly, e.g. connect(dialog, &QDialog::accepted, module, &KCModule::save); | |