Differential D25301

Move createUDSEntry from file.cpp to file_unix.cpp
ClosedPublic
Actions

Authored by meven on Nov 14 2019, 10:15 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:c5009b8b4ab9: Move createUDSEntry from file.cpp to file_unix.cpp
Summary

This was a unix only function in the shared file protocol cpp
This has not been used at all in file_win.cpp for a while

Diff Detail

Repository
R241 KIO
Branch
arcpatch-D25301
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24021
Build 24039: arc lint + arc unit
meven created this revision.Nov 14 2019, 10:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 14 2019, 10:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 14 2019, 10:15 AM
dfaure accepted this revision.Feb 2 2020, 10:32 AM

Well spotted.

Sorry for the delay in my review.

This revision is now accepted and ready to land.Feb 2 2020, 10:32 AM
meven added a comment.Feb 2 2020, 6:21 PM

I have currently a couple of patches touching the same lines, so I will postpone this land after to save me some rebasing time.

meven updated this revision to Diff 78141.Mar 21 2020, 9:15 AM

Rebase on master

dfaure accepted this revision.Mar 21 2020, 11:33 AM
dfaure added inline comments.
src/ioslaves/file/file_unix.cpp
147

static

164

static

248

static

meven updated this revision to Diff 78159.Mar 21 2020, 12:38 PM
meven marked 3 inline comments as done.

Add 3 missing static

dfaure accepted this revision.Mar 21 2020, 12:43 PM
Closed by commit R241:c5009b8b4ab9: Move createUDSEntry from file.cpp to file_unix.cpp (authored by meven). · Explain WhyMar 22 2020, 10:53 AM
This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Mar 22 2020, 12:14 PM

Fails to build here

file_unix.cpp:384:9: error: ‘appendACLAtoms’ was not declared in this scope

I'll investigate. You might want to install the necessary libs for the ACL code to be enabled on your system.

Revision Contents
Changeset List

Diff 78159

View Options

src/ioslaves/file/file.h

Loading...
View Options

src/ioslaves/file/file.cpp

Loading...
View Options

src/ioslaves/file/file_unix.cpp

Loading...