The config keys/sorting enum have been moved to a new file, before this the runner included the header of the config class.
This patch originated from https://phabricator.kde.org/D27513, but it was requested to split it up into separate patches.
Details
Details
Should compile.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- arcpatch-D27576
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24006 Build 24024: arc lint + arc unit
Comment Actions
Minor nitpick
So the code basically extracts from KillRunnerConfigForm the Config constants.
| runners/kill/killrunner.cpp | ||
|---|---|---|
| 65 | You can use the enum as default value here I guess : Sort::NONE | |
| runners/kill/killrunner.cpp | ||
|---|---|---|
| 65 | What you suggested is not possible, because the enum is not declared as an enum qobject and declaring it just for this one occurrence seems unnecessary to me :-). | |
Comment Actions
Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch).
What is the best way to solve this?
Comment Actions
Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch).
git config user.name
then
git commit --amend --author "Your Name <youremail>"