what's this for?

This is an odd method name.

I don't really understand what it's doing, some sort of title casing?

so who cleans this up?

use url.path and url.protocol for this not string manipulation

why are we resetting the whole model instead of just dataChanged() on the relevant row

The ones not logged in will be sorted randomly.

Also note that if the intention is to have your user at the top, this check won't suffice as you can have 2 things logged in.

this is marked as done, yet I can't see where ?

used as a hook for QML to know when the KCM needs to apply

taking the initials of a user's real name

whoever is normally cleaning up tempfiles

i couldn't figure out how to use those correctly. some help would be appreciated.

Also note that if the intention is to have your user at the top, this check won't suffice as you can have 2 things logged in.

loggedIn compares the UID of the user to the UID of the currently running program, which means only one user can be logged in at a time by our metric.

users are parented to the model, which will use normal QObject destructor behaviour to clean them

OH!

Initial-ise

not initialise as in "to prepare"

Makes sense :)

This one isn't parented to the model

Normally the app creating a temp file would clean it up.

A quick fix would be
file = new QTemporaryFile(this);

It's sort of leaking the object, but on exit it'll tidy everything up.

Then it should have a different name, like "getInitials", else the next person will be just as confused

that looks like it could possibly run into race conditions, as the applyjob is executed asynchronously and IIRC is able to still be running when everything else, including this, has destructed and removed one of the files it could be using

new QTemporaryFile(qApp) then

KJobs have an QEventLoopLocker that will stop qApp from quitting until they finish so you can be sure your applyjob is done.

Use property var, or even property QtObject since User is a QObject

i18n

Is this a RoundButton bug that it doesn't indicate keyboard focus when I tab to it?

Pfp?

readonly property

I *think* one needs to multiple that with Screen.devicePixelRatio

Can you add some way to make Escape close the sheet but not the entire KCM, when run standalone through kcmshell? Hopefully the following is sufficient, otherwise you'd have to mess with FocusScope and the like:

Keys.onEscapePressed: {
    close();
    event.accepted = true;
}

Is this RowLayout needed?

Can we not hardcode the list of avatars, please.
Also, you probably want to use a proper GridView for all of this, otherwise you end up creating every single delegate immediately on opening.

A tooltip and Accessible.name with the name of the avatar would be nice

Is this ColumnLayout needed?

What's all of this? I don't see anything in the UI.
Anyway, we probably want to make all of this into a proper QAbstractListModel

Not sure if clever or mad :) Can we not just generate a colored rectangle on C++ side?

I just learned that you need to pass QAbstractItemModel::CheckIndesOptions::IndexIsValid otherwise it only checks for blatant out of bounds indices but not invalid "Null" ones :/

FWIW KCMs opened through KRunner are now opened in System Settings so KCMShell is something we're going to have to deal with much less. :)

Yes, but it's still something to consider. Right now Esc does nothing at all, and neither do arrow keys. This thing needs some FocusScope treatment

profile picture

it's a convenience for the default alignment of a layout (Qt.AlignVCenter | Qt.AlignLeft)