fix: make hwdata truly a runtime dependency
ClosedPublic
Actions

plugins/platforms/drm/edid.cpp
149	You can't hardcode /use/share If we do go runtime only, please use QStandardPaths Though I don't yet fully understand the need to avoid the compile time switch, there were comments on what to fix in the last patch.

This revision now requires changes to proceed.Mar 2 2020, 7:44 AM

So what is the preferred solution? Make it a compile-time dependency, or runtime, with using QStandardPaths?

Where are we with this? KWin is still failing to build for me in master and has been for weeks. I have hwdata installed and available. What else is needed? How do we fix this?

So what is the preferred solution? Make it a compile-time dependency, or runtime, with using QStandardPaths?

Either works

wstephenson added a subscriber: wstephenson.Mar 17 2020, 8:51 AM

iasensio added a subscriber: iasensio.Mar 17 2020, 1:34 PM

Use QStandardPaths

Harbormaster completed remote builds in B23814: Diff 77824.Mar 17 2020, 2:08 PM

zzag accepted this revision.Mar 17 2020, 2:10 PM

davidedmundson accepted this revision.Mar 17 2020, 2:20 PM

This revision is now accepted and ready to land.Mar 17 2020, 2:20 PM

Closed by commit R108:9bd91e66cddf: fix: make hwdata truly a runtime dependency (authored by dvratil). · Explain WhyMar 17 2020, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			cmake/modules/Findhwdata.cmake (2 lines)
M			config-kwin.h.cmake (5 lines)
M			plugins/platforms/drm/edid.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76660	fcea0eb		Feb 28 2020, 8:27 PM	★	★
Diff 2	77824	fcea0eb	* Use QStandardPaths	Mar 17 2020, 2:08 PM	★	★
Diff 3	77829	3e9f33b	R108:9bd91e66cddf6e1319b54ea406b7d3a21f21b97f	Mar 17 2020, 2:39 PM	★	★