Followup to comments in D10041
Details
Details
- Reviewers
ngraham davidedmundson zzag - Group Reviewers
Plasma - Commits
- R108:9bd91e66cddf: fix: make hwdata truly a runtime dependency
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- arcpatch-D27729
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 23814 Build 23832: arc lint + arc unit
plugins/platforms/drm/edid.cpp | ||
---|---|---|
149 | Can you please explain why we can't use HWDATA_PNPIDS_FILE? |
plugins/platforms/drm/edid.cpp | ||
---|---|---|
149 | ok, nvm. |
plugins/platforms/drm/edid.cpp | ||
---|---|---|
149 | You can't hardcode /use/share If we do go runtime only, please use QStandardPaths Though I don't yet fully understand the need to avoid the compile time switch, there were comments on what to fix in the last patch. |
Comment Actions
So what is the preferred solution? Make it a compile-time dependency, or runtime, with using QStandardPaths?
Comment Actions
Where are we with this? KWin is still failing to build for me in master and has been for weeks. I have hwdata installed and available. What else is needed? How do we fix this?
Comment Actions
So what is the preferred solution? Make it a compile-time dependency, or runtime, with using QStandardPaths?
Either works