A user might find odd that when a known device in the UI is unmounted, it disappears.
Despite the fact that restarting the kcm would show it.
Details
Open kcmshell5 device_automounter_kcm
Plug in a usb stick, set a setting for it and Apply
Unplug the stick
Before:
The disconnected usb stick does not appear
After:
The usb stick appears at the bottom of the disconnected section
Forget the stick in the UI and Apply
Plug in the usb stick
Unplug it
The usb stick is not visible (as before)
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- arcpatch-D27024
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23524 Build 23542: arc lint + arc unit
solid-device-automounter/kcm/DeviceModel.cpp | ||
---|---|---|
104 | I think we need a further update of the comment, indeed it starts with "the device is not moved to"... but clearly not it is. I'd probably revert it with something like "We move the device for the disconnected section only if..." with then further explanations (some of the points mentioned can be kept). In its current form it's just more confusing | |
105 | Missing space before { |
I guess extra care will need to be taken with your other patch moving away from the singleton (dunno which one is based on which, I might review out of order).