Differential D27926

Add flameshot tray icons
ClosedPublic
Actions

Authored by axionl on Mar 8 2020, 4:48 AM.

Details

Reviewers
ngraham
ndavis
Group Reviewers
VDG
Commits
R266:8c73f3f445ee: Add flameshot tray icons
Summary

Add the system tray icon for flameshot. This patch adds some icons following the breeze style.

Test Plan

Before:

After:

Diff Detail

Repository
R266 Breeze Icons
Lint
Lint Skipped
Unit
Unit Tests Skipped
axionl created this revision.Mar 8 2020, 4:48 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMar 8 2020, 4:48 AM
axionl requested review of this revision.Mar 8 2020, 4:48 AM
axionl retitled this revision from Add flameshot tray icons to [breeze-icons] Add flameshot tray icons.Mar 8 2020, 4:57 AM
ngraham requested changes to this revision.Mar 8 2020, 3:25 PM
ngraham added a subscriber: ngraham.

Thanks, this will be nice to have once the issue identified in my comment is resolved.

icons-dark/status/22/flameshot-tray.svg
3

Hardcoded colors alert! :)

You need to embed the stylesheet and make each path use it. Follow the pattern in other monochrome breeze icons, and see how to do that at https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Embedding_stylesheets_in_SVGs

This revision now requires changes to proceed.Mar 8 2020, 3:25 PM
axionl updated this revision to Diff 77223.Mar 8 2020, 4:35 PM

Update flameshot tray icon.

ngraham added a comment.Mar 8 2020, 4:49 PM

Nice!

Do you think you could also make 16px versions?

axionl marked an inline comment as done.Mar 8 2020, 5:06 PM
In D27926#624240, @ngraham wrote:

Nice!

Do you think you could also make 16px versions?

Sorry, maybe not. The 16px space is too small to get the correct angle to convert 1px thick strokes to paths on Inkscape.

ndavis added a subscriber: ndavis.Mar 8 2020, 11:10 PM

It's a systray icon, so it doesn't need to have a 16px version

ndavis accepted this revision.Mar 8 2020, 11:12 PM
ngraham accepted this revision.Mar 9 2020, 5:32 PM

Derp, silly me.

This revision is now accepted and ready to land.Mar 9 2020, 5:32 PM
ngraham retitled this revision from [breeze-icons] Add flameshot tray icons to Add flameshot tray icons.Mar 9 2020, 5:33 PM
Closed by commit R266:8c73f3f445ee: Add flameshot tray icons (authored by axionl, committed by ngraham). · Explain WhyMar 9 2020, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77223

View Options

icons-dark/status/22/flameshot-tray.svg

Loading...
View Options

icons/status/22/flameshot-tray.svg

Loading...