Differential D27793

Small improvements to the 'Export to PDF' feature
ClosedPublic
Actions

Authored by dvratil on Mar 2 2020, 9:11 PM.

Details

Reviewers
mlaurent
Commits
R206:8d4a51289268: Small improvements to the 'Export to PDF' feature
Summary
  • Capitalize "PDF"
  • Add the action to the KMReaderMainWin too
  • Set default filename to <subject>.pdf

Diff Detail

Repository
R206 KMail
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23164
Build 23182: arc lint + arc unit
dvratil created this revision.Mar 2 2020, 9:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 2 2020, 9:11 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Mar 2 2020, 9:11 PM
yurchor added a subscriber: yurchor.Mar 2 2020, 9:45 PM

Thanks in advance for fixing this minor issue.

src/messageactions.cpp
778

This should be i18n(), not QStringLiteral() as well.

dvratil updated this revision to Diff 76809.Mar 2 2020, 10:10 PM
  • Fix i18n
mlaurent added inline comments.Mar 3 2020, 5:51 AM
src/messageactions.cpp
776

Use "mParent" vs nullptr no ?

dvratil updated this revision to Diff 76818.Mar 3 2020, 8:10 AM
  • Use mParent
mlaurent accepted this revision.Mar 3 2020, 12:28 PM
This revision is now accepted and ready to land.Mar 3 2020, 12:28 PM
Closed by commit R206:8d4a51289268: Small improvements to the 'Export to PDF' feature (authored by dvratil). · Explain WhyMar 3 2020, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76809

View Options

src/kmmainwidget.h

Loading...
View Options

src/kmmainwidget.cpp

Loading...
View Options

src/kmreadermainwin.cpp

Loading...
View Options

src/kmreadermainwin.rc

Loading...
View Options

src/messageactions.h

Loading...
View Options

src/messageactions.cpp

Loading...